New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic neighbors #1283

Closed
vincentbernat opened this Issue Mar 25, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@vincentbernat
Copy link
Contributor

vincentbernat commented Mar 25, 2017

Hey!

When GoBGP acts as a route reflector, it would be convenient if it accepted any neighbors (or any neighbors in some subnet). This way, neighbors don't have to be pre-declared.

@fujita

This comment has been minimized.

Copy link
Member

fujita commented Jun 19, 2017

d75edf1

Can you try the latest?

@fujita fujita closed this Jun 19, 2017

@vincentbernat

This comment has been minimized.

Copy link
Contributor

vincentbernat commented Jun 19, 2017

Hummm, doesn't work for me. I am using this configuration:

global:
  config:
    as: 65000
    router-id: 1.0.0.2
    local-address-list:
      - 198.51.100.226
peer-groups:
  - config:
      peer-group-name: rr-client
      peer-as: 65000
    route-reflector:
      config:
        route-reflector-client: true
        route-reflector-cluster-id: 198.51.100.226
    add-paths:
      config:
        receive: true
        send-max: 8
dynamic-neighbors:
  - config:
      peer-group: rr-client
      prefix: 198.51.100.128/25

And when opening a session, I get:

{"level":"info","msg":"gobgpd started","time":"2017-06-19T16:20:35+02:00"}
{"Topic":"Config","level":"info","msg":"Finished reading the config file","time":"2017-06-19T16:20:35+02:00"}
{"level":"info","msg":"PeerGroup rr-client is added","time":"2017-06-19T16:20:35+02:00"}
{"Name":"rr-client","Topic":"Peer","level":"info","msg":"Add a peer group configuration","time":"2017-06-19T16:20:35+02:00"}
{"level":"info","msg":"Dynamic Neighbor 198.51.100.128/25 is added to PeerGroup rr-client","time":"2017-06-19T16:20:35+02:00"}
{"Key":"198.51.100.201","State":"BGP_FSM_OPENCONFIRM","Topic":"Peer","level":"info","msg":"Peer Up","time":"2017-06-19T16:20:35+02:00"}
{"Key":"198.51.100.201","State":"BGP_FSM_ESTABLISHED","Topic":"Peer","error":"Address-family rf 65537 not avalible for session","level":"warning","msg":"malformed BGP update message","time":"2017-06-19T16:20:35+02:00"}
{"Code":0,"Data":null,"Key":"198.51.100.201","State":"BGP_FSM_ESTABLISHED","Subcode":0,"Topic":"Peer","level":"warning","msg":"sent notification","time":"2017-06-19T16:20:35+02:00"}
{"Key":"198.51.100.201","Reason":"notification-sent code 0(undefined) subcode 0(undefined)","State":"BGP_FSM_ESTABLISHED","Topic":"Peer","level":"info","msg":"Peer Down","time":"2017-06-19T16:20:35+02:00"}

The same configuration with neighbors work:

global:
  config:
    as: 65000
    router-id: 1.0.0.2
    local-address-list:
      - 198.51.100.226
neighbors:
  - config:
      neighbor-address: 198.51.100.201
      peer-as: 65000
    route-reflector:
      config:
        route-reflector-client: true
        route-reflector-cluster-id: 198.51.100.226
    add-paths:
      config:
        receive: true
        send-max: 8
@fujimoto-s

This comment has been minimized.

Copy link
Contributor

fujimoto-s commented Jun 20, 2017

Sorry, this problem is due to fails in initializing dynamic peers.
I made a PR to fix this.
Could you try with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment