Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packet/tcp: Fix endless loop caused by malformed tcp option #50

Open
wants to merge 2 commits into
base: master
from

Conversation

@faicker
Copy link

faicker commented Jun 13, 2016

When the tcp option kind > 1 and length = 0, the parsing of option in the tcp.parse function will loop endless.

Signed-off-by: faicker.mo <faicker.mo@gmail.com>
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 13, 2016

Coverage Status

Coverage decreased (-0.001%) to 62.188% when pulling 14e37aa on faicker:bugfix_tcpoption into f864993 on osrg:master.

Signed-off-by: faicker.mo <faicker.mo@gmail.com>
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 13, 2016

Coverage Status

Coverage decreased (-0.001%) to 62.188% when pulling 2053fa4 on faicker:bugfix_tcpoption into f864993 on osrg:master.

@faicker faicker force-pushed the faicker:bugfix_tcpoption branch from 2053fa4 to bf42afb Jun 13, 2016
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 13, 2016

Coverage Status

Coverage decreased (-0.001%) to 62.188% when pulling bf42afb on faicker:bugfix_tcpoption into f864993 on osrg:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.