Skip to content

fix: check if existing deployment bucket is exist but empty & missing aws sdk v3 - S3 & Lambda commands #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2025
Merged

fix: check if existing deployment bucket is exist but empty & missing aws sdk v3 - S3 & Lambda commands #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5dadab
fix: adding missing AWS SDK v3 - S3 commands
KennethWKZ Nov 9, 2025
d02ea0a
fix: adding missing AWS SDK v3 - Lambda commands
KennethWKZ Nov 9, 2025
3d1ad0f
fix: check if existing deployment bucket is exist but empty
KennethWKZ Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions lib/aws/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ const {
RemovePermissionCommand,
ListFunctionsCommand,
ListLayersCommand,
ListLayerVersionsCommand,
DeleteLayerVersionCommand,
} = require('@aws-sdk/client-lambda');

// S3 Commands
Expand All @@ -114,6 +116,22 @@ const {
HeadBucketCommand,
GetBucketNotificationConfigurationCommand,
PutBucketNotificationConfigurationCommand,
CreateBucketCommand,
GetBucketEncryptionCommand,
PutBucketEncryptionCommand,
GetBucketVersioningCommand,
GetBucketLoggingCommand,
PutBucketVersioningCommand,
PutBucketLoggingCommand,
GetBucketAccelerateConfigurationCommand,
PutBucketAccelerateConfigurationCommand,
PutBucketPolicyCommand,
GetBucketTaggingCommand,
PutBucketTaggingCommand,
DeleteBucketTaggingCommand,
GetPublicAccessBlockCommand,
PutPublicAccessBlockCommand,
DeletePublicAccessBlockCommand,
} = require('@aws-sdk/client-s3');

// SSM Commands
Expand Down Expand Up @@ -218,7 +236,9 @@ const COMMAND_MAP = {
listAliases: ListAliasesCommand,
listFunctions: ListFunctionsCommand,
listLayers: ListLayersCommand,
listLayerVersions: ListLayerVersionsCommand,
getLayerVersion: GetLayerVersionCommand,
deleteLayerVersion: DeleteLayerVersionCommand,
addPermission: AddPermissionCommand,
removePermission: RemovePermissionCommand,
},
Expand All @@ -234,6 +254,22 @@ const COMMAND_MAP = {
headBucket: HeadBucketCommand,
getBucketNotificationConfiguration: GetBucketNotificationConfigurationCommand,
putBucketNotificationConfiguration: PutBucketNotificationConfigurationCommand,
createBucket: CreateBucketCommand,
getBucketEncryption: GetBucketEncryptionCommand,
putBucketEncryption: PutBucketEncryptionCommand,
getBucketVersioning: GetBucketVersioningCommand,
getBucketLogging: GetBucketLoggingCommand,
putBucketVersioning: PutBucketVersioningCommand,
putBucketLogging: PutBucketLoggingCommand,
getBucketAccelerateConfiguration: GetBucketAccelerateConfigurationCommand,
putBucketAccelerateConfiguration: PutBucketAccelerateConfigurationCommand,
putBucketPolicy: PutBucketPolicyCommand,
getBucketTagging: GetBucketTaggingCommand,
putBucketTagging: PutBucketTaggingCommand,
deleteBucketTagging: DeleteBucketTaggingCommand,
getPublicAccessBlock: GetPublicAccessBlockCommand,
putPublicAccessBlock: PutPublicAccessBlockCommand,
deletePublicAccessBlock: DeletePublicAccessBlockCommand,
// Note: upload is handled separately as it's not a direct API call
},

Expand Down
4 changes: 2 additions & 2 deletions lib/plugins/aws/deploy/lib/check-for-changes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ module.exports = {
);
}
})();
const objects = result.Contents.filter(({ Key: key }) =>
const objects = result?.Contents?.filter(({ Key: key }) =>
isDeploymentDirToken(key.split('/')[3])
);
if (!objects.length) return [];
if (!objects?.length) return [];

const ordered = _.orderBy(objects, ['Key'], ['desc']);

Expand Down