🌱 publish docker images to GitHub Container Registry#1453
Merged
spencerschrock merged 2 commits intoossf:mainfrom Nov 13, 2024
Merged
🌱 publish docker images to GitHub Container Registry#1453spencerschrock merged 2 commits intoossf:mainfrom
spencerschrock merged 2 commits intoossf:mainfrom
Conversation
The goal is to use GHCR to replace Google Container Registry (GCR) for
future versions of Scorecard Action releases. These workflows will build
two types of images:
1. Release images, which are tagged following a v1.2.3 pattern. These
container images will be retained indefinitely.
2. Per-commit images for each push to main. These images are used when
testing the action, and will be removed after a week.
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
a team,
justaugustus and
naveensrinivasan
and removed request for
a team
raghavkaul
reviewed
Nov 13, 2024
raghavkaul
left a comment
raghavkaul
left a comment
There was a problem hiding this comment.
What is the network egress cost and why does it not apply with GHCR?
Member
Author
When someone runs the action, it pulls our gcr.io image, which has pricing associated with it
GHCR is free for public packages. And also has a section later on about GitHub Actions
|
raghavkaul
approved these changes
Nov 13, 2024
spencerschrock
added a commit
to spencerschrock/scorecard-webapp
that referenced
this pull request
Nov 13, 2024
With the switch to GHCR we'll need to support both images for e2e testing. Eventually we can remove the gcr.io case if needed. ossf/scorecard-action#1453 Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
added a commit
to ossf/scorecard-webapp
that referenced
this pull request
Nov 13, 2024
With the switch to GHCR we'll need to support both images for e2e testing. Eventually we can remove the gcr.io case if needed. ossf/scorecard-action#1453 Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
added a commit
to ossf-tests/scorecard-action
that referenced
this pull request
Nov 13, 2024
ossf#1453 Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
added a commit
to ossf-tests/scorecard-action
that referenced
this pull request
Nov 13, 2024
ossf#1453 Signed-off-by: Spencer Schrock <sschrock@google.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to use GHCR to replace Google Container Registry (GCR) for future Scorecard Action releases to reduce network egress costs. These workflows will build two types of images:
The workflow was primarily based on GitHub's example workflow. You can see this working in my fork:
latestimage, with no attestation workflow