Skip to content

SRT: url supports multiple QueryStrings#2908

Merged
winlinvip merged 8 commits intoossrs:4.0releasefrom
zhouxiaojun2008:bugfix/fix-srt-url
Mar 19, 2022
Merged

SRT: url supports multiple QueryStrings#2908
winlinvip merged 8 commits intoossrs:4.0releasefrom
zhouxiaojun2008:bugfix/fix-srt-url

Conversation

@zhouxiaojun2008
Copy link
Contributor

@zhouxiaojun2008 zhouxiaojun2008 commented Feb 9, 2022

SRT: url supports multiple QueryStrings by comma-separated key-value pairs with no nesting #2893

@zhouxiaojun2008 zhouxiaojun2008 changed the title SRT: parse srt url to supports multiple QueryStrings. SRT: url supports multiple QueryStrings by comma-separated key-value pairs with no nesting (#2893) Feb 9, 2022
@zhouxiaojun2008 zhouxiaojun2008 changed the title SRT: url supports multiple QueryStrings by comma-separated key-value pairs with no nesting (#2893) SRT: url supports multiple QueryStrings Feb 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #2908 (c2d74d5) into 4.0release (06cff31) will increase coverage by 0.09%.
The diff coverage is 86.36%.

@@              Coverage Diff               @@
##           4.0release    #2908      +/-   ##
==============================================
+ Coverage       55.96%   56.06%   +0.09%     
==============================================
  Files             152      153       +1     
  Lines           56886    56933      +47     
==============================================
+ Hits            31839    31921      +82     
+ Misses          25047    25012      -35     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/srt/srt_handle.cpp | 0.00% <0.00%> (ø) | |'

Translated to English while maintaining the markdown structure:

'| trunk/src/srt/srt_handle.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/srt/srt_conn.cpp | 34.58% <80.00%> (+34.58%) | ⬆️ |
| trunk/src/utest/srs_utest_srt.cpp | 100.00% <100.00%> (ø) | |
| trunk/src/srt/stringex.hpp | 0.00% <0.00%> (ø) | |

'

Translated to English while maintaining the markdown structure:

'| trunk/src/utest/srs_utest_srt.cpp | 100.00% <100.00%> (ø) | |
| trunk/src/srt/stringex.hpp | 0.00% <0.00%> (ø) | |


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data'

Translated to English while maintaining the markdown structure:

'> Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 06cff31...c2d74d5. Read the comment docs.

TRANS_BY_GPT3

@johzzy

This comment was marked as resolved.

@winlinvip winlinvip added the Feature It's a new feature. label Mar 7, 2022
@winlinvip winlinvip linked an issue Mar 19, 2022 that may be closed by this pull request
@winlinvip winlinvip merged commit 210cdf0 into ossrs:4.0release Mar 19, 2022
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature It's a new feature. TransByAI Translated by AI/GPT.

Development

Successfully merging this pull request may close these issues.

SRT: Support multiple querystring for authentication.

4 participants