Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itest-pull-space: Use mkfs.ext4, align to at least 512b #2832

Merged
merged 1 commit into from Mar 15, 2023

Conversation

cgwalters
Copy link
Member

XFS now seems to want filesystems larger than 300MB, so switch to ext4. Also use 20MiB so we align to 512b sectors to squash a losetup warning.
Also tweak some of the numbers to still work.

XFS now seems to want filesystems larger than 300MB, so switch
to ext4.  Also use `20MiB` so we align to 512b sectors to squash
a `losetup` warning.
Also tweak some of the numbers to still work.
@nanonyme
Copy link
Contributor

Doesn't this use dramatically different codepaths in ostree? XFS supports reflinks while Ext4 does not.

@cgwalters
Copy link
Member Author

ostree only optionally uses reflinks for handling /etc, nothing in simply pulling a commit involves reflinks. (We can't hard require reflinks; see some related discussion recently here rpm-software-management/rpm#2378 (comment) )

@cgwalters cgwalters merged commit c5bfd67 into ostreedev:main Mar 15, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants