From 416ce7a079fb64c9b2c25b0048af85282b007655 Mon Sep 17 00:00:00 2001 From: WouterJ Date: Sat, 26 Jul 2014 11:54:23 +0200 Subject: [PATCH] Unify null comparisons --- Resources/views/Collector/time.html.twig | 2 +- Resources/views/Profiler/layout.html.twig | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Resources/views/Collector/time.html.twig b/Resources/views/Collector/time.html.twig index 3de04737744d2..01850b380cc34 100644 --- a/Resources/views/Collector/time.html.twig +++ b/Resources/views/Collector/time.html.twig @@ -370,7 +370,7 @@ this.getThreshold = function() { var threshold = Sfjs.getPreference(_storagePrefix + 'threshold'); - if (threshold === null) { + if (null === threshold) { return _threshold; } diff --git a/Resources/views/Profiler/layout.html.twig b/Resources/views/Profiler/layout.html.twig index 4cbecc04996de..2933564de8379 100644 --- a/Resources/views/Profiler/layout.html.twig +++ b/Resources/views/Profiler/layout.html.twig @@ -68,20 +68,20 @@ menu = document.getElementById('navigation'), savedState = Sfjs.getPreference('menu/displayState'), displayState, elem, className; - if (savedState == null) { + if (null === savedState) { savedState = 'block'; } - displayState = state || (savedState == 'block' ? 'none' : 'block'); + displayState = state || ('block' === savedState ? 'none' : 'block'); - if (typeof doSave === 'undefined') { + if ('undefined' === typeof doSave) { doSave = true; } document.getElementById('searchBar').style.display = displayState; document.getElementById('adminBar').style.display = displayState; - if (displayState == 'block') { + if ('block' === displayState) { Sfjs.removeClass(menu, 'collapsed-menu'); Sfjs.removeClass(menu.parentNode.parentNode, 'collapsed-menu-parents'); @@ -107,7 +107,7 @@ } window.setTimeout(function() { - if (document.getElementById('menu-profiler') == null) { + if (null === document.getElementById('menu-profiler')) { return; } @@ -119,12 +119,12 @@ } for (elem in menuItems) { - if (typeof(menuItems[elem].children) != 'undefined' && + if (typeof(menuItems[elem].children) !== 'undefined' && menuItems[elem].children.length > 0) { child = menuItems[elem].children[0] - if (child.getAttribute('title') == '' || - child.getAttribute('title') == null) { + if ('' === child.getAttribute('title') || + null === child.getAttribute('title')) { value = child.text.replace(/^\s+/g, '').split('\n')[0].replace(/\s+$/g, ''); child.setAttribute('title', value); }