Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client side validation for custom elements #1866

Merged
merged 3 commits into from May 14, 2019

Conversation

luisgreg99
Copy link
Contributor

@luisgreg99 luisgreg99 commented May 14, 2019

fixes #1362

  • Adds HTML5 validation on "Save" to 'Other value' inputs so that a form reload is not required when validating these custom elements.
  • The update applies to degree_field, degree_name, degree_level, degree_grantors, other_affiliation

image

image

@revgum revgum merged commit ae0630f into master May 14, 2019
@revgum revgum deleted the add-client-side-validation-for-custom-elements branch May 14, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom other options not being restored in the forms on a failed validation
2 participants