Get all versions of GCC working on Apple ARM systems. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add missing versions of GCC to the README.
|
Thanks @DavidEGrayson! It would be better to do separate PRs for each formula, because CI will try to build them all and it will take forever... |
ladislas
approved these changes
Jun 18, 2021
Comment on lines
+10
to
+18
| - GCC 5.5.0 - provided as `avr-gcc@5` | ||
| - GCC 8.4.0 - provided as `avr-gcc@8` | ||
| - GCC 10.2.0 - provided as `avr-gcc@10` | ||
| - GCC 11.1.0 - provided as `avr-gcc@11` | ||
| - Binutils 2.35.1 - provided as `avr-binutils` | ||
| - AVR Libc 2.0.0 - provided as a ressource for each GCC formula | ||
| - AVR Libc 2.0.0 - provided as a resource for each GCC formula | ||
| - GDB 10.1 - provided as `avr-gdb` | ||
|
|
||
| Support for older GCC versions (4, 5, 6, 7) has been removed. Please, raise an issue if you need one back. | ||
| Support for older GCC versions (4, 6, 7) has been removed. Please, raise an issue if you need one back. |
|
Great, thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just takes the changes that we did to avr-gcc@11 for ARM support and applies them to all the other GCC versions.
The patch I used for GCC 11 happens to work for all the other versions, and I tested that it is at least necessary for GCC 9. I assume it is necessary for all the other versions too.
I did not test this pull request out on any hardware, but after installing the formulas successfuly on an M1 Mac Mini, I ran these commands successfully:
I also used commands like
diff -ur avr-gcc@11.rb avr-gcc@9.rbto make sure that I remembered to apply all the changes.And I added GCC 11 and GCC 5 to the README since it seems like they were missing.