Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes hangs on truncated writes #2
Conversation
Writes should stop when the filesystem refuses to accept additional data, rather than looping infinitely. This is consistent with reads and with the Linux fuse behavior. In this particular case, the looping was actually within uiomove(), due to the inconsistent update of the uio, though other iov configurations might have misbehaved differently.
Writes should stop when the filesystem refuses to accept additional data, rather than looping infinitely. At present, the buffered write code doesn't understand the concept of fixed-length files, and now reports an I/O error when the filesystem doesn't accept all the data (instead of reporting the short count). The Linux fuse code appears (by inspection, not experiment) to misbehave the same way.
This comment has been minimized.
This comment has been minimized.
|
Version 2.7.4 including the fix has been released. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fhgwright commentedDec 31, 2014
This is broken into two commits, one for the direct_io case, and one for the non-direct_io case, as mentioned in osxfuse/osxfuse#187 .