{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":136088756,"defaultBranch":"master","name":"pytorch","ownerLogin":"ot","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2018-06-04T22:15:09.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/17024?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1715605533.0","currentOid":""},"activityList":{"items":[{"before":"d4ec839480536f821c7bf62f200f89fb5e2b20db","after":"5d3da6e39e99b99f60315aadecdc30b92dd152fd","ref":"refs/heads/export-D57275456","pushedAt":"2024-05-13T13:06:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ot","name":"Giuseppe Ottaviano","path":"/ot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17024?s=80&v=4"},"commit":{"message":"[caffe2] Make all get_backtrace() implementations lazy (#126064)\n\nSummary:\n\n\n#125682 (D56586844) added support for lazy symbolization to `Error` and adopted it for internal use cases; this commit adopts it for `get_backtrace()` as well.\n\nTest Plan:\nSandcastle and GH CI.\n\nNOTE: This is a resubmit of D56881683, a spurious copypasted line in the Android implementation broke the build, but this was not surfaced by diff tests.\n\nReproed the breakage with\n```\n$ fbpython scripts/build_android_app/build_android_app.py --buck-config-files='@//fbandroid/mode/have_libgflags @//fbandroid/mode/static_linking @//xplat/langtech/mobile/android_opt_buck_config_with_et_boltnn' --build-target='fbsource//xplat/langtech/mobile:transcribe_binAndroid-android-arm64'\n```\nVerified that the fixed diff builds successfully.\n\nDifferential Revision: D57275456","shortMessageHtmlLink":"[caffe2] Make all get_backtrace() implementations lazy (pytorch#126064)"}},{"before":null,"after":"d4ec839480536f821c7bf62f200f89fb5e2b20db","ref":"refs/heads/export-D57275456","pushedAt":"2024-05-13T13:05:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ot","name":"Giuseppe Ottaviano","path":"/ot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17024?s=80&v=4"},"commit":{"message":"[caffe2] Make all get_backtrace() implementations lazy (#125750)\n\nSummary:\n\n#125682 (D56586844) added support for lazy symbolization to `Error` and adopted it for internal use cases; this commit adopts it for `get_backtrace()` as well.\n\nTest Plan:\nSandcastle and GH CI.\n\nNOTE: This is a resubmit of D56881683, a spurious copypasted line in the Android implementation broke the build, but this was not surfaced by diff tests.\n\nReproed the breakage with\n```\n$ fbpython scripts/build_android_app/build_android_app.py --buck-config-files='@//fbandroid/mode/have_libgflags @//fbandroid/mode/static_linking @//xplat/langtech/mobile/android_opt_buck_config_with_et_boltnn' --build-target='fbsource//xplat/langtech/mobile:transcribe_binAndroid-android-arm64'\n```\nVerified that the fixed diff builds successfully.\n\nDifferential Revision: D57275456","shortMessageHtmlLink":"[caffe2] Make all get_backtrace() implementations lazy (pytorch#125750)"}},{"before":null,"after":"21ea68cc7b13865b93563d8f610978f8a47f72dc","ref":"refs/heads/export-D57128632","pushedAt":"2024-05-08T21:28:41.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ot","name":"Giuseppe Ottaviano","path":"/ot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17024?s=80&v=4"},"commit":{"message":"[caffe2] Lazily symbolize backtrace in c10::Error\n\nSummary:\nThe macros that build `c10::Error` compute the stack trace at the point of throwing, which is then returned as part of the `what()`. If `what()` is never called, which is the case for most exceptions (since logging is throttled), the cost of computing the stack trace was wasted.\n\nBy far, the most expensive part of computing the stack trace is its symbolization; just unwinding the stack and collecting the instruction addresses is comparatively cheap. We can thus defer the symbolization to first invocation of `what()`.\n\nTest Plan:\nAdded unit tests exercising the lazy nature of `what()`.\n\nRan an adfinder canary: https://www.internalfb.com/intern/ads/canary/460118801509424346\n\nWe can see that the cost of symbolization is obliterated (meaning that `what()` is virtually never called, as expected):\n {F1496627896}\n\nDifferential Revision: D57128632","shortMessageHtmlLink":"[caffe2] Lazily symbolize backtrace in c10::Error"}},{"before":"79fbe6d8bcceb56058470a8b6e534401a6ba7a12","after":"c8f7d65956960376bb42f9d90a05773022aad82e","ref":"refs/heads/export-D56881683","pushedAt":"2024-05-08T10:46:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ot","name":"Giuseppe Ottaviano","path":"/ot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17024?s=80&v=4"},"commit":{"message":"[caffe2] Make all get_backtrace() implementations lazy (#125750)\n\nSummary:\n\n#125682 (D56586844) added support for lazy symbolization to `Error` and adopted it for internal use cases; this commit adopts it for `get_backtrace()` as well.\n\nTest Plan: Sandcastle and GH CI.\n\nDifferential Revision: D56881683","shortMessageHtmlLink":"[caffe2] Make all get_backtrace() implementations lazy (pytorch#125750)"}},{"before":"ad373e6ce2d76ba0bfe29ce4a8a60d29d7591ba7","after":"79fbe6d8bcceb56058470a8b6e534401a6ba7a12","ref":"refs/heads/export-D56881683","pushedAt":"2024-05-08T10:44:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ot","name":"Giuseppe Ottaviano","path":"/ot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17024?s=80&v=4"},"commit":{"message":"[caffe2] Make all get_backtrace() implementations lazy (#125750)\n\nSummary:\n\n#125682 (D56586844) added support for lazy symbolization to `Error` and adopted it for internal use cases; this commit adopts it for `get_backtrace()` as well.\n\nTest Plan: Sandcastle and GH CI.\n\nDifferential Revision: D56881683","shortMessageHtmlLink":"[caffe2] Make all get_backtrace() implementations lazy (pytorch#125750)"}},{"before":null,"after":"ad373e6ce2d76ba0bfe29ce4a8a60d29d7591ba7","ref":"refs/heads/export-D56881683","pushedAt":"2024-05-08T10:03:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ot","name":"Giuseppe Ottaviano","path":"/ot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17024?s=80&v=4"},"commit":{"message":"[caffe2] Make all get_backtrace() implementations lazy\n\nSummary: #125682 (D56586844) added support for lazy symbolization to `Error` and adopted it for internal use cases; this commit adopts it for `get_backtrace()` as well.\n\nTest Plan: Sandcastle and GH CI.\n\nDifferential Revision: D56881683","shortMessageHtmlLink":"[caffe2] Make all get_backtrace() implementations lazy"}},{"before":"98fcaefafb0416a5d98212a5e41c929de9f59baa","after":"e6ca7e524b25f03e7fcbda436cdd2cb86a72fa53","ref":"refs/heads/export-D56586844","pushedAt":"2024-05-07T16:22:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ot","name":"Giuseppe Ottaviano","path":"/ot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17024?s=80&v=4"},"commit":{"message":"[caffe2] Lazily symbolize backtrace in c10::Error (#125682)\n\nSummary:\n\nThe macros that build `c10::Error` compute the stack trace at the point of throwing, which is then returned as part of the `what()`. If `what()` is never called, which is the case for most exceptions (since logging is throttled), the cost of computing the stack trace was wasted.\n\nBy far, the most expensive part of computing the stack trace is its symbolization; just unwinding the stack and collecting the instruction addresses is comparatively cheap. We can thus defer the symbolization to first invocation of `what()`.\n\nTest Plan:\nAdded unit tests exercising the lazy nature of `what()`.\n\nRan an adfinder canary: https://www.internalfb.com/intern/ads/canary/460118801509424346\n\nWe can see that the cost of symbolization is obliterated (meaning that `what()` is virtually never called, as expected):\n {F1496627896}\n\nReviewed By: ezyang\n\nDifferential Revision: D56586844","shortMessageHtmlLink":"[caffe2] Lazily symbolize backtrace in c10::Error (pytorch#125682)"}},{"before":"b9925641c6507a22aa43467d1eb90368742a121c","after":"98fcaefafb0416a5d98212a5e41c929de9f59baa","ref":"refs/heads/export-D56586844","pushedAt":"2024-05-07T14:27:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ot","name":"Giuseppe Ottaviano","path":"/ot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17024?s=80&v=4"},"commit":{"message":"[caffe2] Lazily symbolize backtrace in c10::Error (#125682)\n\nSummary:\n\nThe macros that build `c10::Error` compute the stack trace at the point of throwing, which is then returned as part of the `what()`. If `what()` is never called, which is the case for most exceptions (since logging is throttled), the cost of computing the stack trace was wasted.\n\nBy far, the most expensive part of computing the stack trace is its symbolization; just unwinding the stack and collecting the instruction addresses is comparatively cheap. We can thus defer the symbolization to first invocation of `what()`.\n\nTest Plan:\nAdded unit tests exercising the lazy nature of `what()`.\n\nRan an adfinder canary: https://www.internalfb.com/intern/ads/canary/460118801509424346\n\nWe can see that the cost of symbolization is obliterated (meaning that `what()` is virtually never called, as expected):\n {F1496627896}\n\nReviewed By: ezyang\n\nDifferential Revision: D56586844","shortMessageHtmlLink":"[caffe2] Lazily symbolize backtrace in c10::Error (pytorch#125682)"}},{"before":"c301a44d6ec49955556aca44cb28eaa8683c6b24","after":"b9925641c6507a22aa43467d1eb90368742a121c","ref":"refs/heads/export-D56586844","pushedAt":"2024-05-07T14:25:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ot","name":"Giuseppe Ottaviano","path":"/ot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17024?s=80&v=4"},"commit":{"message":"[caffe2] Lazily symbolize backtrace in c10::Error (#125682)\n\nSummary:\n\nThe macros that build `c10::Error` compute the stack trace at the point of throwing, which is then returned as part of the `what()`. If `what()` is never called, which is the case for most exceptions (since logging is throttled), the cost of computing the stack trace was wasted.\n\nBy far, the most expensive part of computing the stack trace is its symbolization; just unwinding the stack and collecting the instruction addresses is comparatively cheap. We can thus defer the symbolization to first invocation of `what()`.\n\nTest Plan:\nAdded unit tests exercising the lazy nature of `what()`.\n\nRan an adfinder canary: https://www.internalfb.com/intern/ads/canary/460118801509424346\n\nWe can see that the cost of symbolization is obliterated (meaning that `what()` is virtually never called, as expected):\n {F1496627896}\n\nReviewed By: ezyang\n\nDifferential Revision: D56586844","shortMessageHtmlLink":"[caffe2] Lazily symbolize backtrace in c10::Error (pytorch#125682)"}},{"before":null,"after":"c301a44d6ec49955556aca44cb28eaa8683c6b24","ref":"refs/heads/export-D56586844","pushedAt":"2024-05-07T13:54:53.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ot","name":"Giuseppe Ottaviano","path":"/ot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17024?s=80&v=4"},"commit":{"message":"[caffe2] Lazily symbolize backtrace in c10::Error\n\nSummary:\nThe macros that build `c10::Error` compute the stack trace at the point of throwing, which is then returned as part of the `what()`. If `what()` is never called, which is the case for most exceptions (since logging is throttled), the cost of computing the stack trace was wasted.\n\nBy far, the most expensive part of computing the stack trace is its symbolization; just unwinding the stack and collecting the instruction addresses is comparatively cheap. We can thus defer the symbolization to first invocation of `what()`.\n\nTest Plan:\nAdded unit tests exercising the lazy nature of `what()`.\n\nRan an adfinder canary: https://www.internalfb.com/intern/ads/canary/460118801509424346\n\nWe can see that the cost of symbolization is obliterated (meaning that `what()` is virtually never called, as expected):\n {F1496627896}\n\nReviewed By: ezyang\n\nDifferential Revision: D56586844","shortMessageHtmlLink":"[caffe2] Lazily symbolize backtrace in c10::Error"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAESGrfxQA","startCursor":null,"endCursor":null}},"title":"Activity ยท ot/pytorch"}