Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Edit text object dialog box #263

Open
mmnich opened this issue Sep 23, 2019 · 6 comments

Comments

@mmnich
Copy link

commented Sep 23, 2019

It would be great if the dialogue box "Edit text object" would allow selecting all text via the Ctrl+A keyboard shortcut, as well as closing the dialogue box using the Esc keyboard shortcut.

@otfried

This comment has been minimized.

Copy link
Owner

commented Sep 23, 2019

Are you on MacOS? Ctrl+A seems to work on Windows and Qt.

@mmnich

This comment has been minimized.

Copy link
Author

commented Sep 23, 2019

First, let me say that ipe is really awesome for making presentations. My suggestion was just meant to speed up the workflow by using the keyboard more effectively, instead of always switching to the mouse for selecting text.

I use Windows 8.1, and Ctrl+A does not work in either the "Edit text object" dialogue box or the "Edit page title and sections" dialogue box. The usual shortcuts Ctrl+C and Ctrl-V for copying and pasting work, though.

@otfried

This comment has been minimized.

Copy link
Owner

commented Sep 24, 2019

Which version of Ipe are you using?

I now checked on my Windows 10 laptop: When I open the Edit text dialog using Ctrl+E and then immediately press Ctrl+A, it selects the entire text. In the "Edit page title and sections" box, the text in the "page title" field is in fact already selected.

Did this really change so much between Windows version? Which keyboard layout are you using?

@mmnich

This comment has been minimized.

Copy link
Author

commented Sep 25, 2019

I am using Ipe 7.2.12.

I tried different keyboard layouts, like German and English, but it does not make a difference; Ctrl+A does not work in either case.

The Esc key does close the "Edit page title and sections" box, but does not close the "Edit text object" box.

@otfried

This comment has been minimized.

Copy link
Owner

commented Sep 25, 2019

I don't know what to do about the Ctrl+A key. It works in Windows 10, and I don't have Windows 8.1 to test with. In any case, the key is handled by Windows - Ipe just creates a text box.

That the Esc key does not close the dialog is deliberate, because too many people have lost their edits by accidentally pressing Esc.

If you don' t like this, open tools.lua and find the function MODEL:action_edit_text. Inside, change the line

  d:set("ignore-escape", true)

Use false instead of true or remove the line completely.

I will look into checking if we can allow Esc to close the dialog if the text has not been touched yet (would that be good enough for you?).

@mmnich

This comment has been minimized.

Copy link
Author

commented Sep 25, 2019

Great, many thanks for the proposed workaround of editing the tools.lua. That's good enough for me.

Your suggestion of allowing Esc to close the dialog if the text has not been touched yet sounds pretty sophisticated...indeed a good suggestion for the future.

Many thanks again.

@otfried otfried self-assigned this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.