Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bh/pull out rails crap #17

Merged
merged 5 commits into from

2 participants

Ben Hamill Ryan Michael
Ben Hamill

Should delete all the rails stuff from the code. Eventually, we'll probably want to make a muddle-rails gem.

Ben Hamill

@kerinin Do you think we should get rid of the example directory, too? A rails app is a lot of code to be shipping around in a gem for purely documentation reasons.

Ben Hamill

This, BTW, starts work on #15.

Ryan Michael
Owner

Good point about the example rails app. That could be it's own repo too. I like having it around for integration testing.

You might push a reference branch before this gets merged so we can find all the removed files easily.

+1

Ben Hamill

I think if we want full-app integration testing stuff, we should write a little Sinatra thing. Or just have a thing that requires ActionMailer or whatever. Since we're moving the emphasis away from Rails integration.

Ben Hamill

Also, I created the tag rail_code_still_in. Awesome typo, huh? Oh well.

Ben Hamill

@kerinin :ok: This is ready for review. Lemme know if you see anything weird.

Ben Hamill benhamill was assigned
Ryan Michael
Owner

+1

Ben Hamill benhamill merged commit dc0b1d7 into from
Ben Hamill benhamill referenced this pull request
Closed

Pull out Rails crap #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 11, 2012
  1. Ben Hamill
  2. Ben Hamill

    Don't require deleted files.

    benhamill authored
  3. Ben Hamill
Commits on May 18, 2012
  1. Ben Hamill

    rm Rails example.

    benhamill authored
  2. Ben Hamill

    Clean up the gemfile some.

    benhamill authored
Something went wrong with that request. Please try again.