Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Bh/pull out rails crap #17

Merged
merged 5 commits into from

2 participants

@benhamill

Should delete all the rails stuff from the code. Eventually, we'll probably want to make a muddle-rails gem.

@benhamill

@kerinin Do you think we should get rid of the example directory, too? A rails app is a lot of code to be shipping around in a gem for purely documentation reasons.

@benhamill

This, BTW, starts work on #15.

@kerinin
Owner

Good point about the example rails app. That could be it's own repo too. I like having it around for integration testing.

You might push a reference branch before this gets merged so we can find all the removed files easily.

+1

@benhamill

I think if we want full-app integration testing stuff, we should write a little Sinatra thing. Or just have a thing that requires ActionMailer or whatever. Since we're moving the emphasis away from Rails integration.

@benhamill

Also, I created the tag rail_code_still_in. Awesome typo, huh? Oh well.

@benhamill

@kerinin :ok: This is ready for review. Lemme know if you see anything weird.

@benhamill benhamill was assigned
@kerinin
Owner

+1

@benhamill benhamill merged commit dc0b1d7 into master
@benhamill benhamill referenced this pull request
Closed

Pull out Rails crap #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 11, 2012
  1. @benhamill
  2. @benhamill

    Don't require deleted files.

    benhamill authored
  3. @benhamill
Commits on May 18, 2012
  1. @benhamill

    rm Rails example.

    benhamill authored
  2. @benhamill

    Clean up the gemfile some.

    benhamill authored
Something went wrong with that request. Please try again.