Reorganize Specs #9

Merged
merged 18 commits into from Apr 11, 2012

Projects

None yet

2 participants

@benhamill
Contributor

This is still a work in progress, but I wanted to go ahead and get it up. I'm concentrating on two things, primarily:

  • Each it block should only make a single assertion.
  • Each file should only test what the unit under test actually does (no integration leaking in).

This is meant to address #6.

@benhamill
Contributor

Reviewer of the future: The diffs will probably be horrific to read. It might be easier to understand if you just looked at the final state of each spec file touched. Non-spec files touched should have reasonable diffs.

@benhamill
Contributor

@kerin This is good to review now. Let me know if you have any questions. Also if you want to talk about why I organized stuff the way I did, etc.

@kerinin
Member
kerinin commented Apr 7, 2012

This looks good. Would you mind updating the README to reflect the new configuration interface? I'm assuming the intention is that you'd set Muddle.config directly...

@benhamill
Contributor

Ack. Not my intention at all. I'd meant to change Muddle.configure to call Muddle::Configuration#configure. Muddle.config is meant as internal-to-the-gem access only (for reading and setting from the configuration object). Anyway, my intent was not to change the public API.

@kerinin
Member
kerinin commented Apr 10, 2012

sweet - +1

@benhamill benhamill merged commit 144b6f2 into master Apr 11, 2012
@benhamill
Contributor

Closes #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment