fix Items::getItemIdByName #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…::getItemByName return a valid item id when the name is empty make sure the Items::getItemIdByName behavior is exact: for each item id there will be only one name and the name will be the first found in items.xml changed NameMap from unordered_multimap to unordered_map since multiple keys is useless now and probably before
EPuncker
previously approved these changes
Aug 21, 2021
MillhioreBT
reviewed
Aug 24, 2021
ranisalt
previously requested changes
Aug 24, 2021
EPuncker
approved these changes
Sep 16, 2021
DSpeichert
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Prevent empty names from being added to nameToItems and prevent Items::getItemByName return a valid item id when the name is empty.
Make sure the Items::getItemIdByName behavior is exact: for each item id there will be only one name and the name will be the first found in items.xml.
Changed NameMap from unordered_multimap to unordered_map since multiple keys is useless now and probably before.