Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove oauth2 dependencies when using keyring #18

Closed
mturquette opened this issue Jan 26, 2015 · 3 comments
Closed

Remove oauth2 dependencies when using keyring #18

mturquette opened this issue Jan 26, 2015 · 3 comments
Assignees
Labels
bug

Comments

@mturquette
Copy link
Contributor

@mturquette mturquette commented Jan 26, 2015

When installing jic on Mac OS X I tried to skip the oauth2 bits since I use the keyring method for storing credentials. However jic unconditionally imports oauth2 modules, causing unnecessary dependencies.

@ototo ototo added the bug label Jan 30, 2015
@ototo ototo self-assigned this Jan 30, 2015
@ototo
Copy link
Owner

@ototo ototo commented Feb 6, 2015

85e066c fixes this on a fresh Mint install for me together with 3b68553 and 93a26c9.

@mturquette please confirm (I have no access to Mac OS X).

@ototo ototo modified the milestone: 15.06 Feb 6, 2015
@mturquette
Copy link
Contributor Author

@mturquette mturquette commented Apr 1, 2015

Confirmed!

@ototo
Copy link
Owner

@ototo ototo commented Apr 1, 2015

Thanks, Mike!

@ototo ototo closed this Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.