New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings DocFile should be a class #168

Open
fiurthorn opened this Issue Jun 21, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@fiurthorn

fiurthorn commented Jun 21, 2018

DocFile should be a class definition not an interface.

The interface breaks the typescript instanceof operator.

@FabianTe FabianTe changed the title from Type deinfinions as is to typings DocFile should be a class Jun 22, 2018

@FabianTe

This comment has been minimized.

Show comment
Hide comment
@FabianTe

FabianTe Jun 22, 2018

Collaborator

I edited your title. Please be a bit more precise with your titles and descriptions.

Collaborator

FabianTe commented Jun 22, 2018

I edited your title. Please be a bit more precise with your titles and descriptions.

@fiurthorn

This comment has been minimized.

Show comment
Hide comment
@fiurthorn

fiurthorn Jun 23, 2018

My so sorry. I described the as far als i think. DocFile ist only a sample.

So all typedefs should written as they are. Class as class, interface as interface.

Thats I have posted.

fiurthorn commented Jun 23, 2018

My so sorry. I described the as far als i think. DocFile ist only a sample.

So all typedefs should written as they are. Class as class, interface as interface.

Thats I have posted.

@tineheller

This comment has been minimized.

Show comment
Hide comment
@tineheller

tineheller Jun 26, 2018

Collaborator

We used interfaces for all portalScripting classes that have no constructor. We will publish another version of the portalScripting.d.ts where all interfaces will be abstract classes. Then the linter will show an error when the classes are instantiated but the instanceof operator should work.

Collaborator

tineheller commented Jun 26, 2018

We used interfaces for all portalScripting classes that have no constructor. We will publish another version of the portalScripting.d.ts where all interfaces will be abstract classes. Then the linter will show an error when the classes are instantiated but the instanceof operator should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment