New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort .po input file list #15

Merged
merged 1 commit into from Oct 15, 2018

Conversation

2 participants
@bmwiedemann
Contributor

bmwiedemann commented Oct 15, 2018

Sort .po input file list
so that nfoview.desktop and nfoview.appdata.xml builds in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.

I thought, I had tested that #13 fixed all of it, but there was still variation in nfoview.appdata.xml now that went away with this patch.

Sort .po input file list
so that nfoview.appdata.xml builds in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.
@otsaloma

This comment has been minimized.

Owner

otsaloma commented Oct 15, 2018

Thanks, merging.

@otsaloma otsaloma merged commit 48f295f into otsaloma:master Oct 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

otsaloma added a commit to otsaloma/gaupol that referenced this pull request Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment