Skip to content

lang: programdata_address field for Program account - #1125

Merged
armaniferrante merged 9 commits into
otter-sec:masterfrom
paul-schaaf:lang__program_programdata_address_option
Dec 13, 2021
Merged

lang: programdata_address field for Program account#1125
armaniferrante merged 9 commits into
otter-sec:masterfrom
paul-schaaf:lang__program_programdata_address_option

Conversation

@paul-schaaf

Copy link
Copy Markdown
Contributor

No description provided.

@paul-schaaf
paul-schaaf marked this pull request as ready for review December 11, 2021 00:31
Comment thread lang/src/program.rs Outdated
use std::ops::Deref;

// TODO: can we remove _account?

@paul-schaaf paul-schaaf Dec 11, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armaniferrante ^

is there any use to this field, considering that it's going to be empty struct all of the time

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the type is needed for the id() function. Though a better way of doing might be with PhantomData. Can consider that for a separate PR though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that sounds better to me. #1140

Comment thread lang/src/program.rs Outdated
Comment thread lang/src/program.rs Outdated
Comment thread lang/src/program.rs Outdated
Comment thread lang/src/program.rs Outdated
@armaniferrante
armaniferrante merged commit 911620e into otter-sec:master Dec 13, 2021
akash-osec pushed a commit to akash-osec/anchor that referenced this pull request Mar 25, 2026
@jamie-osec jamie-osec added this to the Pre-1.0 milestone Jun 24, 2026
akash-osec pushed a commit to akash-osec/anchor that referenced this pull request Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants