ts: add missing types for conditional exports

[dominictwlee]

This adds type declarations for the conditional workspace and Wallet exports, as detailed in response to the temporary solution in another issue.

I don't think there's a way to conditionally declare them since all this is statically analyzed at build time.

[1337mus]

@fanatid Would you have some time to review this? This PR will unblock a slew of projects for us. Thanks in advance.

[fanatid]

I do not know TS good enough for approval that everything ok but LGTM.

[zisko]

FYI: I patched this onto my local source and it did not fix the TS autocompletion issue.

[zisko]

I think the problem is more likely in ts/src/utils/common.ts and related to using process.env.BROWSER to determine if we are in a browser.

[fanatid]

I think the problem is more likely in ts/src/utils/common.ts and related to using process.env.BROWSER to determine if we are in a browser.

Yeah, I also think that problem in isBrowser variable. Not sure that we can use browser field in package.json because it's not related to the building process. Maybe in rollup config? idk

[dominictwlee]

FYI: I patched this onto my local source and it did not fix the TS autocompletion issue.

Odd, I did the same and it should work. How did you patch this?

All this should do is build the definitions into the compiled index.d.ts file in the dist folder. It shouldn't have any effect on the outputted js files.

Do you mean getting the workspace namespace to have auto-completion for it's members? I don't think that has ever worked..even in older versions before the isBrowser condition was implemented, because the type definition for workspace is a proxy object casted as any

const workspace = new Proxy({} as any, {})

If we wanted to include strict typing with hints for the actual workspace program names, we'd need to somehow alter/add those definitions at build time.

The Wallet definition should work as expected though.

[losman0s]

I just tried adding these two exports and it seems to work for me (I simply added them to the source in the anchor repo, built, and then applied the corresponding transpiled bit in a hello-world test project).

I don't think isBrowser has anything to do with this. Instead it seems to be the use of raw export.workspace that does not get picked up by the typing system like usual export statements do. To test that you can simply remove the if (!isBrowser) and observe that even then the types for the conditional modules are still missing.

[zisko]

Yep- I was wrong. I was building into the wrong workspace. It was 3am here :) sorry!