Skip to content

ts: remove event error log#1313

Merged
armaniferrante merged 2 commits into
otter-sec:masterfrom
xjcaa:remove-error-log-on-events
Jan 14, 2022
Merged

ts: remove event error log#1313
armaniferrante merged 2 commits into
otter-sec:masterfrom
xjcaa:remove-error-log-on-events

Conversation

@xjcaa

@xjcaa xjcaa commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

This log doesn't really serve any benefit as it just creates noise.

Any error log from your program will just log and return.

{
  signature: '451AeeyezdmobLtwUnLPZguR2qj2FzjfjVWEnbmiodT6yVaHLo3eGtTWAhrnSYDQhH91NFbMMrRRZtxDLZQgSvdq',
  err: { InstructionError: [ 0, [Object] ] },
  logs: [
    'Program BG3oRikW8d16YjUEmX3ZxHm9SiJzrGtMhsSR8aCw1Cd7invoke [1]',
    'Program log: Cancel order.',
    'Program BG3oRikW8d16YjUEmX3ZxHm9SiJzrGtMhsSR8aCw1Cd7invoke [2]',
    'Program zDEXqXEG7gAyxb1Kg9mK5fPnUdENCGKzWrM21RMdWRq consumed 2776 of 179069 compute units',
    'Program zDEXqXEG7gAyxb1Kg9mK5fPnUdENCGKzWrM21RMdWRq failed: custom program error: 0x3b',
    'Program BG3oRikW8d16YjUEmX3ZxHm9SiJzrGtMhsSR8aCw1Cd7consumed 23707 of 200000 compute units',
    'Program BG3oRikW8d16YjUEmX3ZxHm9SiJzrGtMhsSR8aCw1Cd7failed: custom program error: 0x3b'
  ]
}

All clients using some common SDK that listens to events for your program will see this noise and just creates confusion.

@armaniferrante armaniferrante merged commit f34287e into otter-sec:master Jan 14, 2022
losman0s pushed a commit to losman0s/anchor that referenced this pull request Feb 7, 2022
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants