Add support for anchor idl fetch to work outside anchor workspace

[NBNARADHYA]

Context

Closes #1453 (Refer to this issue for context)

Changes

1. anchor idl fetch can now be run outside an anchor workspace.
2. If it is run outside workspace, provider.cluster option has to be provided.

[NBNARADHYA]

@paul-schaaf I have made changes. Please suggest any changes if they are required.

Also had a question: How is anchor cli tested ? If I need to write tests for my change, how do I go about this?

Thanks

[paul-schaaf]

dont think we have to require the provider.cluster to be provided. if it's not given and we're outside a workspace, the cluster from the local solana config can be used

re:cli tests we..just test it manually. But we can start adding tests to the CI. Are you comfortable doing that or do you prefer us to do it? imo it's fine to just merge this without testing and then merge a ci change later but if you want to add tests to tests.yaml now, feel free!

[NBNARADHYA]

@paul-schaaf Thanks! On it!

If this works fine, I would prefer for this to be merged! I shall create a new PR with the tests if that's okay!

Thanks

[NBNARADHYA]

@paul-schaaf please suggest any changes!

[armaniferrante]

@armaniferrante

please don't needlessly tag. Someone will review when they have time.

[paul-schaaf]

looks like you found the cli-config solana crate but why did you copy that code into ours instead of importing the crate?

[NBNARADHYA]

looks like you found the cli-config solana crate but why did you copy that code into ours instead of importing the crate?

@paul-schaaf makes more sense! I have made changes

[paul-schaaf]

pls also add a line to the feature section in the changelog for the unreleased release

[NBNARADHYA]

@paul-schaaf hope this is done!

[paul-schaaf]

pls update your changelog and if you do another PR, adjust your PR to allow edits from maintainers so I can just do that and merge instead

[NBNARADHYA]

@paul-schaaf I have already added updated the changelog. I am not able to see “allow edits from maintainers” option on this pull request.

[paul-schaaf]

u need to update it again. your change is in the wrong place cause we created a release

[NBNARADHYA]

@paul-schaaf done !

[paul-schaaf]

pls sign your commits and force push again

[NBNARADHYA]

@paul-schaaf done!

[paul-schaaf]

looks like your commits are still not signed

[NBNARADHYA]

@paul-schaaf I can see that they are on github

[fanatid]

@NBNARADHYA they are not, if commits are signed then you will see Verified label

[NBNARADHYA]

@fanatid @paul-schaaf I used this command while commiting: git commit -m "message" -S. I believe this will sign commits. I am not sure what went wrong. BTW this is the output for git log --show-signature.

[NBNARADHYA]

@fanatid Ok. Now I figured out I have to use GPG keys to sign. But i tried to edit those commits by rebasing but it edits all other commits and signs them all for some reason

[paul-schaaf]

we've turned off the signing requirement. Just make sure you have no more conflicts and then Ill merge

[NBNARADHYA]

@paul-schaaf Great! Thanks. Just resolved the conflicts

[paul-schaaf]

thank you for the contribution!

[NBNARADHYA]

@paul-schaaf Thank you!