lang: add support for logging expected and actual values and pubkeys - #1572
Merged
Conversation
paul-schaaf
marked this pull request as ready for review
March 8, 2022 19:50
paul-schaaf
marked this pull request as draft
March 8, 2022 19:55
armaniferrante
approved these changes
Mar 15, 2022
Contributor
|
merge conflicts |
Otter-0x4ka5h
pushed a commit
to Otter-0x4ka5h/anchor
that referenced
this pull request
Mar 25, 2026
Otter-0x4ka5h
pushed a commit
to Otter-0x4ka5h/anchor
that referenced
this pull request
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1586
closes #1464
Future PRs should add more
requirestatements that abstract away the implementation detailsmacros added in this PR:
require_eqmacro that is meant to be used with non-pubkey values and results in the following output:require_keys_eqmacro that is meant to be used with pubkey values and results in the following output:These macros can be used like this
require_eq(value1, value2)in which case they return an error defined by us or with a custom errorrequire_eq(value1,value2,MyError:SomeError). Therequiremacro has also been changed to work the same wayLog statement are intentionally
LeftandRightand notExpectedandActualbecause futurerequiremacros would not fit those descriptions (e.g.require_gt)