Skip to content

spl: re-export the spl_token::AuthorityType enum#1665

Merged
paul-schaaf merged 4 commits into
otter-sec:masterfrom
callensm:spl/authority-type
Mar 23, 2022
Merged

spl: re-export the spl_token::AuthorityType enum#1665
paul-schaaf merged 4 commits into
otter-sec:masterfrom
callensm:spl/authority-type

Conversation

@callensm

Copy link
Copy Markdown
Contributor

No description provided.

@fanatid

fanatid commented Mar 22, 2022

Copy link
Copy Markdown
Contributor

Maybe re-export whole spl_token crate?

@callensm

Copy link
Copy Markdown
Contributor Author

Most of what of core functionality of spl_token is covered by the wrapping functions/structs in anchor_spl. The only thing (personally) that I've ever been annoyed by is constantly having to depend on spl_token as well solely for the AuthorityType enum.

If there are other things in spl_token that need re-exporting as well, would probably be best to do them individually as to not expose the core functions that anchor_spl wraps.

@paul-schaaf

Copy link
Copy Markdown
Contributor

If there are other things in spl_token that need re-exporting as well, would probably be best to do them individually as to not expose the core functions that anchor_spl wraps.

is this a problem though? If you're using anchor_spl, you're not gonna use those functions and this way we don't have to update the re-exports

@callensm

Copy link
Copy Markdown
Contributor Author

no its not a problem, if that's what you want to do I can update the PR to re-export all of spl_token.

@paul-schaaf

Copy link
Copy Markdown
Contributor

ok yea re-export it all then

@paul-schaaf paul-schaaf merged commit 4e4ca55 into otter-sec:master Mar 23, 2022
@paul-schaaf

Copy link
Copy Markdown
Contributor

thanks!

@callensm callensm deleted the spl/authority-type branch March 23, 2022 14:48
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants