Skip to content

Add send w/ spinner and options to rust client#1926

Merged
armaniferrante merged 3 commits into
otter-sec:masterfrom
stegaBOB:stegaBOB/feat/client-send-options
May 29, 2022
Merged

Add send w/ spinner and options to rust client#1926
armaniferrante merged 3 commits into
otter-sec:masterfrom
stegaBOB:stegaBOB/feat/client-send-options

Conversation

@stegaBOB
Copy link
Copy Markdown
Contributor

Currently, it is very clunky to take a builder and convert that to a send w/ options. Sending with options is useful in order to be able to customize the transaction config in order to turn off preflight checks (which make it easier to debug errors).

This change adds a single function to the RequestBuilder struct, send_with_spinner_and_config (name is placeholder at the moment. Feel free to change it if its too long). Tests passing and tested it locally and everything still works.

Comment thread client/src/lib.rs Outdated
.map_err(Into::into)
}

pub fn send_with_spinner_and_config(self, config: RpcSendTransactionConfig) -> Result<Signature, ClientError> {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@armaniferrante armaniferrante merged commit b993854 into otter-sec:master May 29, 2022
@armaniferrante
Copy link
Copy Markdown
Contributor

Thank you!

@stegaBOB stegaBOB deleted the stegaBOB/feat/client-send-options branch October 12, 2022 16:52
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants