Feat: Update AccountsClose to be safe to call manually - #2209
Conversation
(cherry picked from commit d6e43c1)
|
@stegaBOB is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
|
@armaniferrante The core part of this change is switching |
|
This may actually cause issues if assign is called manually. I'm not sure if the serialization would normally fail in that case. I'm going to do an additional test here first and I'll report back. |
|
@Henry-E @armaniferrante I updated the AccountsExit logic and it should prevent any false positives from being triggered on accounts with reassigned owners. |
|
This PR should be ready to merge in. The failed workflow runs fails were GitHub network errors. |
* fix other lints to make the test pass (cherry picked from commit d6e43c1) * update close to make it safe to call manually * fix test script * re-add safety warnings for deprecated account types * update close checking logic * readd logic for deprecated methods * add additional checks to account_loader in exit
* fix other lints to make the test pass (cherry picked from commit d6e43c1) * update close to make it safe to call manually * fix test script * re-add safety warnings for deprecated account types * update close checking logic * readd logic for deprecated methods * add additional checks to account_loader in exit
* fix other lints to make the test pass (cherry picked from commit d6e43c1) * update close to make it safe to call manually * fix test script * re-add safety warnings for deprecated account types * update close checking logic * readd logic for deprecated methods * add additional checks to account_loader in exit
4 participants
Updates the
AccountsClosetrait to ensure its safe to call manually.Also removed the warnings and added more tests to make sure its safe. Also added
AccountsCloseto the prelude.