Skip to content

Allow passing env vars to verifiable build container - #2325

Merged
Henry-E merged 7 commits into
otter-sec:masterfrom
soapyp:pan/docker-env
Dec 21, 2022
Merged

Allow passing env vars to verifiable build container#2325
Henry-E merged 7 commits into
otter-sec:masterfrom
soapyp:pan/docker-env

Conversation

@soapyp

@soapyp soapyp commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Dec 19, 2022

Copy link
Copy Markdown

@riordanp is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@Henry-E

Henry-E commented Dec 20, 2022

Copy link
Copy Markdown

Is there much else you still want to add to this PR? It looks pretty reasonable to add.

Also

  • don't forget to run cargo fmt
  • please add a note to the changelog as well

@soapyp

soapyp commented Dec 20, 2022

Copy link
Copy Markdown
Contributor Author

Should be ready now

@soapyp
soapyp marked this pull request as ready for review December 20, 2022 17:51
@Henry-E

Henry-E commented Dec 20, 2022

Copy link
Copy Markdown

Looks like a clippy lint still needs to be satisfied or excepted somehow. https://github.com/coral-xyz/anchor/actions/runs/3742902170/jobs/6354794762

Also it's weird the changelog isn't registering as a merge conflict because it looks like you don't have version of the changelog in which 0.26.0 has already been released (we launched it last week). So your change should be the first new feature in the unreleased version. Sorry to be anal about the changelog stuff but it's just hard for me to rebase your repo / update the changelog manually when it's out of sync.

@Henry-E
Henry-E merged commit 8856aee into otter-sec:master Dec 21, 2022
dovahcrow pushed a commit to dovahcrow/anchor that referenced this pull request Jan 13, 2023
akash-osec pushed a commit to akash-osec/anchor that referenced this pull request Mar 25, 2026
@jamie-osec jamie-osec added this to the Pre-1.0 milestone Jun 24, 2026
akash-osec pushed a commit to akash-osec/anchor that referenced this pull request Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants