Skip to content

Andrew Otto ottomata

ottomata commented on pull request wikimedia/puppet-jmxtrans#3
Andrew Otto

Great, merged. Thank you! On Jun 25, 2014, at 1:39 PM, Tadas Vilkeliskis notifications@github.com wrote: Closed #3. — Reply to this email directly…

ottomata commented on pull request wikimedia/puppet-jmxtrans#3
Andrew Otto

Awesome! Thanks @tadasv! So, this repository is actually just a replicated mirror of the main repository hosted in gerrit:https://gerrit.wikimedia.…

Andrew Otto
ottomata commented on pull request linkedin/camus#66
Andrew Otto

Yeah, I think you are right. Doing this implicitly could cause some unexpected behavior. The latest commit here changes it so that you must explici…

Andrew Otto
  • Andrew Otto dc97b40
    Explicitly configuring unix timestamp units in JSONStringMessageDecoder
Andrew Otto wikimedia is now a3da2f5
Andrew Otto
ottomata commented on issue linkedin/camus#67
Andrew Otto

Does that apply only if there are no offset files? Or every time the job is run with that property set, even if there are offset files? On May 13, …

Andrew Otto
Add config for consuming starting at end of log if no offset files exist.
ottomata commented on pull request linkedin/camus#66
Andrew Otto

Hey yalls, this patch should be merged so that the previous one actually works properly...just sayin!

ottomata commented on pull request linkedin/camus#65
Andrew Otto

There we go: #66

ottomata opened pull request linkedin/camus#66
Andrew Otto
Automatically converting to millisecond timestamp if the value is large ...
1 commit with 8 additions and 0 deletions
Andrew Otto
  • Andrew Otto fe2c57a
    Automatically converting to millisecond timestamp if the value is lar…
  • Gaurav Gupta e443729
    Merge pull request #65 from wikimedia/wikimedia
  • 2 more commits »
ottomata commented on pull request linkedin/camus#65
Andrew Otto

Oo thanks! I just found a bug with this, I thought I was having trouble elsewhere (and didn't think this would be merged so fast!). Camus expects t…

ottomata opened pull request linkedin/camus#65
Andrew Otto
Adding support for integer unix timestamp in JsonStringMessageDecoder
1 commit with 23 additions and 7 deletions
Andrew Otto
  • Andrew Otto d8bd69b
    Adding support for integer unix timestamp in JsonStringMessageDecoder
ottomata commented on pull request wikimedia/varnishkafka#3
Andrew Otto

Cool! Chris, varnishkafka is actually hosted here: https://gerrit.wikimedia.org/r/#/admin/projects/operations/software/varnish/varnishkafka This re…

Andrew Otto

This is sort of what I'm doing then in my operations/puppet commit, ja? https://gerrit.wikimedia.org/r/#/c/126846/

Andrew Otto

Ok, I updated the change in WMF operations/puppet. It now installs post-checkout and post-commit hooks to run this command. It works! But perhaps i…

Andrew Otto

Should this be done in a hook? Either on the parent repo with a git submodule foreach command, or in each submodule gitdir's hook directory, e.g. .…

Andrew Otto

Ah no, sorry, sync_all is a minion command. This needs to be run on the deploy server. Hm.

Andrew Otto

Yeah was thinking that too. I had only tested with checking out a previous submodule revision and deploying. You are right, when a new SHA comes in…

Andrew Otto

Can we just run: git submodule foreach --recursive 'cd $(sed "s/gitdir: //" .git) && git update-server-info' whenever the deployment server inits i…

Andrew Otto

Ah, I see that this command is intended to read /.git, which contains a path to the module inside of the parent .git directory. Ignore the part abo…

Andrew Otto
.git/modules/<modulename>/info/refs not always present
ottomata closed pull request jedbrown/git-fat#27
Andrew Otto
README - .gitattributes should use -text, not -crlf
ottomata commented on pull request jedbrown/git-fat#27
Andrew Otto

Ok sounds good, let's abandon this then. Thanks!

ottomata commented on pull request jedbrown/git-fat#27
Andrew Otto

@somechris could you comment on this? Whatcha think?

Something went wrong with that request. Please try again.