Permalink
Commits on Dec 30, 2016
  1. AO3-4746 Remove vestigal external_authors pages (#2687)

    * Add rspec tests for the comments controller
    
    * Add some defensive code
    
    * Deinfect master
    
    * Clean up
    
    * Get rid of infected file
    
    * Inital clean up
    zz9pzza committed on GitHub Dec 30, 2016
  2. Remove vestigal tag_nominations_controller (#2688)

    zz9pzza committed on GitHub Dec 30, 2016
  3. AO3-4804 - Use AO3 url instead of now deleted LJ (#2691)

    zz9pzza committed with ariana-paris Dec 30, 2016
  4. AO3-4802 Increase coverage of opendoors/external_authors_controller.rb (

    #2689)
    
    * Add more coverage
    
    * Forgot a file
    
    * Trying to defeat multiple browsers
    
    * Revert "Trying to defeat multiple browsers"
    
    This reverts commit 5b25a6e.
    
    * Follow review
    zz9pzza committed with sarken Dec 30, 2016
Commits on Dec 29, 2016
  1. AO3-4763 – PseudsController Strong Params (#2671)

    * AO3-4763 – PseudsController Strong Params
    
    * Added missing :icon param and removed redundant :icon_updated_at
    
    * Added missing :delete_icon param
    
    * Try and reduce the number of params permitted
    kamilogorek committed with zz9pzza Dec 29, 2016
  2. AO3-4764 – CollectionsController Strong Params (#2672)

    * AO3-4764 – CollectionsController Strong Params
    
    * Adds missing t and g from too_short and too_long validations
    
    * Try and reduce the number of params permitted
    
    * Updates from sarken, with bonus test
    
    * Fix indentation
    
    * Fix English
    
    * Parameterise collection name
    
    * Add some real tests around icons
    
    * it does screams bloody murder about an ambiguous match due to a model-related pickle step
    kamilogorek committed with zz9pzza Dec 29, 2016
  3. AO3-4759 – FeedbacksController Strong Params (#2670)

    * AO3-4759 – FeedbacksController Strong Params
    
    * Try and reduce the number of params permitted
    kamilogorek committed with zz9pzza Dec 29, 2016
Commits on Dec 26, 2016
  1. AO3-4795 filtering by fandom in dashboard is broken (#2683)

    * First the broken test
    
    * Looks like there is a strange interaction between dup and strong params
    
    * Follow review
    zz9pzza committed with sarken Dec 26, 2016
Commits on Dec 24, 2016
  1. AO3-4772 Extend tests for tag_set_nominations_controller.rb (#2677)

    * AO3-4772 testing first change; when you nominate tagset you should be taken to edit tagset nomation path
    
    * changes
    
    * AO3-4772 this definitely isn't gonna work the first time
    
    * AO3-4772 please work....
    
    * nothing works :(
    
    * AO3-4772 travis can't find clear nominations button
    
    * AO3-4772 tweaking
    
    * ????
    
    * AO3-4772 trying to.... get it to work.....
    
    * AO3-4772 praying
    
    * this should work?
    
    * come on come on lucky 7 ~shakes dice~
    
    * AO3-4772 minifying scenario for too many nominations to review at once
    
    * AO3-4772 changes to step definitions
    
    * syntax error
    
    * hhhhhh
    
    * trying to figure out... how to get this syntax right sorry
    
    * syntax
    
    * work
    
    * IT'S GONNA WORK
    
    * d
    
    * please work?
    
    * this time it's gotta work...
    
    * AO3-4772 final edits... i'm literally just changing changing keywords in steps to try and get it to work sorry these commit messages aren't very meaningful
    
    * and again
    
    * jflgkyjt
    
    * sigh
    
    * llll
    
    * testing stuff
    
    * l
    
    * h
    
    * keep discovering more mistakes
    
    * another mistake
    
    * ???
    
    * ?
    
    * ?????????????????????
    
    * ?????
    
    * ??
    
    * closer??
    
    * added step definitions...
    
    * AO3-4772 thank god it works
    
    * AO3-4772 hound requested changes
    
    * AO3-4772 -
    
    * shadowed variable
    pixelred committed with zz9pzza Dec 24, 2016
  2. AO3-4722 WorksController 1 - import errors and search param cleansing (

    …#2678)
    
    * AO3-4722 - Isolate import errors and test them
    
    * AO3-4722 - Isolate the archivists in API specs from the users in WorksController spec
    
    * AO3-4722 - Isolate import errors and test them
    
    * AO3-4722 - Isolate the archivists in API specs from the users in WorksController spec
    
    * AO3-4722 - Test #clean_work_search_params before_filter
    
    * AO3-4722 - Cover sorting and categories in work search
    
    * AO3-4722 - Finish off import errors coverage and simplify API tests
    
    * AO3-4722 - Make changes to WorksController minimal and move create_archivist method
    
    * AO3-4722 - Better isolate the archivist and non-archivist scenarios
    
    * AO3-4722 - Guard against nils and shared state in StoryParser to resolve conflicts with WorksController spec
    
    * AO3-4722 - Formatting fixes
    
    * AO3-4722 - Revert WorksController to ensure no change in functionality
    ariana-paris committed with zz9pzza Dec 24, 2016
Commits on Dec 22, 2016
  1. AO3-4755 – AdminBannersController Strong Params (#2667)

    kamilogorek committed with zz9pzza Dec 22, 2016
  2. AO3-4757 – Remove redundant fallback for new user preferences (#2668)

    kamilogorek committed with zz9pzza Dec 22, 2016
  3. AO3-4758 – AdminPostsController Strong Params (#2669)

    kamilogorek committed with zz9pzza Dec 22, 2016
Commits on Dec 21, 2016
  1. AO3-4776 - Reset coverage on a failure (#2675)

    zz9pzza committed with ariana-paris Dec 21, 2016
  2. Specs for the external works controller (#2657)

    sarken committed with zz9pzza Dec 21, 2016
  3. AO3-4707 Add some specs for related works (#2658)

    * AO3-4707 Add some specs for related works index
    
    * AO3-4707 More related work specs
    
    * AO3-4707 Mark test pending until AO3-2151 fixed
    
    * AO3-4707 Woof woof
    
    * AO3-4707 Use the less good version rather than marking it pending
    
    * AO3-4707 Refactoring a bit
    sarken committed with zz9pzza Dec 21, 2016
  4. AO3-4773 Extend tests for known_issues_controller (#2676)

    * AO3-4773 add steps & test for deleting known issues
    
    * AO3-4773 adding lines for show button and kicking travis
    
    * AO3-4773 fixing indentation
    
    * AO3-4773 me vs travis
    
    * AO3-4773 delete unnecessary parentheses
    
    * typo
    pixelred committed with zz9pzza Dec 21, 2016
  5. AO3-4756 – LanguagesController Strong Params (#2666)

    kamilogorek committed with zz9pzza Dec 21, 2016
  6. AO3-4753 – AdminSettingController Strong Params (#2665)

    * AO3-4753 – AdminSettingController Strong Params
    
    * Removed reduntant :default_skin_id, :stats_updated_at params
    kamilogorek committed with zz9pzza Dec 21, 2016
  7. AO3-4752 – AbuseReportsController Strong Params (#2664)

    kamilogorek committed with zz9pzza Dec 21, 2016
Commits on Dec 20, 2016
  1. AO3-4777 Finish prompt meme model test (#2673)

    sarken committed with zz9pzza Dec 20, 2016
  2. AO3-4785 fix test where user's profile wasn't being destroyed properly (

    katieby committed with sarken Dec 20, 2016
  3. AO3-4768 Extended tests for controllers/series_controller.rb (#2663)

    * test for page title in pseud's series page
    
    * AO3-4768 when going to a pseud's series page, look for correct title
    
    * AO3-4768 test for creating co-authored work and deleting self from co-authors
    
    * AO3-4768 please fill in the co-author field travis......
    
    * AO3-4768 i'm hungry...
    
    * AO3-4768 travis can't find the remove me as author button
    
    * AO3-4768 editing final step
    
    * AO3-4768 last edit...
    
    * AO3-4768 changes by sarken (looks good to me)
    
    * AO3-4768 minimise series_order.feature
    
    * AO3-4768 whoops...
    
    * AO3-4768 minimise Scenario: edit a locked work to add it to a series
    
    * go away >: (
    
    * AO3-4768 minimise Scenario: Post a series with a restricted work, then add a draft, then make the draft public and post it
    
    * deletedeletedelete
    
    * AO3-4768 increased minimalism :D
    
    * AO3-4768 make test work before minimising any further
    
    * AO3-4768 add scenario for previewing before posting, use post without preview in other scenarios
    
    * AO3-4768 nerp
    
    * AO3-4768 update regexp
    
    * AO3-4768 whoops
    
    * something broke. trying again
    
    * AO3-4768 regex in work_steps.rb should be updated and working now
    pixelred committed with zz9pzza Dec 20, 2016
Commits on Dec 19, 2016
  1. AO3-4761 Tests for admin/api_controller (#2662)

    * Tests for admin/api_controller
    
    * Style changes for THE HOUND
    annelu committed with ariana-paris Dec 19, 2016
Commits on Dec 18, 2016
  1. AO3-4770 Remove TODO comments in yuletide feature (#2661)

    * Clarifying TODO comment in test
    
    * Take out TODO since it's already done
    
    * Taking out TODO comment as capitalisation is correct
    
    It matches what we have on the homepage.
    cesy committed with sarken Dec 18, 2016
Commits on Dec 17, 2016
  1. AO3-4705 Test for downloading unrevealed works (#2605)

    * AO3-4705 Test for downloading unrevealed works
    
    * AO3-4705 Tidy up the other download tests
    
    * AO3-4705 Remove redundant guest downloading test because there's one in admin_settings
    
    * AO3-4705 Change the regexp
    
    * AO3-4705 Remove @wip and fix ambiguous step definition
    
    * AO3-4705 Not so much with the (.*) placeholder... trying again
    
    * AO3-4705 Put the wip back
    sarken committed with zz9pzza Dec 17, 2016
  2. Testing the TODO that says it fails on Travis (#2659)

    cesy committed with sarken Dec 17, 2016
Commits on Dec 16, 2016
  1. AO3-4762 added test for controllers/invite_requests_controller (admin…

    … deleting someone from queue) (#2654)
    
    * AO3-4762 added test for controllers/invite_requests_controller where admin deletes someone from invite queue
    
    * AO3-4762 style & extra confirmation changes
    
    * AO3-4762 fix indentation
    
    * AO3-4762 add space between scenario and rest of steps
    pixelred committed with sarken Dec 16, 2016
Commits on Dec 15, 2016
  1. AO3-4737 Start using strong parameters (#2399)

    * find errors in  app/models/wrangling_guideline.rb
    
    * Admins can do anything
    
    * Not ready for filter_tagging yet
    
    * Follow reviewers comments
    
    * Listen to the hound
    
    * The gem seemed to get lost
    
    * Raise an exception if an unpermitted attribute is used
    
    * Fix hounding issues
    
    * Fix hounding issues
    
    * Add more strong_params
    
    * Use strong params
    
    * Listen to the hound
    
    * Sarken was right find does not need it
    
    * sarken is right this is not a mass assignment
    zz9pzza committed on GitHub Dec 15, 2016
Commits on Dec 14, 2016
  1. AO3-4724 Make rspec tests more independant (#2617)

    * Reset all the things
    
    * Isolate each test
    
    * try and run all the tests
    
    * Reset each test that failed
    
    * Fix test
    
    * Don't reset the db to check all failures
    
    * Add works tests back in
    
    * resets around cache_master
    
    * add tests to works
    
    * Minor style fixes
    
    * Re enable story parser tests
    
    * Try cleaning the db earlier
    
    * Restore story parser
    
    * Try two travis jobs to isolate work
    
    * Follow Ariana's suggestion
    
    * Update .travis.yml
    
    Remove duplicate test
    
    * Hopefully final clean up
    
    * Hopefully final clean up(again)
    zz9pzza committed with sarken Dec 14, 2016
  2. AO3-4730 - Add Cucumber output formatter (#2647)

    ariana-paris committed with sarken Dec 14, 2016
Commits on Dec 10, 2016
  1. ao3-app10 is unhappy (#2650)

    zz9pzza committed on GitHub Dec 10, 2016
Commits on Nov 29, 2016
  1. AO3-4739 Extend tests for admin skin controller (#2634)

    * Test adding skins to a chooser and approving them
    
    * Add coverage for not in chooser, and not cached
    
    * fix typo
    
    * Be more exact about the ticky
    
    * Update to reflect review
    
    * Follow review
    
    * Change senario name
    zz9pzza committed with sarken Nov 29, 2016
Commits on Nov 28, 2016
  1. AO3-4719 Refactor work search tests (#2615)

    * Re-enable tests
    
    * Refactor in to a number of smaller tests
    
    * Try and reset the state of stubs
    
    * Move forward on spec
    
    * Put old spec back
    
    * Tidy up
    zz9pzza committed with sarken Nov 28, 2016
  2. AO3-4725 Simple rspec test for profile controller (#2621)

    * Simple rspec test for profile controller
    
    * listen to the hound
    zz9pzza committed with sarken Nov 28, 2016