Permalink
Commits on Jan 29, 2017
  1. AO3-4846 Update cache key for work meta so new series links will show (

    sarken committed with zz9pzza Jan 29, 2017
Commits on Jan 25, 2017
  1. AO3-4839 Add dividers to series navigation on works (#2721)

    * AO3-4839 Line length and spacing in series_data_for_work
    
    * AO3-4839 Circle dividers in work series info
    
    * AO3-4839 Skin wizard should use foreground color for series divider
    
    * AO3-4839 Code style fixes
    
    * AO3-4839 More code style fixes and cincluding one the automated syntax checking thing was wrong about
    
    * AO3-4839 More code style fixes because I honestly don't know what our style checker is trying to tell me
    
    * AO3-4839 Frakking typo in the frakking code comment (but at least it's not a code style change)
    
    * AO3-4839 Oh look another damn mistake in my code comments
    
    * A03-4839 Change class name on main part of series info
    
    * A03-4839 It helps to update the class name in the comments too
    
    * AO3-4839 Update the selector for the divider after the series information because it is 4:30 and you should never code at this hour ever
    sarken committed with zz9pzza Jan 25, 2017
Commits on Jan 24, 2017
  1. AO3-4837 Add test for collection_profile_controller (#2717)

    * Add test for collection_profile_controller
    
    * Listen to sarken
    zz9pzza committed with sarken Jan 24, 2017
Commits on Jan 21, 2017
  1. AO3-4303 fix BOT, english and missing subject (#2714)

    * coauthor_notification
    
    * Update
    
    * Minimal test
    
    * Change subject
    
    * Fix syntax error
    
    * Migrate to new system
    
    * creator not author
    
    * Fix the other tests
    
    * Fix Bot ( hopefully)
    
    * Listen to sarken sorry rushed today
    zz9pzza committed with sarken Jan 21, 2017
Commits on Jan 19, 2017
  1. AO3-4109 Make next/previous work links in series more accessible (#2640)

    * making next/previous work links in series more accessible
    
    * changed old style links in series steps
    
    * travis please : (
    
    * changes requested by ariana
    
    * Update series.feature
    
    * Update series_lock.feature
    
    * Update series.feature
    pixelred committed with ariana-paris Jan 19, 2017
  2. AO3-4303 i18n coauthor_notification (#2119)

    * coauthor_notification
    
    * Update
    
    * Minimal test
    
    * Change subject
    
    * Fix syntax error
    
    * Migrate to new system
    
    * creator not author
    
    * Fix the other tests
    zz9pzza committed with sarken Jan 19, 2017
  3. AO3-4811 Allow error to be reached in prompt controller, removing err…

    …or 500 (#2698)
    
    * Remove unused methods
    
    * Rspec test for prompts_controller
    
    * Reset tidy up
    
    * Reset tidy up
    
    * Fix chance of getting to error
    
    * Fix spacing
    zz9pzza committed with sarken Jan 19, 2017
Commits on Jan 18, 2017
  1. AO3-3991 Skins navigation improvements (#2401)

    * AO3-3991 Start shuffling skin buttons
    
    * AO3-3991 Add my skins links to new and edit pages
    
    * AO3-3991 Fix display issues with primary module
    
    * AO3-3991 Adjust bottom margin on primary module actions
    
    * AO3-3991 Return navigation to bottom of skin show page
    
    * AO3-3991 Make skin help text less fic-c-centric
    
    * AO3-3991 Update syntax
    
    * AO3-3991 Sytax update on skin index
    
    * AO3-3991 Fix revert skin problem when logged in as admin
    
    * AO3-3991 Make the site skin description less visual-centric
    
    * AO3-3991 Update wording in skin basics help file
    
    * AO3-3991 Add tests for actions on skin show and edit pages
    
    * AO3-3991 => to : for skin steps
    
    * AO3-3991 => to : in generic steps
    
    * AO3-3991 Fix typo in skin steps
    
    * AO3-3991 Add missing end
    
    * AO3-3991 Add back in a step that got clobbered in the merge
    
    * AO3-3991 Add _ to unusued article arguments
    
    * AO3-3991 Don't do unnecessary strip interpolation and do less escaping quotes
    
    * AO3-3991 Remove duplicate navigation from new skins page
    
    * AO3-3991 Put the test for an admin changing the default skin into the admin_skins test file
    sarken committed with zz9pzza Jan 18, 2017
  2. Remove windows gems (#2655)

    zz9pzza committed with sarken Jan 18, 2017
  3. AO3-4302 i18n change the email address (#2117)

    * change the email address
    
    * Try the new locale keys
    
    * Remove extra spaces
    
    * translation missing not translation_missing
    zz9pzza committed with sarken Jan 18, 2017
Commits on Jan 16, 2017
  1. AO3-4357 Allow downloads to be disabled (#2713)

    * Allow downloads to be disabled
    
    * Shift the date of the migration
    
    * lowercase Downlaods
    
    * Add the new setting to the strong parameters
    
    * AO3-4357 Add test to make sure the download button goes away when downloads are off
    zz9pzza committed with bingeling Jan 16, 2017
  2. AO3-4823 expand tests on tag controller (#2707)

    * Adding more tests
    
    * More testing
    
    * Debugging entered
    
    * Listen to the hound
    zz9pzza committed with sarken Jan 16, 2017
  3. AO3-4301 I18n the password reset email (#2116)

    * Reset password email
    
    * .html_safe is needed
    
    * Tidy subject up
    
    * Fix typo
    
    * Short locale keys and a bit of a test
    zz9pzza committed with sarken Jan 16, 2017
Commits on Jan 15, 2017
  1. Revert "AO3-4357 Allow downloads to be disabled" (#2712)

    zz9pzza committed on GitHub Jan 15, 2017
  2. AO3-4745 Remove compare and merge functions from external works (#2646)

    * Add rspec tests for the comments controller
    
    * Add some defensive code
    
    * Deinfect master
    
    * Clean up
    
    * Remove merge and compare code
    
    * Get rid of infected file
    zz9pzza committed on GitHub Jan 15, 2017
  3. AO3-4738 Allow an Admin to change the default skin (#2632)

    * Clean changes
    
    * Fix missing file
    zz9pzza committed on GitHub Jan 15, 2017
  4. AO3-4357 Allow downloads to be disabled (#2192)

    * Allow downloads to be disabled
    
    * Shift the date of the migration
    
    * lowercase Downlaods
    zz9pzza committed on GitHub Jan 15, 2017
  5. AO3-4297: i18n the invite confirmation email (#2114)

    * i18n the invite email
    
    * Didn't save theen.yml
    
    * Delete blanks
    
    * missed the html
    
    * Fix multiple issues
    
    * missed the .html_safe
    
    * too many %
    
    * Hopefully this is more to the liking
    
    * Use smaller keys
    
    * Follow review
    zz9pzza committed on GitHub Jan 15, 2017
Commits on Jan 9, 2017
  1. AO3-4803 extend tests for collection_participants_controller (#2690)

    * Add more coverage
    
    * Forgot a file
    
    * Trying to defeat multiple browsers
    
    * Current working state
    
    * Undo AO3-4802
    
    * A working test
    
    * Add test for update_multiple
    
    * Listen to the hound
    
    * Better names for tests from sarken
    
    * Be brave and fix things that are ugly rather than just try and get something working
    
    * Not anywhere
    
    * Merge artifact
    
    * No more You
    
    * This bit should not be here
    zz9pzza committed with sarken Jan 9, 2017
Commits on Jan 8, 2017
  1. AO3-4797 - Add Rspec tests to WorksController (#2692)

    * AO3-4797 - Cover :fandom_id parameter code
    
    * AO3-4797 - Cover :work_search parameter code
    
    * AO3-4797 - Cover index with filters disabled
    
    * AO3-4797 - Cover import_multiple error message
    
    * AO3-4797 - Cover drafts action
    
    * AO3-4797 - Cover post_drafts
    
    * AO3-4797 - Cover the _multiple actions
    
    * AO3-4797 - Move WorksController tests into a subfolder
    
    * AO3-4797 - Add a test for update
    
    * AO3-4797 - Tidy up, remove comments, rename files
    
    * AO3-4797 - Cover comment moderation toggle for mass editing
    
    * AO3-4797 - Amend index test to match copy in master
    
    * AO3-4797 - Use potatoesque's it_redirects_to helper method
    
    * AO3-4797 - Fix unnecessary let! and incorrect copy-pastes
    ariana-paris committed with zz9pzza Jan 8, 2017
  2. AO3-4819 Tests for skins controller (#2704)

    * AO3-4819 Some initial spacing and line break tidying
    
    * AO3-4819 Expand tests for skins controller
    
    * AO3-4819 Put the admin skins tests in the admins folder
    
    * AO3-4819 Fix some whoopsies
    
    * AO3-4819 One last fix
    
    * AO3-4819 Hi hound
    
    * AO3-4819 One more skin test for the workskin model
    
    * AO3-4819 Remove change that didn't belong here
    
    * AO3-4819 Fix given/when/then in first skin_wizard scenario
    
    * AO3-4819 Fix spacing in second admin_skins scenario
    
    * AO3-4819 Add one more check to delete  skin test
    sarken committed with zz9pzza Jan 8, 2017
Commits on Jan 5, 2017
  1. AO3-4529 fixing/adding links to About page (#2701)

    * fixed FAQ link in about and linked to comms contact form
    
    * removed unnecessary space
    
    * requested changes to links for easier translation
    
    * fixed broken links
    pixelred committed with ariana-paris Jan 5, 2017
  2. Merge pull request #2679 from zz9pzza/AO3-4788

    AO3-4788 Example flair page.
    mumble committed on GitHub Jan 5, 2017
Commits on Jan 4, 2017
  1. Rename file

    zz9pzza committed Jan 4, 2017
  2. AO3-4747 Confirmation page for purging assignments when JS is disabled (

    #2651)
    
    * AO3-4747 Confirmation page for purging assignments when JS is disabled
    
    * AO3-4747 Use collection title consistently and update action names
    
    * AO3-4747 Clean up the maintainer_index view
    sarken committed with zz9pzza Jan 4, 2017
  3. AO3-4549 - Stop page title creation from causing a 500 error when fan…

    …dom is empty on a work (#2695)
    ariana-paris committed with zz9pzza Jan 4, 2017
  4. AO3-4372 Change wording on Error 500 page to be more useful (#2624)

    * Word Change on e500
    
    Link code taken from current site footer
    
    * AO3 4372 Add'l File, Wording Change
    
    As decreed
    
    * AO3 4372 capitalization
    
    Don't code asleep
    
    * AO3-4372 UnRuby the HTML
    cjrecordvt committed with zz9pzza Jan 4, 2017
  5. AO3-4529 Minor changes to AO3 "About" page (#2637)

    * fixed FAQ link in about and linked to comms contact form
    
    * removed unnecessary space
    
    * requested changes to links for easier translation
    pixelred committed with zz9pzza Jan 4, 2017
  6. AO3-4791 Add strong parameters to models where we don't think we are …

    …doing mass assignment (#2682)
    
    * Low hanging , high coverage
    
    * Failed test
    
    * Readjust for failing tests
    zz9pzza committed on GitHub Jan 4, 2017
  7. AO3-4799 Strong parameters for favorite tags (#2685)

    * Testing favorite tag with protection
    
    * Add strong params to favorite tag
    sarken committed with zz9pzza Jan 4, 2017
  8. Strong params for subscription (#2686)

    sarken committed with zz9pzza Jan 4, 2017
  9. AO3-4804 Extend tests for challenge_assignments_controller (#2696)

    * Use new url
    
    * Move to right branch
    
    * tidy up blank line
    
    * Follow review
    zz9pzza committed with sarken Jan 4, 2017
Commits on Jan 3, 2017
  1. Remove unused methods (#2697)

    zz9pzza committed on GitHub Jan 3, 2017
  2. AO3-4771 Tests for the collection_participants_controller. (#2693)

    * Tests for the collection_participants_controller.
    
    Notes:
    * The collection lookup in load_participant_and_collection using collection.find raises an ActiveRecord error if the collection isn't found; since there is a case handling this I assumed it wasn't the desired behavior, so I changed it to .where(id: the_id).first which will return nil if the collection isn't found. Then the handling works as expected.
    * The participant.approve_membership! did not previously appear to work as written.
    
    * Changing things to make the hound happy
    
    * More style changes for hound
    
    * Hound mandated indents
    
    * Moving redirect expectation functions into its own helper, and replacing the spec functions that were fulfilling the same purpose.
    
    With a few other tweaks that came up in code review.
    
    * Adding frozen_string_literal comment and removing a space for the hound
    
    * collection_participants_controller:
    * Using `find_by_id` instead of `where` to be more in line with find_by migration coming down the road
    collection_participants_controller_spec:
    * Removing a stray flash check
    annelu committed with zz9pzza Jan 3, 2017
Commits on Dec 30, 2016
  1. AO3-4746 Remove vestigal external_authors pages (#2687)

    * Add rspec tests for the comments controller
    
    * Add some defensive code
    
    * Deinfect master
    
    * Clean up
    
    * Get rid of infected file
    
    * Inital clean up
    zz9pzza committed on GitHub Dec 30, 2016