Permalink
Commits on May 10, 2017
  1. AO3-3176 Prevent 500 error when editing chapter you didn't coauthor (#…

    sarken authored and bingeling committed May 10, 2017
    …2627)
    
    * AO3-3752 Let user posting a chapter set the co-creators
    
    * AO3-3752 Don't add co-creators by default
    
    * AO3-3176 Have to use type rather than @chapter to avoid affecting work form
    
    * AO3-3752 Only show co-authors when there are co-authors
    
    * AO3-3752 Tests for co-authored chapters, co-author test step changes
    
    * AO3-3752 Make the step for posting (draft) chapters work again
    
    * AO3-3752 Fix spacing in chapter edit tests
    
    * AO3-3176 Add test showing you can now edit a chapter you are not a co-author of
    
    * AO3-3176 Add steps to prove we are editing the right chapter
    
    * AO3-3752 Remove test for unrelated issue as this no longer fixes it
    
    * AO3-3752 Use byline format for cocreator checkbox labels
    
    * AO3-3752 Use double quotes in the view
    
    * AO3-3752 Use [author_attributes][ids] rather than [coauthors] because strong parameters
    
    We originally stuffed the coauthors params into the ids params in the controller, but we can't do that anymore with strong parameters.  We can possibly eliminate the stuffing step and use ids to begin with.
    
    * AO3-3752 Stop concatenating author attributes
    
    We can't concatenate params[:chapter][:author_attributes][:ids] and params[:chapter][:author_attributes] because strong parameters aren't mutable. This code was no longer working, which was a good thing because it was originally responsible for every existing co-author being added to new chapters of a work, regardless of whether you wanted that.
    
    * AO3-3752 Fix mistake from merging with master
    
    * AO3-35752 More tests relating to chapter coauthoring
    
    * AO3-3752 Remove coauthor field from hidden fields and don't allow the parameter
    
    * AO3-3752 ACTUALLY remove coauthors for chapters allowed parameters
    
    * AO3-3176 Let any work co-author edit any chapter of the work
    
    AO3-3176 Add editing user as a co-author to the chapter they are editing
    
    AO3-3176 Don't override selected_pseuds in the view
    
    AO3-3176 Consolidate the logic in the pseuds helper
    
    AO3-3176 Better name for helper method
    
    * AO3-3176 Don't add more unnecssary interger conversion for pseud.id, and fix a line break in a code comment
Commits on May 9, 2017
  1. AO3-4943 Use correct variable for series in work downloads

    zz9pzza authored and sarken committed May 9, 2017
  2. AO3-4999 Chapter: Make it easier to see and add co-authors who are al…

    sarken authored and zz9pzza committed May 9, 2017
    …ready on the work (#2515)
    
    * AO3-3752 Let user posting a chapter set the co-creators
    
    * AO3-3752 Don't add co-creators by default
    
    * AO3-3176 Have to use type rather than @chapter to avoid affecting work form
    
    * AO3-3752 Only show co-authors when there are co-authors
    
    * AO3-3752 Tests for co-authored chapters, co-author test step changes
    
    * AO3-3752 Make the step for posting (draft) chapters work again
    
    * AO3-3752 Fix spacing in chapter edit tests
    
    * AO3-3176 Add test showing you can now edit a chapter you are not a co-author of
    
    * AO3-3176 Add steps to prove we are editing the right chapter
    
    * AO3-3752 Remove test for unrelated issue as this no longer fixes it
    
    * AO3-3752 Use byline format for cocreator checkbox labels
    
    * AO3-3752 Use double quotes in the view
    
    * AO3-3752 Use [author_attributes][ids] rather than [coauthors] because strong parameters
    
    We originally stuffed the coauthors params into the ids params in the controller, but we can't do that anymore with strong parameters.  We can possibly eliminate the stuffing step and use ids to begin with.
    
    * AO3-3752 Stop concatenating author attributes
    
    We can't concatenate params[:chapter][:author_attributes][:ids] and params[:chapter][:author_attributes] because strong parameters aren't mutable. This code was no longer working, which was a good thing because it was originally responsible for every existing co-author being added to new chapters of a work, regardless of whether you wanted that.
    
    * AO3-3752 Fix mistake from merging with master
    
    * AO3-35752 More tests relating to chapter coauthoring
    
    * AO3-3752 Remove coauthor field from hidden fields and don't allow the parameter
    
    * AO3-3752 ACTUALLY remove coauthors for chapters allowed parameters
Commits on May 8, 2017
  1. AO3-5014 Use the same factories for unit and feature tests (#2913)

    redsummernight authored and zz9pzza committed May 8, 2017
    Remove the factory definitions in features/support, which requires:
    
    - Keep the language factory.
    - Fix the archive_faq factory (there's no content field).
    - Remove common_taggings from the character factory, because
      tag wrangling feature tests assume new characters are unwrangled;
      instead, add common_taggings only for the test that needs it.
    - Fix a user step to use default pseuds instead of generated ones,
      so a work edit test doesn't need to reference pseuds.
Commits on May 7, 2017
  1. AO3-5009 Remove doc/ folder (#2905)

    redsummernight authored and zz9pzza committed May 7, 2017
    These files are unused and outdated.
  2. AO3-5010 Extend bookmark search feature and use factories (#2907)

    sarken authored and zz9pzza committed May 7, 2017
    * AO3-5010 Extend bookmark search feature while still using fixtures
    
    * AO3-5010 Use factories instead of fixtures
    
    * AO3-5010 Finish putting the fixture files back to the way they were
Commits on May 5, 2017
  1. AO3-4714 Expand serial works controller test (#2900)

    cesy authored and sarken committed May 5, 2017
    * AO3-4714 Expand serial works controller test
    
    * AO3-4714 review comments
  2. AO3-5004 Add tests for work URL detection in abuse reports (#2897)

    redsummernight authored and sarken committed May 5, 2017
Commits on May 4, 2017
  1. AO3-4407 Only mention user invites on homepage to logged out visitors…

    niconicosette authored and sarken committed May 4, 2017
    … when user invites are turned on (#2729)
    
    * AO3-4407 adding conditional so that logged out users do not see 'you can get an invite from another user' when admin has disabled users from requesting invites; edited test to address this scenario
    
    * AO3-4407 fixing error
    
    * change single quotes to double quotes
  2. AO3-4885 i18n challenge assignment email (#2773)

    cesy authored and sarken committed May 4, 2017
    * AO3-4885 i18n of challenge assignment email
    
    * AO3-4885 review comments
  3. AO3-3733 AO3-4174 Fix orphaning shared series/works to avoid incorrec…

    tickinginstant authored and sarken committed May 4, 2017
    …tly adding orphan_account. (#2609)
    
    * AO3-4174 Tests for orphaning shared series.
    
    * AO3-3733 Test for orphaning shared work.
    
    * AO3-3733 & AO3-4174 Don't transfer items the user doesn't own to orphan_account.
    
    * AO3-4174 Clean up extraneous lines in test.
    
    * AO3-4174 More clean-up.
    
    * AO3-3733 & AO3-4174 Replace rescue line modifier.
    
    * AO3-3733 & AO3-4174 The other error case.
  4. AO3-5003 Fix RSpec test for admin reindexing works

    zz9pzza authored and sarken committed May 4, 2017
  5. AO3-3359 Add search button to top of advanced search form (#2641)

    niconicosette authored and sarken committed May 4, 2017
    * AO3-3359 add search button to top of advanced search form
    
    * AO3-3359 removed changes to form and stylesheets and moved them to sandbox.css
    
    * AO3-3359 re-add button to page but keep styling in sandbox
  6. AO3-4733 Extend tests for wrangling_guidelines_controller and correct…

    redsummernight authored and sarken committed May 4, 2017
    … route for reordering (#2865)
    
    * AO3-4733 Extend tests for wrangling_guidelines_controller
    
    Update related routes:
    
    - Change "reorder" route to use the actual action name "update_positions"
    - Remove "confirm_delete" route which has no action
    
    * Restore confirm_delete route, to be implemented
    
    * Reset User.current_user before each test
    
    User.current_user can be either an admin or a normal user.
    This cattr_accessor is set before each controller action,
    which means controller tests will always reset it.
    
    However, helper tests will use the value left behind by
    the last controller test. Some helper tests expect User.current
    to be a normal user, but the new last controller spec is for
    wrangling guidelines and leaves behind an admin instead.
  7. AO3-4863 Make error in reindex method a flash error rather than a not…

    ariana-paris authored and sarken committed May 4, 2017
    …ice (#2745)
  8. AO3-4621 Fetch Icons via https (#2861)

    zz9pzza authored and sarken committed May 4, 2017
    * Try and make things https
    
    * Fix lack of :
  9. AO3-4943 Fix PDF downloads with titles like -Hello-World- or any type…

    zz9pzza authored and sarken committed May 4, 2017
    … of download of a work with a deleted series or parent work (#2869)
    
    * Skip over nil parent works
    
    * Add another bit
    
    * remove - from the list of filenames generated ( it breaks pdf generation at the beginning of a work title )
    
    * Fix regex :(
    
    * Fix spacing and split complex command a bit
Commits on May 3, 2017
  1. AO3-4997 Resurrect autocomplete feature tests for tag wrangling (#2890)

    redsummernight authored and sarken committed May 3, 2017
    * AO3-4997 Resurrect autocomplete feature tests for tag wrangling
    
    Some "follow tag name link" actions become ambiguous when JavaScript
    is enabled because we have delete buttons with title containing tag
    names, so we need to switch to "Edit (tag name)".
    
    On the tag edit page, we can refer to certain fields by their labels
    only when they don't already have any values pre-filled. If they do,
    their input fields will be preceded by a section of checkboxes
    to toggle existing values, and we have to refer to them by IDs. Example:
    "Add Fandoms" vs "tag_fandom_string_autocomplete".
    
    Clean-up:
    
    - Refer to the "Canonical" checkbox by its label
    - Prefer the step "Given a (non)canonical (tag type)" over alternatives
    - Fix a TODO in the media pages test
    
    * Prefer the combo step "I choose X from the Y autocomplete"
    
    We still need to use "I enter X in the Y autocomplete" to check if:
    
    - multiple results appear for a value
    - certain results do not appear for a value
Commits on Apr 30, 2017
  1. AO3-4990 Cucumber tests for miscellaneous uncovered scenarios (#2882)

    sarken authored and zz9pzza committed Apr 30, 2017
    * Test for joining invitation queue with an email that belongs to a user account
    
    * Tests for work model validation of parent works and publication date
    
    * Tests for tag nomination model validations that need a bit more work
    
    Tweak tag set tests so no existing tests break
    
    * Test that you can't change nomination settings for a tag set that already has nominations
    
    * Test that chapter publication dates can't be in the future
    
    * Test that an email is sent to the prompter when a prompt meme claim is filled
    
    * Test various scenarios relating to parent collections and one relating to characters in a collection display title
  2. Remove duplicates (#2871)

    zz9pzza committed Apr 30, 2017
  3. AO3-4982 Move travis to later os (#2876)

    zz9pzza committed Apr 30, 2017
    * Migrate to trusty
    
    * How to tell it has worked
    
    * Try Xenial
    
    * Add collation
    
    * Move back to trusty
    
    * Created database with correct collation
  4. AO3-4992 Clear Redis before each feature test (#2884)

    redsummernight authored and zz9pzza committed Apr 30, 2017
    - Remove autocomplete-test-only-hook to clear Redis
    - When clearing the mail queue, skip the DEL command if
      there are no keys, otherwise we get an error
      ("wrong number of arguments")
  5. AO3-4993 Refactor url caching testing to use rspec rather than cucumb…

    zz9pzza committed Apr 30, 2017
    …er. (#2886)
    
    * Simple rspec test
    
    * Move to separate test
    
    * Undo change that missed the point completely
    
    * Fix syntax
Commits on Apr 28, 2017
  1. AO3-4981 test for i18n of invite email (#2874)

    cesy authored and sarken committed Apr 28, 2017
    * AO3-4981 test for i18n of invite email
    
    * AO3-4981 test expansion for what broke on test
  2. AO3-4480 Add caching to imported_from_url and update cache on deletio…

    zz9pzza authored and ariana-paris committed Apr 28, 2017
    …n of work (#2765)
    
    * Fails test...
    
    * Cache the find_by_url call
    
    * Run the tests in real testing mode
    
    * We need to flush the cache on a delete
    
    * Fix hounds
    
    * Just get this one test working they said
    
    * And another 2 or 3 hours later the test actually works
    
    * Where did I put my tardis
  3. AO3-4956 Fix capitalization for flash error in opendoors/tools_contro…

    redsummernight authored and sarken committed Apr 28, 2017
    …ller (#2885)
    
    "archive" to "Archive", "url" to "URL".
  4. AO3-4718 Fix permission checks for comments on tags. (#2883)

    tickinginstant authored and sarken committed Apr 28, 2017
    * AO3-4718 Fix permission checks for tag comments.
    
    * AO3-4718 Better cancel_comment_edit checks.
    
    * AO3-4718 RSpec tests for permission checks.
    
    * AO3-4718 Test for replying to a comment on a tag.
Commits on Apr 27, 2017
  1. AO3-4826 Tumblr share code produces wrong link text (#2777)

    sarken authored and zz9pzza committed Apr 27, 2017
    * AO3-4826 Update Tumblr share code
    
    * AO3-4826 Update address for Tumblr share widget link
  2. AO3-4847 Allow admins to see ip address of commenter (#2862)

    zz9pzza committed Apr 27, 2017
    * Allow admins to see ip address of commenter
    
    * Follow advice
    
    * Only ip is needed ?
  3. AO3-4956 Extend tests for opendoors/tools_controller.rb and change fr…

    redsummernight authored and zz9pzza committed Apr 27, 2017
    …om 404 to flash error (#2850)
    
    * AO3-4956 Extend tests for opendoors/tools_controller.rb
    
    - Display an error message instead of raising 404 when
      a work ID cannot be found.
    - Add controller spec for opendoors/tools_controller.rb.
    - Add a scenario for updating a work's imported from URL.
    
    * Use fake_logout to guarantee unauthenticated users
  4. AO3-4942 Remove unused locales code (#2834)

    redsummernight authored and zz9pzza committed Apr 27, 2017
    * AO3-4942 Remove unused code in locales_controller.rb
    
    Disable unused routes.
    
    * Remove unused locales code in application_controller
  5. AO3-4963 Modify new taggings_count code to handle brand new fandoms u…

    tickinginstant authored and zz9pzza committed Apr 27, 2017
    …sed on External Works. (#2851)
    
    * Switch to callbacks on Tagging for taggings_count.
    
    * Slightly more extensive tests.
    
    * Updated comments and modified cucumber tests.
    
    * Tests for deleting the last work with a fandom.
    
    * Fix capitalization.
  6. AO3-4105 Remove "delete" button for series in works edit form (#2648)

    niconicosette authored and zz9pzza committed Apr 27, 2017
    * AO3-4105 removed button in works edit form that deletes entire series, clearly labelled button that removes work from series
    
    * AO3-4105 fixing caps and single quotes
    
    * AO3-4105 change all strings to use double quotes
    
    * AO3-4105 change all single quotations to double quotations
  7. AO3-4712 fix 500 error on /collections filtering by fandom (#2749)

    zz9pzza committed Apr 27, 2017
    * Add rspec tests for the comments controller
    
    * Add some defensive code
    
    * Lets keep it simple
    
    * Clean up branch again
    
    * Clean up branch again
Commits on Apr 26, 2017
  1. Merge branch 'master' of https://github.com/otwcode/otwarchive

    zz9pzza committed Apr 26, 2017