Permalink
Commits on Jul 25, 2017
  1. AO3-5008: prevent subscriptions to nonsubscribable models (#2974)

    elzj authored and sarken committed Jul 25, 2017
    * AO3 5008: Tweak subscription validation to prevent subscriptions to nonsubscribable models
    
    * AO3 5008: Update spec
    
    * AO3 5008: Format tweaks
    
    * AO3 5008: Fix spec syntax and speed up a little
    
    * AO3 5008: Update spec text to match changes
Commits on Jul 24, 2017
  1. AO3-5072 Fix redirect page (#2964)

    zz9pzza authored and sarken committed Jul 24, 2017
    * Add route for redirect back
    
    * And not when
    
    * Get rather than post
    
    * Remove added route
    
    * Listen to sarken
  2. AO3-5081 Add a 1-second delay to the step for editing a work to add a…

    sarken authored and zz9pzza committed Jul 24, 2017
    … co-author rather than adding it before each individual instance of the step. This will help ensure the cached byline has time to update before we check the result. The step is used < 20 times, so it won't add a significant amount of time to the test runs. (#2972)
  3. AO3-5069 Prevent new works with series from 500ing when there are val…

    katieby authored and sarken committed Jul 24, 2017
    …idation errors (#2963)
    
    * AO3-5069 Remove links to remove work from series if work is new and persist series fields after validation.
    
    * AO3-5069 respond to sarken's comments
    
    * remove coauthor and badauthor
    
    * remove activated users
    
    * Fix stray character
Commits on Jul 23, 2017
  1. AO3-5070 Add a 1-second delay between posting the work and changing y…

    sarken authored and zz9pzza committed Jul 23, 2017
    …our username to resolve a test failure (#2967)
  2. AO3-5043 Fix 500 when attempting to access removed admin notification…

    sarken authored and zz9pzza committed Jul 23, 2017
    …s URL (#2968)
    
    * AO3-5043 Remove notification code from admin users controller
    
    * AO3-5043 Remove mailer code for admin notifications
    
    * AO3-5043 Remove admin email preference
    
    * AO3-5043 Remove the alphabethelper, which is used only in admin notifications and the people show page, which appears to be unused and will also be deleted
    
    * AO3-5043 Remove admin notifications from routes
    
    * AO3-5043 Remove cucumber tests for admin notifications feature
    
    * AO3-5043 Remove spec for admin notification feature
    
    * AO3-5043 Remove Notifications from admin nav
    
    * AO3-5043 Remove a step that was looking for the turn off admin emails preference
    
    * AO3-5043 Fix 500 error when attempting to access the removed admin notifications feature
    
    * AO3-5043 Refactor slightly to use if/else statement
    
    * AO3-5043 Return if user is not present
  3. AO3-5078 AO3-5080 Add 1-second delay to orphaning step definitions to…

    sarken committed Jul 23, 2017
    … make sure the byline cache updates in certain orphaning scenarios in orphan_series.feature (#2970)
  4. AO3-5075 Add 1-second delay between posting a work and deleting your …

    sarken committed Jul 23, 2017
    …account to ensure cache expiration and fix intermittent test failure (#2969)
  5. AO3-5071 Intermittent test failures when orphaning co-authored multi-…

    sarken committed Jul 23, 2017
    …chapter work (#2965)
    
    * AO3-5071 Add a delay between posting a work and modifying the co-author to ensure the cache key for the byline changes
    
    * AO3-5071 Update a deferred test in the other_a group to mention the issue number, not merely that the test is deferred due to intermittent failures
  6. AO3-5066 fix preview error. (#2971)

    katieby authored and sarken committed Jul 23, 2017
  7. AO3-5074 Resurrect autocomplete feature tests for works & challenges (#…

    redsummernight authored and sarken committed Jul 23, 2017
    …2966)
    
    Log in before setting up tags in the single-fandom exchange scenario.
    If we're logged in, touching a tag will set its last wrangler, which
    runs the tag's after_update hook, which updates Redis for the tag's
    fandom-specific autocomplete searches.
    
    Add default pseuds to autocomplete in some user creation steps,
    similar to features/support/user.rb.
Commits on Jul 19, 2017
  1. AO3-4995 Start migrating from _url to _path helpers (#2887)

    zz9pzza authored and sarken committed Jul 19, 2017
    * First few changes
    
    * More manual changes
    
    * Find more _urls
    
    * More _urls
    
    * url_for is relative by default
    
    * This is used in an email
Commits on Jul 18, 2017
  1. AO3-5043 Remove admin notifications feature (#2941)

    sarken authored and zz9pzza committed Jul 18, 2017
    * AO3-5043 Remove notification code from admin users controller
    
    * AO3-5043 Remove mailer code for admin notifications
    
    * AO3-5043 Remove admin email preference
    
    * AO3-5043 Remove the alphabethelper, which is used only in admin notifications and the people show page, which appears to be unused and will also be deleted
    
    * AO3-5043 Remove admin notifications from routes
    
    * AO3-5043 Remove cucumber tests for admin notifications feature
    
    * AO3-5043 Remove spec for admin notification feature
    
    * AO3-5043 Remove Notifications from admin nav
    
    * AO3-5043 Remove a step that was looking for the turn off admin emails preference
  2. AO3-5029 Several static files have bad mode (#2924)

    vaaas authored and zz9pzza committed Jul 18, 2017
    Change the modes of several public files from 755 (rwxr-xr-x) to 644
    (rw-r--r--). This prevents accidental execution. File contents are unaltered, as
    only metadata is affected.
  3. Corrected Spelling Mistake (#2921)

    otwstephanie authored and zz9pzza committed Jul 18, 2017
  4. AO3-5020 Remember work search sort direction field value (#2955)

    Meepu authored and zz9pzza committed Jul 18, 2017
    * AO3-5020 Enable test for work search sort direction
    
    * AO3-5020 Rename method to avoid name conflict with option
    
    * AO3-5020 Remember work search sort direction field value
    
    * AO3-5020 Enable more tests for work search direction
  5. AO3-5008 Validate that subscribable exists before saving (#2904)

    katieby authored and zz9pzza committed Jul 18, 2017
    * AO3-5008 Validate presence of subscribable rather than id and type.
    
    * AO3-5008 listen to the hound.
    
    * Add test for invalid type name.
    
    * Hound fixed
    
    * Listen to the hound
  6. AO3-4609 Broken links to AO3 FAQ in ToS FAQ (#2639)

    niconicosette authored and zz9pzza committed Jul 18, 2017
    * mended broken link to ao3 faq in tos faq
    
    * nope
    
    * AO3-4609 changed all hard links to paths and changed single quotes to double quotes
    
    * ao3-4609 fixing errors in links
  7. AO3-4272 Allow HTML in afterword list of anonymous remixes (#2894)

    redsummernight authored and zz9pzza committed Jul 18, 2017
    * AO3-4272 Allow HTML in afterword list of anonymous remixes
    
    * AO3-4272 Add tests for anonymous remix author links in afterword
  8. A03-3536 Show validation error message when parent Url unreachable (#…

    maryalice0 authored and zz9pzza committed Jul 18, 2017
    …2954)
    
    When an archive work is associated with an external work that has
    an unreachable URL, the previous behavior was to display a generic
    "Parent work couldn't be saved" message.  Now we will instead show
    the first validation error message for that external work, which
    should provide enough information for the user to deal with the
    underlying problem.
  9. AO3-3223 When saving a coauthor for a work, save for all existing cha…

    annelu authored and zz9pzza committed Jul 18, 2017
    …pters as well (#2922)
    
    * When saving a coauthor for a work, save for all existing chapters as well
    
    The current behavior is that when a coauthor is saved for a work, they are
    only saved as a coauthor for the first chapter. This change makes it so that
    they are saved as a coauthor for every chapter on the work. However, it does
    not change it so that each new chapter contains all the work's coauthors;
    they will only have the user who saved that chapter as an author, and all
    other coauthors have to be added manually.
    
    * Changes for the hound
    
    * Fixing orphan work test, which relied on adding a coauthor to only add the coauthor to the first chapter
    Adding a test to make sure byline appears on all chapters
    
    * Updating cukes to adhere to convention (and updated user creation)
  10. AO3-4953 - Change Support form to require email address (#2857)

    scottsds authored and zz9pzza committed Jul 18, 2017
    * AO3-4953 - Change Support form to require email address
    
    * AO3-4953 - Updating tests
    
    * AO3-4953 - Fixing a class name in a view
    
    * AO3-4953 - Updating test
    
    * AO3-4953 Update test
Commits on Jul 17, 2017
  1. AO3-5023: Restore missing order clause to wrangling query (#2962)

    elzj authored and sarken committed Jul 17, 2017
Commits on Jul 14, 2017
  1. AO3-5067 Don't eat paragraphs on edit for RTE fields (#2960)

    elzj authored and ariana-paris committed Jul 14, 2017
  2. AO3-5023 Update cache key version number for hashed tag data due to R…

    elzj authored and sarken committed Jul 14, 2017
    …ails 4.2 error (#2959)
Commits on Jul 10, 2017
  1. AO3-4924 Chapter Controller Specs (#2957)

    katieby authored and sarken committed Jul 10, 2017
    * AO3-4924 add tests for index and manage
    
    * AO3-4924 add spec for show
    
    * AO3-4924 cleaning up code
    
    * AO3-4924 Add tests for new.
    
    * AO3-4924 add tests for edit
    
    * AO3-4924 Added tests for create.
    
    * AO3-4924 Add tests for update action.
    
    * AO3-4924 Add tests for update positions.
    
    * AO3-4924 Add tests for preview.
    
    * AO3-4924 Add tests for post and confirm delete.
    
    * AO3-4924 add tests for destroy
    
    * AO3-4924 Fixing up chapters controller spec.
    
    * Listen to the hound
    
    * Listen to the hound part 2
    
    * Listen to the hound part 3
    
    * Fixing sarken's comments
Commits on Jun 28, 2017
  1. AO3-5023 Fix broken links for wrangling in a fandom (#2952)

    sarken committed Jun 28, 2017
    * AO3-5023 Add tests for wrangling within a fandom
    
    * AO3-5023 Fix broken links in wrangling sidebar
Commits on Jun 25, 2017
  1. AO3-5023 Fix logged in user claiming imported works (#2950)

    sarken authored and zz9pzza committed Jun 25, 2017
    * AO3-5023 Test that a user can claim works that weren't automatically associated with their account
    
    * AO3-5023 Fix broken route for claiming imported works
    
    * AO3-5023 Update to new Ruby hash syntax  in path definition
    
    * Reset email
    
    * AO3-5023 Tweak wording of email queue clearing step
Commits on Jun 23, 2017
  1. AO3-5023 Comment out force logout (#2948)

    zz9pzza authored and sarken committed Jun 23, 2017
  2. AO3-5023 Update finders in skin and admin rake files (#2946)

    sarken authored and zz9pzza committed Jun 23, 2017
    * AO3-5023 Update finders in skin and admin rake files and make sure we're using find_each instead of all, which loads all the things into memory
    
    * AO3-5023 Uncomment a line in the admin task that I temporarily commented out to avoid actually destroying any accounts in my dev environment
    
    * AO3-5023 Change taggings_counts back to taggings_count, since I have no idea where that change came from
Commits on Jun 19, 2017
  1. AO3-5023 Make ePub toc.ncx and content.opf stop trying to use the sit…

    sarken authored and zz9pzza committed Jun 19, 2017
    …e layout (#2944)
  2. AO3-5023 Use to_a in homepage decorator to get cache-able arrays of r…

    sarken authored and zz9pzza committed Jun 19, 2017
    …eadings and admin posts (#2945)
  3. AO3-4946 Expand challenge assignment test (#2888)

    cesy authored and sarken committed Jun 19, 2017
    * AO3-4946 Expand challenge assignment test
    
    * AO3-4946 review comments
Commits on Jun 18, 2017
  1. AO3-5023 Fix Show Most Recent Bookmarks (#2942)

    sarken authored and zz9pzza committed Jun 18, 2017
    * AO3-5023 Fix syntax on recent bookmarks
    
    * AO3-5023 Add test for Show Most Recent Bookmark button
    
    * AO3-5023 Some troubleshooting for the test
    
    * AO3-5023 Forcing another JavaScript test to fail on a 'I should see' step so I can compare it to the relevant test
    
    * AO3-5023 Revert temporarily-forced failure in tag set tests
    
    * AO3-5023 Try using a specific selector in the show recent bookmarks test
    
    * AO3-5023 Get rid of the failing 'I should see' steps
    
    * AO3-5023 Make sure the JavaScript is loading
    
    * AO3-5023 Undo JavaScript changes now that I see the JavaScript is loading
    
    * AO3-5023 Temporarily remove style that hides the Show Most Recent Bookmark link
    
    * AO3-5023 Restore the style I temporarily removed, and include some spacing, quotation mark, and hash rocket fixes in views/bookmarks/_bookmark_blurb
    
    * AO3-5023 Got overzelous with my tidying of the bookmark blurb -- url_for should not become path_for
    
    * AO3-5023 Add a step to expire the bookmark count  cache
    
    * AO3-5023 And now we make sure the cache is expiring
    
    * AO3-5023 Put the bookmark count for troubleshooting
    
    * AO3-5023 Try expiring the cache for the entire bookmark page as well
    
    * AO3-5023 Try running the statistics rake task before accessing the bookmark page
    
    * AO3-5023 Try running the rake and expiring the stats cache
    
    * AO3-5023 We will now entertain the possibility the bookmarks don't exist
    
    * AO3-5023 Let's try updating the indexes in addition to running the stats task and expiring the caches
    
    * AO3-5023 Fix getting the number of bookmarks by counting the actual items
    
    * AO3-5023 Put the stats task and the search index updating in the steps, add some more puts to get more information for troubleshooting
    
    * AO3-5023 Remove work.touch from cache expiration  step to see if it's necessary
    
    * AO3-5023 Tests for using Show Most Recent Bookmarks on the bookmarks index
    
    * AO3-5023 Go back to the simplest way of doing things now that the test works
    
    * AO3-5023 There's a k in 'bookmarks' and I can remove the half-deleted step
Commits on Jun 17, 2017
  1. AO3-5045 Clear caches before each unit test (#2943)

    redsummernight authored and sarken committed Jun 17, 2017
    Before each unit test, clear memcached, Redis, and Elasticsearch.