Permalink
Commits on Nov 21, 2017
  1. AO3-5234: Fix for unapproving approved works (#3177)

    elzj authored and sarken committed Nov 21, 2017
    * AO3-5234: Add subnav to view reviewed works and update return statements to prevent false error messages
    
    * AO3-5234: Make sure you can re-mark approved works as spam
    
    * AO3-5234: More language tweaks
  2. AO3-5234: Add subnav to view reviewed works and update return stateme…

    elzj authored and sarken committed Nov 21, 2017
    …nts to prevent false error messages (#3176)
Commits on Nov 20, 2017
  1. AO3-5251: Add spam-specific hidden work email (#3171)

    elzj authored and sarken committed Nov 20, 2017
    * AO3-5251: Add spam-specific hidden work email
    
    * AO3-5251: Update specs and rearrange settings
Commits on Nov 19, 2017
  1. AO3-4971 Add test for deleting the specified invite request (#3174)

    redsummernight authored and sarken committed Nov 19, 2017
Commits on Nov 18, 2017
  1. AO3-5249 Add basic search of invitation queue (#3164)

    sarken authored and elzj committed Nov 18, 2017
    * AO3-5249 Test for searching emails in the queue
    
    * AO3-5249 Add basic search of invitation queue
    
    * AO3-5249 Remember search query when deleting without JavaScript
    
    * AO3-5249 Put scenario back on one line
    
    * AO3-5249 The word you want for the test is SCENARIO, not Search, jfc
    
    * AO3-5249 Update test to check query field
    
    * AO3-5249 Update test to reflect Delete is a button
  2. AO3-5243 Use correct finder when destroying invite requests (#3163)

    sarken authored and elzj committed Nov 18, 2017
Commits on Nov 17, 2017
  1. AO3-5234 Moderate Works (#3162)

    elzj authored and sarken committed Nov 17, 2017
    * AO3-5234: Add admin pages for reviewing and updating moderated spam works
    
    * AO3-5234 Frontend tweaks
    
    * AO3-5234: Add admin setting for automatically hiding spam works
    
    * AO3-5234: Testing spam features
    
    * AO3-5234: Unhide ham
    
    * AO3-5234: Add pagination for admin page
    
    * AO3-5234: Send emails about hiding spam works and hide works on review when it isn't happening automatically
Commits on Nov 16, 2017
  1. AO3-5247 Use _url helper in spam alert email (#3160)

    sarken authored and ariana-paris committed Nov 16, 2017
    * AO3-5247 Use _url helper in spam alert email
    
    * AO3-5247 Use _url helper in invitation request decline email too
  2. AO3-3848 Added Feature test for a locked user account (#3135)

    hatal175 authored and sarken committed Nov 16, 2017
    * AO3-3848 Added feature test for brute force lock
    
    * AO3-3848 Remove spaces from line
    
    * AO3-3848 Change for to times
    
    * AO3-3848 Fix multi line block
    
    * AO3-3848 Replace user lock feature test with rspec test
    
    * AO3-3848 hound fixes
    
    * AO3-3848 code review changes
    
    * AO3-3848 Removed superfluous plus one
    
    * AO3-3848 Removed unused parenthesys
Commits on Nov 13, 2017
  1. AO3-4971 Display notice when deleting non-existent invite requests (#…

    redsummernight authored and sarken committed Nov 13, 2017
  2. AO3-4855 Add rspec tests for the gifts exchange controller (#3158)

    hatal175 authored and sarken committed Nov 13, 2017
Commits on Nov 12, 2017
  1. AO3-5243 Use AJAX to delete invitation requests (#3151)

    sarken committed Nov 12, 2017
    * AO3-5243 Use AJAX to delete invitation requests
    
    * AO3-5243 Remove unnecessary redirect
    
    * AO3-5243 Look in the right place for eerrors
Commits on Nov 8, 2017
  1. AO3-4222 Fix links to news post tag and capitalization of spam (#3149)

    sarken authored and zz9pzza committed Nov 8, 2017
    * AO3-4222 Fix links to 'invitations' news posts and capitalization of 'spam'
    
    * AO3-4222 Update capitalization of spam in tests
Commits on Nov 4, 2017
  1. AO3-4200 Add rel=nofollow to links to reduce SEO usefulness for spamm…

    ariana-paris authored and sarken committed Nov 4, 2017
    …ers (#3137)
    
    * AO3-4200 Add rel=nofollow to links to reduce SEO usefulness for spammers
    
    * AO3-4200 Add rel=nofollow to StoryParser test
    
    * AO3-4200 Test sanitisation in all the text fields that allow CSS classes
  2. AO3-5240 Revert timezone in gift exchange test to Papua New Guinea ag…

    ariana-paris authored and sarken committed Nov 4, 2017
    …ain (#3140)
  3. AO3-4222 Improve homepage and invite requests page when queue is off (#…

    sarken authored and ariana-paris committed Nov 4, 2017
    …3134)
    
    * AO3-4222 Remove broken and unused new invite requests view
    
    * AO3-4222 Give users more information when invite queue is disabled
    
    * Move the form for checking invite request status to a separate page
    * Create separate partials for invite request page depending on whether the queue is on or off
    * Update homepage text
    
    * AO3-4222 Update tests for invitation queue related features
    
    * AO3-4222 Correct a test
    
    * AO3-4222 Update the show page for invitation request statuses
    
    * AO3-4222 Update tests
    
    * AO3-4222 Restore views/invite_requests/new.html.erb so it can be removed in the proper issue
    
    * AO3-4222 Use @admin_setting instead of AdminSetting in invite_request view
    
    * AO3-4222 Correct name of instance variable in views
Commits on Nov 2, 2017
Commits on Oct 31, 2017
  1. AO3-4331 Mark works as spam or ham (#3131)

    sarken authored and ariana-paris committed Oct 31, 2017
    original code by shalott
    
    * allow admins to mark works as spam/not spam
    
    option for admin to mark works as spam or not (and thereby send reports to Akismet which will improve its identification of spam works)
    
    Signed-off-by: shalott <shalott@gmail.com>
    
    * reformatted admin options bit
    
    Reformatted to match sarken's changes in pullreq 2076
    
    Signed-off-by: shalott <shalott@gmail.com>
    
    * added automatic un/hiding to spam settings
    
    Now automatically hides/unhides work when marked as spam or ham.
    
    Signed-off-by: shalott <shalott@gmail.com>
    
    * fixing valid hound issues
    
    Signed-off-by: shalott <shalott@gmail.com>
    
    * squashed update from master to resolve conflicts
    
    Signed-off-by: astolat shalott <shalott@gmail.com>
    
    * fix new ambiguous step match
    
    Signed-off-by: astolat shalott <shalott@gmail.com>
    
    * AO3-4331 Define akismet_attributes in work model
    
    * AO3-4331 Actually finish resolving merge conflicts
    
    * AO3-4331 Tweak whitespace
    
    * AO3-4331 Remove 'hide' from generic error message
  2. AO3-5236: Change timeframe in test to prevent month-length-related te…

    elzj authored and ariana-paris committed Oct 31, 2017
    …st failures (#3132)
  3. AO3-5205: Prevent sign ups with duplicate emails in the invite queue (#…

    elzj authored and ariana-paris committed Oct 31, 2017
    …3130)
    
    * AO3-5205: Prevent sign ups with duplicate emails in the invite queue
    
    * AO3-5205: Make plus removal from emails more thorough and satisfy hounding
    
    * AO3-5205: Add condition to validation to avoid false positives on update
    
    * AO3-5205: Fix validation problem and ensure unique emails in tests
Commits on Oct 11, 2017
  1. AO3-5202 Fix MIME type for MOBI downloads (#3103)

    redsummernight authored and sarken committed Oct 11, 2017
  2. Add insecure to list of urls. (#3102)

    zz9pzza authored and elzj committed Oct 11, 2017
Commits on Oct 6, 2017
  1. AO3-5199: Don't generate extra html files (#3101)

    elzj authored and zz9pzza committed Oct 6, 2017
  2. AO3-5183 Update migration for adding new index to preferences (#3100)

    sarken authored and ariana-paris committed Oct 6, 2017
    * AO3-5183 Index preferences on skin_id
    
    * AO3-5183 Update migration with newer date
  3. AO3-5183 Index preferences on skin_id (#3074)

    sarken committed Oct 6, 2017
  4. AO3-5173 Remove linger admin notifications view (#3061)

    sarken committed Oct 6, 2017
  5. AO3-5082 Intermittent test failure when removing self as co-author of…

    sarken committed Oct 6, 2017
    … series or work (#2973)
    
    * AO3-5082 Add 1-second delay to a test to allow the cached byline on a series time to update when removing an author
    
    * AO3-5082 Add 1-second delay to a test to allow the cached byline on a work time to update when removing an author
    
    * AO3-5082 Turns out the series co-author removal failure was a bug, so I have deferred the test with the issue number (AO3-5083)
  6. AO3-4658 Log in page needs mobile styling (#2880)

    sarken committed Oct 6, 2017
  7. AO3-4840 Skin wizard should change bottom border on Reindex Work butt…

    sarken committed Oct 6, 2017
    …on (#2722)
  8. AO3-4004 Handle focus after autocomplete token limit reached (#2656)

    sarken committed Oct 6, 2017
    * AO3-4004 Handle focus after autocomplete token limit reached
    
    * AO3-4004 Shorten a comment for Hound and remove a blank link I didn't mean to put in
    
    * AO3-4004 anchors are like Highlanders there can be only one
    
    * AO3-4004 Fix filling in external work fields with JavaScript
    
    * Revert "AO3-4004 Fix filling in external work fields with JavaScript"
    
    This reverts commit 8336772.
  9. AO3-1259 Add "Remove Me As Chapter Co-Creator" to chapter edit page (#…

    sarken committed Oct 6, 2017
    …2518)
    
    * AO3-3752 Let user posting a chapter set the co-creators
    
    * AO3-3752 Don't add co-creators by default
    
    * AO3-3176 Have to use type rather than @chapter to avoid affecting work form
    
    * AO3-3752 Only show co-authors when there are co-authors
    
    * AO3-3752 Tests for co-authored chapters, co-author test step changes
    
    * AO3-3752 Make the step for posting (draft) chapters work again
    
    * AO3-3752 Fix spacing in chapter edit tests
    
    * AO3-3176 Add test showing you can now edit a chapter you are not a co-author of
    
    * AO3-3176 Add steps to prove we are editing the right chapter
    
    * AO3-1259 Tests for removing yourself as co-author of a chapter
    
    * AO3-1259 Remove yourself as a chapter co-author from edit and manage chapters page and make sure the chapter byline updates
    
    * AO3-1259 Put the cache expiration in the chapter model rather than the creation observer since observers are going bye-bye
    
    AO3-1259 Throw the hound a bone, or at least some newlines
    
    AO3-1259 I have no idea because I'm trying to rebase
    
    AO3-1259 Final newline for chapter model
    
    * AO3-3752 Remove test for unrelated issue as this no longer fixes it
    
    * AO3-3752 Use byline format for cocreator checkbox labels
    
    * AO3-3752 Use double quotes in the view
    
    * AO3-3752 Use [author_attributes][ids] rather than [coauthors] because strong parameters
    
    We originally stuffed the coauthors params into the ids params in the controller, but we can't do that anymore with strong parameters.  We can possibly eliminate the stuffing step and use ids to begin with.
    
    * AO3-3752 Stop concatenating author attributes
    
    We can't concatenate params[:chapter][:author_attributes][:ids] and params[:chapter][:author_attributes] because strong parameters aren't mutable. This code was no longer working, which was a good thing because it was originally responsible for every existing co-author being added to new chapters of a work, regardless of whether you wanted that.
    
    * AO3-3752 Fix mistake from merging with master
    
    * AO3-35752 More tests relating to chapter coauthoring
    
    * AO3-3752 Remove coauthor field from hidden fields and don't allow the parameter
    
    * AO3-3752 ACTUALLY remove coauthors for chapters allowed parameters
    
    * AO3-1259 Remove extra blank line that was unnecssarily added to the byline view
    
    * AO3-1259 Change 'author' to 'creator' in relevant example
Commits on Oct 5, 2017
  1. AO3-5197: Avoid errors when word counting empty strings (#3098)

    elzj authored and sarken committed Oct 5, 2017
  2. AO3-5125 Map Open Doors temp site URLs to original site URLs (#3016)

    elzj authored and sarken committed Oct 5, 2017
    * Open doors: add import url mapping for hexfiles and hpfandom
    
    * Open Doors import mapping: use CSV mapping for all of them
    
    * AO3-5125: Update OD mapping to be more flexible
  3. AO3-4976 Fix stray semicolons in autocomplete results with ampersands (

    redsummernight authored and sarken committed Oct 5, 2017
    …#2923)
    
    Avoid highlighting an empty search term, which can split an ampersand
    entity, leaving a semicolon: "&amp<b></b>;".
  4. AO3-177 Spam comments should not be included in comment counts. (#2893)

    tickinginstant authored and sarken committed Oct 5, 2017
    * AO3-177 Fix the comment counts to ignore spam.
    
    * AO3-177 Tests for comment counts with spam.
    
    * AO3-177 Fix thread count on stats page.
    
    * AO3-177 Fix stat totals.
    
    * AO3-177 Shorter function name.
    
    * AO3-177 Fix up existing test.