Permalink
Commits on Oct 2, 2018
  1. AO3-5330 Link to contact form with AO3 Support selected (#3430)

    sarken authored and zz9pzza committed Oct 2, 2018
Commits on Sep 29, 2018
  1. AO3-5531 Don't use hidden field for abuse report IP, plus fix live va…

    sarken authored and zz9pzza committed Sep 29, 2018
    …lidation (#3427)
    
    * AO3-5531 Don't get IP address via hidden field
    
    * AO3-5531 Switch to double quotes and fix broken live validation on summary field
    
    * AO3-5531 Don't permit ip_address parameters to be passed
  2. AO3-5330 Add an error page for blocked IPs (#3240)

    zz9pzza authored and sarken committed Sep 29, 2018
    * Inital draft page
    
    * Sarken's comments
    
    * Update menus
Commits on Sep 26, 2018
  1. AO3-5534 Encode form data in PAC/Support ticket requests (#3428)

    redsummernight authored and sarken committed Sep 26, 2018
    The request body is application/x-www-form-urlencoded which means
    plus signs need to be percent-encoded or they will be interpreted
    as spaces.
Commits on Sep 24, 2018
  1. AO3-5488 Make ticket tracker URLs more configurable (#3423)

    sarken authored and zz9pzza committed Sep 24, 2018
    * Remove old ticket tracker config as well
  2. AO3-5382 Store the signup summary in Memcached. (#3422)

    tickinginstant authored and zz9pzza committed Sep 24, 2018
    * AO3-5382 Store the signup summary in Memcached.
    
    * AO3-5382 Changes suggested by Sarken.
    
    * AO3-5382 Add version number to cache key.
Commits on Sep 22, 2018
  1. AO3-4638 Use MySQL 5.7.22 in CI (#3420)

    redsummernight authored and zz9pzza committed Sep 22, 2018
    * AO3-4638 Use MySQL 5.7 latest in Travis
    
    * AO3-4638 Use MySQL 5.7.22 on Codeship
    
    Connections to localhost on Unix will use a socket file at
    /tmp/mysql.sock by default, but mysql-5.7.sh set up the socket file
    at $HOME/mysql-$MYSQL_VERSION/socket/mysqld.sock. We could set
    the socket in the adapter configuration, or we could connect
    with TCP at the correct port using host 127.0.0.1.
    
    Set PATH so mysql commands use the 5.7 binary.
    
    * AO3-4638 Set SQL mode to exclude ONLY_FULL_GROUP_BY in CI
    
    Also set SQL mode to match beta.
    
    Since MySQL 5.7.5, the default SQL mode includes ONLY_FULL_GROUP_BY,
    which breaks several queries. We'll stick with 5.6-like handling
    of GROUP BY.
Commits on Sep 18, 2018
  1. AO3-4366 Add manage and user invitations buttons to admin user page (#…

    hatal175 authored and sarken committed Sep 18, 2018
  2. Ignore vulnerability in ruby-ffi 1.9.18 (#3425)

    redsummernight authored and sarken committed Sep 18, 2018
    This only affects Windows, and the gem will be removed when we
    switch from Authlogic to Devise.
Commits on Sep 15, 2018
  1. AO3-5482 Avoid saving long paths in session cookie (#3417)

    redsummernight authored and zz9pzza committed Sep 15, 2018
    * AO3-5482 Avoid saving long paths in session cookie
    
    Sessions are stored in cookies, which has a 4KB size limit.
    If we store paths that are too long (e.g. filters with lots of
    exclusions), we will run into CookieOverflow errors.
    
    * AO3-5482 Remove old stored path if not saving a new one
Commits on Sep 5, 2018
  1. AO3-5489 Best match sorting for bookmarks (#3418)

    elzj authored and zz9pzza committed Sep 5, 2018
    * AO3-5456 Remove tests for Elasticsearch 0.90
    
    Start only Elasticsearch 6.0 in test builds.
    
    Update test for AO3-5331: searching by additional tags for a synonym
    of a metatag returns only works using the exact tag.
    
    * AO3-5456 Remove step to activate new search for specific users
    
    * AO3-5456 Update collection test to look for Bookmarked Items
    
    * Clean up remnants of the old search system
    
    * Remove Tire gem
    
    * Restore method that's still needed
    
    * Remove subqueue class and tests
    
    * Remove more checks
    
    * Update travis config and remove old search tests
    
    * Remove upgrade test and mark one needing updates as pending
    
    * Remove more new-search tags
    
    * AO3-5477: Nix search class but retain helper methods
    
    * AO3-5477: Turn work search into a helper class before potentially breaking it down
    
    * AO3-5477: Fix nil errors in search range
    
    * AO3-5477: One more fix for nils
    
    * AO3-5477: Clean up views
    
    * AO3-5477: Remove last remnants of old work search class
    
    * AO3-5477: Add back search option handling methods
    
    * AO3-5477 and AO3-5490: Add boost and fix specs
    
    * AO3-5477: Add sorting check back to work search form, update test syntax, and tweak boosts
    
    * AO3-5477: A couple more tweaks
    
    * AO3-5477: Remove stray reference to new search
    
    * AO3-5477: Remove two more expendable classes
    
    * AO3-5477: Avoid conflicts when updating config by renaming the variable
    
    * AO3-5477: Fix best match sorting on bookmarks
  2. New hosts (#3419)

    zz9pzza authored and elzj committed Sep 5, 2018
Commits on Aug 29, 2018
  1. AO3-5477 Elasticsearch URL config update (#3415)

    elzj authored and redsummernight committed Aug 29, 2018
    * AO3-5477: Avoid conflicts when updating config by renaming the variable
  2. AO3-5515 Remove rubyzip 1.2.1 and selenium-webdriver (#3416)

    redsummernight authored and sarken committed Aug 29, 2018
    rubyzip 1.2.1 is affected by CVE-2018-1000544 and only used by
    selenium-webdriver, a test-only dependency. We can remove both.
Commits on Aug 28, 2018
  1. AO3-5477 AO3-5489 AO3-5490 Remove old search, fix best match sorting …

    elzj authored and sarken committed Aug 28, 2018
    …and creator/title boosting in work search (#3379)
    
    * AO3-5456 Remove tests for Elasticsearch 0.90
    
    Start only Elasticsearch 6.0 in test builds.
    
    Update test for AO3-5331: searching by additional tags for a synonym
    of a metatag returns only works using the exact tag.
    
    * AO3-5456 Remove step to activate new search for specific users
    
    * AO3-5456 Update collection test to look for Bookmarked Items
    
    * Clean up remnants of the old search system
    
    * Remove Tire gem
    
    * Restore method that's still needed
    
    * Remove subqueue class and tests
    
    * Remove more checks
    
    * Update travis config and remove old search tests
    
    * Remove upgrade test and mark one needing updates as pending
    
    * Remove more new-search tags
    
    * AO3-5477: Nix search class but retain helper methods
    
    * AO3-5477: Turn work search into a helper class before potentially breaking it down
    
    * AO3-5477: Fix nil errors in search range
    
    * AO3-5477: One more fix for nils
    
    * AO3-5477: Clean up views
    
    * AO3-5477: Remove last remnants of old work search class
    
    * AO3-5477: Add back search option handling methods
    
    * AO3-5477 and AO3-5490: Add boost and fix specs
    
    * AO3-5477: Add sorting check back to work search form, update test syntax, and tweak boosts
    
    * AO3-5477: A couple more tweaks
    
    * AO3-5477: Remove stray reference to new search
    
    * AO3-5477: Remove two more expendable classes
Commits on Aug 26, 2018
  1. AO3-4625 Make call to potentially missing bookmarkable safer (#3413)

    ariana-paris authored and redsummernight committed Aug 26, 2018
    * AO3-4625 Make call to potentially missing bookmarkable safer
    
    * AO3-4625 Remove redundant variable assignment
  2. AO3-5420 Add more line-height for stats links in blurbs (#3414)

    redsummernight authored and sarken committed Aug 26, 2018
    Use the Archive's em scale: 30px/14px = 2.143.
Commits on Aug 22, 2018
  1. AO3-5323 Disable support form (#3398)

    ariana-paris authored and sarken committed Aug 22, 2018
    * AO3-5323 Add admin setting to disable support form
    
    * AO3-5323 Don't toggle the support textbox
    
    * AO3-5323 Display disabled text instead of support form if it is disabled
    
    * AO3-5323 Add AdminSetting to update controller action
    
    * AO3-5323 Remove unused JS and use new cached AdminSetting
    
    * AO3-5323 Update text on Support form
    
    * AO3-5323 Update migration and link to Abuse
Commits on Aug 18, 2018
  1. AO3-5510: Make tag update transaction size configurable (#3410)

    elzj authored and zz9pzza committed Aug 18, 2018
  2. AO3-5448 Return 404 instead of 500 for nonexistent FAQs (#3412)

    redsummernight authored and sarken committed Aug 18, 2018
Commits on Aug 17, 2018
  1. Revert "AO3-4458 Update mail gem to 2.7.0 (#3408)" (#3411)

    redsummernight authored and sarken committed Aug 17, 2018
    This reverts commit eb352ce.
Commits on Aug 16, 2018
  1. AO3-5453 Really encode deleted work email attachments with base64 (#3409

    redsummernight authored and sarken committed Aug 16, 2018
    )
    
    If we specify an encoding, Mail will assume that the content is
    already encoded and not try to encode it. We'll do it ourselves.
Commits on Aug 14, 2018
  1. AO3-4458 Update mail gem to 2.7.0 (#3408)

    redsummernight authored and sarken committed Aug 14, 2018
Commits on Aug 13, 2018
  1. AO3-5447 Give 404 instead of 500 for works pages for nonexistent users (

    sarken authored and redsummernight committed Aug 13, 2018
    #3345)
    
    * AO3-5447 Raise 404 error for nonexistent users' works pages
    
    * AO3-5447 Owner tests
    
    AO3-5447 Test mergers in collections as long as I'm here
    
    * AO3-5447 Fix test failures
    
    * It thought 'the works page' meant /users/the/works and not just /works
    * Typo in admin tests had us checking a nonexistent user's works page
    
    AO3-5447 Fix tests that were accidentally checking the works pages for nonexistent users
    
    AO3-5447 Update the regex for user work paths
    
    * Thanks zz9pzza
    
    * AO3-5447 Clean up exisiting tests
    
    * Less FactoryGirl.create
    * Less posted: true
    * Less repetition on the includes
    
    AO3-5447 Older tests shouldn't say should
    
    * AO3-5447 Spacing fixes for specs
    
    * AO3-5447 Use find_by! to raise RecordNotFound error
    
    * AO3-5447 Prefer let! over instance variables in new tests
  2. AO3-5509 Wait for ES startup on Codeship (#3407)

    redsummernight authored and sarken committed Aug 13, 2018
    Also fix the find command in check_syntax.
Commits on Aug 12, 2018
  1. AO3-5503: Add caching to subscription emails (#3406)

    elzj authored and sarken committed Aug 12, 2018
    * AO3-5503: Add caching to subscription emails
    
    * AO3-5503: Extract method so we don't have to set it in the mailer view, enable mailer caching in various environments
Commits on Aug 11, 2018
  1. AO3-5369 work previous/next chapter navigation to anchor on main cont…

    DreamSea authored and redsummernight committed Aug 11, 2018
    …ent (#3280)
  2. AO3-5190 Abuse and support form language on error (#3235)

    Meepu authored and redsummernight committed Aug 11, 2018
    * AO3-5190 Abort and support form language on error
    
    * AO3-5190: Add tests
    
    * AO3-5190 Fix faulty test condition, remove unnecessary test scenario
  3. AO3-5019 Fix text overlap in related works section on downloads (#3167)

    tuff authored and redsummernight committed Aug 11, 2018
    * AO3-5019 Fix text overlap in related works section on downloads
    
    * AO3-5019 (review) Restore only_path:false in related works bylines
    
    * AO3-5019 (review) avoid splitting up ts() strings
    
    * AO3-5019 (review) work_url -> url_for
  4. AO3-5185 Strip blank autocomplete words (#3076)

    tickinginstant authored and redsummernight committed Aug 11, 2018
  5. AO3-4559: Languages can be sorted alphabetically by optional sortable…

    cyrilcee authored and sarken committed Aug 11, 2018
    …_name (#3107)
    
    * A03-4559 Add sortable_name column and index to languages
    
    * AO3-4559 Admin can edit language by sortable_name, with specs
    
    * AO3-4559 Language.default_order sorts by sortable_name first, short second
    
    * AO3-4559 Sort languages by default_order everywhere
    
    * Address Houndci-bot comments
    
    * AO3-4559 Sort languages by default_order instead of name
    
    * AO3-4559 Update timestamp on add_sortable_to_languages migration file
Commits on Aug 9, 2018
  1. AO3-5140 Fix date search regex matching whitespace (#3106)

    MaaikeVR authored and redsummernight committed Aug 9, 2018
  2. AO3-5335 Fix dropdown ordering on error pages (#3253)

    digiAlchem authored and redsummernight committed Aug 9, 2018
    * AO3-5335 - fixes dropdown ordering on error pages
    
    - "Search" dropdown now has Bookmarks and People in the correct order
    - "FAQ" in the "About" dropdown now links to the correct FAQ page
    - "About" dropdown now contains Wrangling Guidelines link
    
    * AO3-5335 - updates Search dropdown to use correct ordering, updates nomaintenance.html with new dropdowns