Permalink
Commits on Nov 26, 2018
  1. AO3-5541 Modify draft deletion task. (#3474)

    tickinginstant authored and sarken committed Nov 26, 2018
    Make it so that drafts are deleted in the same transaction as their
    chapters, hopefully reducing the incidence of works without chapters.
    
    In addition, make the draft purge task more resistant to failures, and
    print out errors for all of the drafts that couldn't be deleted.
Commits on Nov 24, 2018
  1. AO3-2378 Add task to reset word count for works of a language (#3473)

    redsummernight authored and sarken committed Nov 24, 2018
    * AO3-2378 Add task to reset word count for works of a language
    
    Add new test type for Rake tasks.
    
    * AO3-2378 Remove unnecessary word_count_will_change! call on works
    
    Unlike chapters, works will always have word count reset on save.
    
    * AO3-2378 Move new task to namespace After
    
    * AO3-2378 Update task comment
Commits on Nov 21, 2018
  1. AO3-5571 Add better error handling to bookmark import (#3471)

    ariana-paris authored and sarken committed Nov 21, 2018
  2. AO3-5561 Fix comment permissions on unrevealed works (#3472)

    redsummernight authored and sarken committed Nov 21, 2018
    * AO3-5561 Check for unrevealed works before commenting
    
    * AO3-5561 Hide edit and reply buttons
Commits on Nov 20, 2018
  1. AO3-5570 Upgrade tests to use Elasticsearch 6.5.0 (#3469)

    sarken authored and zz9pzza committed Nov 20, 2018
  2. AO3-5560 Use shared examples for hidden commentable tests (#3470)

    redsummernight authored and sarken committed Nov 20, 2018
Commits on Nov 17, 2018
  1. AO3-5547 Upgrade Elasticsearch to 6.4.3 for CI (#3448)

    sarken authored and redsummernight committed Nov 17, 2018
    * Run tests on Elasticsearch 6.4.2
    
    * Retry wait on Travis
    
    * Make the Elasticsearch version and port configurable in Travis script
    
    * AO3-5547 Elasticsearch 6.4.3
Commits on Nov 15, 2018
  1. AO3-5567 Tell Hound to stop caring about length (#3468)

    redsummernight authored and sarken committed Nov 15, 2018
    Disable metrics cops about length: block, class, line, method, module.
  2. AO3-5559 Rename bookmark notes, comment content, and series notes col…

    sarken authored and redsummernight committed Nov 15, 2018
    …umns (#3467)
    
    * AO3-5559 Add feature tests for class attribute
    
    * AO3-5559 Rename content to comment_content in comment step definitions
    
    * AO3-5559 Rename notes to bookmarker_notes in bookmark step definitions
    
    * AO3-5559 Update specs and factories
    
    * AO3-5559 Use separate whitelist if field allows CSS
    
    * AO3-5559 Migration to rename content and note fields that should not allow class attribute
    
    * AO3-5559 Allow HTML on renamed columns
    
    * AO3-5559 Rename fields in fixtures
    
    * AO3-5559 Correct alphabetization of fields allowing HTML
    
    * AO3-5559 Rename notes to series_notes in model, controller, and views
    
    * AO3-5559 Rename content to comment_content in comment model, controller, views, and commentable plugin
    
    Note that mailers use sanitized_content and do not need updating
    
    * AO3-5559 Rename content to comment_content for inbox view
    
    Neither model nor controller used comment.content
    
    * AO3-5559 Rename notes to bookmarker_notes in bookmark views, controller, and model
    
    * AO3-5559 Rename notes to bookmarker_notes in search models
    
    * AO3-5559 Rename notes to bookmarker_notes in API controllers
    
    * AO3-5559 Rename notes to bookmarker_notes in share helper
    
    * AO3-5559 Rename content to comment_content in tag wranglings views
    
    * AO3-5559 Correct bookmark notes field name in config and add test
  3. AO3-5529 Order collected works by date updated by default (#3426)

    sarken authored and redsummernight committed Nov 15, 2018
  4. AO3-5560 Comment permissions on hidden works. (#3465)

    tickinginstant authored and redsummernight committed Nov 15, 2018
    * AO3-5560 When accessing comments, check hidden_by_admin.
    
    * AO3-5560 More error messages when showing forms.
    
    * AO3-5560 Cucumber test for hidden work w/comments.
    
    * AO3-5560 Delete excess whitespace.
    
    * AO3-5560 Missing one action.
Commits on Nov 13, 2018
  1. AO3-5566 Add tests for previewing when adding work to collection (#3466)

    sarken authored and zz9pzza committed Nov 13, 2018
    * Test adding collections with preview behavior
    
    * AO3-5566 Add final newline
Commits on Nov 12, 2018
  1. AO3-5554 Fix ruby version syntax inside .ruby-version (#3464)

    ravron authored and sarken committed Nov 12, 2018
  2. [Security] Bump rack from 2.0.5 to 2.0.6 (#3462)

    dependabot[bot] authored and sarken committed Nov 12, 2018
    Bumps [rack](https://github.com/rack/rack) from 2.0.5 to 2.0.6. **This update includes security fixes.**
    - [Release notes](https://github.com/rack/rack/releases)
    - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md)
    - [Commits](rack/rack@2.0.5...2.0.6)
    
    Signed-off-by: dependabot[bot] <support@dependabot.com>
  3. AO3-5562 Use Dependabot for gem updates (#3460)

    redsummernight authored and sarken committed Nov 12, 2018
    The bot needs the explicit Ruby version in the Gemfile.
    
    Change gem_security.sh to not fail Travis builds.
Commits on Nov 11, 2018
  1. AO3-5530 Test posting works/comments with 4-byte UTF-8 characters (#3433

    redsummernight authored and sarken committed Nov 11, 2018
    )
    
    * AO3-5530 Test posting works/comments with 4-byte UTF-8 characters
    
    Once more with feeling (emoji).
    
    * AO3-5530 Add collation to Codeship database adapter settings
  2. AO3-5554 Fix Ruby version can't be detected (#3456)

    ravron authored and redsummernight committed Nov 11, 2018
    * Rename .ruby_version to .ruby-version
    
    * Reference the renamed ruby-version from configs
    
    * Try to fix Hound's complaints
Commits on Nov 9, 2018
  1. AO3-5537 Spam check abuse reports (#3449)

    sarken authored and redsummernight committed Nov 9, 2018
    * AO3-5537 Check abuse reports for spam
    
    * AO3-5537 No need to save results of spam check
    
    * AO3-5537 Test spam check validation
    
    * AO3-5537 Try forcing spam check to pass in feature tests
    
    * AO3-5537 Fix typo in method name
    
    * AO3-5537 Make abuse report model spec pass
    
    * AO3-5537 Actually make the abuse report model specs pass
    
    * AO3-5537 Assume abuse reports aren't spam so emails can be tested
    
    * AO3-5537 Remove newly redundant require from step definition file
    
    * Fix spacing, but remove new tests
    
    * Readd tests for alternate URLs
    
    * AO3-5537 Add final newline
Commits on Nov 8, 2018
  1. AO3-5543 AO3-5553 Update gems nokogiri and loofah (#3455)

    redsummernight authored and sarken committed Nov 8, 2018
    Update nokogiri to 1.8.5, loofah to 2.2.3.
  2. AO3-5558 Check ownership when adding a series. (#3458)

    tickinginstant authored and sarken committed Nov 8, 2018
Commits on Nov 5, 2018
  1. AO3-5555 Look for new URL in DeviantArt test (#3457)

    sarken authored and redsummernight committed Nov 5, 2018
    * AO3-5555 Look for new URL in DeviantArt test
    
    * AO3-5555 Fix spacing mistake
Commits on Nov 4, 2018
  1. Merge branch 'AO3-5551' of otw-gitsrv.transformativeworks.org:ADT/otw…

    james_
    james_ committed Nov 4, 2018
    …archive
Commits on Oct 30, 2018
  1. AO3-2046 Fix word count for Chinese, Japanese and Thai (#3432)

    yfjia authored and sarken committed Oct 30, 2018
    * AO3-2046 Correct word count for Chinese, Japanese and Thai
    
    * AO3-2046 Move character count language list to config
    
    * AO3-2046 Fix build issue
    
    * AO3-2046 Fix spec_helper
  2. AO3-5388 Drop authors_to_sort_on col (#3421)

    bjohns2 authored and sarken committed Oct 30, 2018
    * Drom authors_to_sort_on col
    
    * remove stray char
  3. AO3-5540 Altered regex in abuse_report.rb to accept alternate AO3 urls (

    alackles authored and sarken committed Oct 30, 2018
    #3446)
    
    * AO3-5540 Altered regex in abuse_report.rb to accept alternate forms of ao3 urls
    
    * Add tests for valid alternate URLs in abuse_report_spec.rb
    
    * Fix layout according to Hound
    
    * Fixed error in regex that required slash at end of url
    
    * Fixed regex to change dot to literal dot character
  4. AO3-4857 Fix anonymous creator comment message. (#3453)

    tickinginstant authored and sarken committed Oct 30, 2018
Commits on Oct 29, 2018
Commits on Oct 28, 2018
  1. AO3-4913 Increase coverage of ChallengeSignupsController (#2798)

    zz9pzza authored and redsummernight committed Oct 28, 2018
    * A first set of tests
    
    * Get open and closed signups working
    
    * Add yet more tests ( update etal )
    
    * Remove duplication
    
    * Follow english suggestions
    
    * And the one functional change
    
    * Revert "And the one functional change"
    
    This reverts commit 84ae3a6.
    
    * AO3-4913 Move gift exchange factory settings to exisiting gift exchange factory
    
    * AO3-4913 Remove new factory defaults
    
    * AO3-4913 Add factory for prompt meme signups
    
    The challenge_signup factory is in fact a gift exchange sign up factory
    
    * AO3-4913 Integrate new challenge signup controller tests with old
    
    * Move to exisiting file (and delete the newer one)
    * Make exisiting tests pass
    
    * AO3-4913 Rename and refactor variables
    
    * AO3-4913 Correct update test that was in the wrong place
    
    Context was when sign-ups are open but test was for closed sign-up.
    Now there's tests for both! Also, less repetition of parameters.
    
    * AO3-4913 Correct description of pending test
    
    * AO3-4913 More tests and a bit of tidying
    
    * AO3-4913 Alignment fixes
  2. AO3-5373 Add Dewplayer to repo (#3276)

    zz9pzza authored and sarken committed Oct 28, 2018
    * Add dewplayer
    
    * AO3-5373 Add README for Dewplayer
    
    [skip ci]
  3. Update contributing documentation (#3452)

    redsummernight authored and sarken committed Oct 28, 2018
    - Use https where possible
    - Rename "Testing" to "Testing Instructions" to be clear
    - Ask contributors to use the same name on JIRA
    
    [skip ci]
Commits on Oct 22, 2018
  1. AO3-4852 Migrate to RedirectExpectationHelper (#3429)

    sarken authored and redsummernight committed Oct 22, 2018
    * Remove unused methods
    
    * Rspec test for prompts_controller
    
    * Reset tidy up
    
    * Reset tidy up
    
    * Just the tests
    
    * use a let part one
    
    * Style...
    
    * Use let
    
    * Clean up
    
    * Clean up
    
    * Be more assertive
    
    * Try empty
    
    * Be more assertive
    
    * Add more error and notice
    
    * Add more error and notice
    
    * Missed duplicate test
    
    * Move bookmarks_controller_spec over
    
    * Move more controllers over
    
    * Move to RedirectExpectationHelper
    
    * Move to RedirectExpectationHelper
    
    * Move to RedirectExpectationHelper
    
    * Fix typo
    
    * Put old code back
    
    * Reduce line length
    
    * Fix test
    
    * Follow review
    
    * Update with new tests
    
    * Fix some errors
    
    * Fix some errors
    
    * Fix some errors :(
    
    * Restore one test and rename the bypass method
    
    * Follow sarken's review
    
    * spaces should not be significant
    
    * Update descriptions
    
    * AO3-4852 Update chapters controller to it_redirects_to_simple
    
    * AO3-4852 Use redirects_to_simple in collection participants controller spec
    
    * AO3-4852 it_redirects_to_simple for invite request and prompt controller specs
    
    * AO3-4852 Update language controller spec to check for redirect_to_with_notice
    
    * AO3-4854 Update param syntax in related work controller test
    
    * AO3-4852 it_redirects_to_simple for tag set association controller specs
    
    * AO3-4852 simple redirect check in tag set nominations controller
    
    * AO3-4852 Restore accidentally deleted line in tags controller spec
    
    * AO3-4852 Spacing tweak and phrasing tweak
    
    * AO3-4852 Update params syntax that got reverted
    
    * AO3-4852 Simplify it_redirects_to(path) helper
Commits on Oct 21, 2018
  1. AO3-5548 Move admin_post_helper_spec to the correct folder (#3447)

    redsummernight authored and sarken committed Oct 21, 2018
Commits on Oct 20, 2018
  1. AO3-5145 Fix potential nil errors on posting prompt fills (#3030)

    elzj authored and otw-deploy committed Oct 20, 2018
    * AO3-5145: Fix potential nil errors on posting when prompt description is nil
    
    * AO3-5145: Syntax change to use &
Commits on Oct 15, 2018
  1. AO3-5527 Reset invitations for purged accounts. (#3444)

    tickinginstant authored and redsummernight committed Oct 15, 2018
    * AO3-5527 Reset invitations for purged accounts.
    
    * AO3-5527 Revert test changes and add rake tests.
  2. Ignore vulnerability in nokogiri 1.8.3 (#3445)

    redsummernight authored and sarken committed Oct 15, 2018