Permalink
Tag: v0.9.236.2
Commits on Jan 28, 2019
  1. AO3-5375 bookmark search filter languages (#3346)

    DreamSea authored and sarken committed Jan 28, 2019
    * AO3-5375 add language options to bookmark search form
    
    * AO3-5375 move language option next to other work related criteria
    
    * AO3-5375 add work language option to bookmark filters
    
    * AO3-5375 bookmark search by work language rspec
    
    * AO3-5375 bookmark language search feature using languages fixture
    
    * AO3-5375 spec combining bookmarkable_search_results related "searching" context
    
    * AO3-5375 reusing bookmarks definition over all-fixtures for speed/clarity
    
    * AO3-5375 removing (outdated) @new-search from feature
Commits on Jan 27, 2019
  1. AO3-5089 Allow collections with bookmarks to be revealed (#2981)

    elzj authored and sarken committed Jan 27, 2019
    * AO3-5089: Allow collections with bookmarks to be revealed
    
    * AO3-5089: Fix collection item specs
    
    * AO3-5089: Restore change to comment text
  2. AO3-3583 Type field on bookmark search loses info on editing search (#…

    sarken authored and redsummernight committed Jan 27, 2019
    …2912)
    
    * AO3-3583 Uncomment test for bookmark type search field
    
    * AO3-3583 Make bookmark search type field remember what it's told
    
    * AO3-3583 Clean up bookmark search form partial
    
    - Add some translation strings
    
    - Fix indenting and line lenght
    
    - Use sentence case on labels (and update tests where required)
    
    * AO3-3583 Fix capitalization in test
    
    * AO3-3583 Fix capitalization change that got clobbered in merge
    
    * AO3-3583 Remove the HEAD that stuck around after conflict resolution
  3. AO3-5198 remove user-facing count on all skins (#3436)

    niconicosette authored and sarken committed Jan 27, 2019
  4. AO3-5400 Fix 500 error on admin activity show page when admin is dele…

    hatal175 authored and sarken committed Jan 27, 2019
    …ted (#3334)
    
    * AO3-5400 Use same activity admin login logic in index and show
    
    * AO3-5400 Add rspec tests for the change
    
    * AO3-5400 Change spec test to test just the helper function
  5. AO3-5574 Fix cancel button for pseud deletion (#3503)

    redsummernight authored and sarken committed Jan 27, 2019
  6. AO3-5602 Typo in TOS FAQ (#3511)

    awilson739 authored and sarken committed Jan 27, 2019
Commits on Jan 21, 2019
  1. AO3-5581 Use ScheduledReindexJob and IndexQueue in RSpec tests (#3512)

    redsummernight authored and sarken committed Jan 21, 2019
    So we don't need to delete and recreate the indices from scratch.
    
    Move search-related specs to the correct folder.
Commits on Jan 20, 2019
  1. AO3-5493 Fixes for the Elasticsearch-ification of unwrangled tags (#3509

    sarken authored and redsummernight committed Jan 20, 2019
    )
    
    * AO3-5493 Include wrangled tags in tag search results
    
    * AO3-5493 Case insensitive sorting of tags, h/t redsummernight
    
    * AO3-5493 Move unrelated tests out of file I'm about to edit and into a file they belong in
    
    * AO3-5493 Remove spare commas
    
    * AO3-5493 Revert change to indexer
    
    * AO3-5493 ReiReindex child tags on merger change
    
    * AO3-5493 Use name column for sorting by name
    
    * AO3-5493 Undo change in column used for sorting
    
    * AO3-5493 Correct test description
    
    * AO3-5493 Test unwrangled character bin
    
    * AO3-5493 Add specs for character bins and unwrangled tag sorting
    
    * AO3-5493 Sort tags by lowercased name instead of sortable_name
    
    * AO3-5493 Make reindexing and listing of characters' unwrangled relationship tags work
    
    * AO3-5493 Fix indenting
    
    * AO3-5493 Don't use instance variables in test
    
    * AO3-5493 Fix number of tags on unwrangled page
    
    * AO3-5493 Make scheduled_reindex_job model DRYer
    
    * AO3-5493 child and parent tag queries should be able to handle nil types
    
    * AO3-5493 Remove useles option from suggested_child_tags_query
    
    * AO3-5493 Get all the child tags Elasticsearch can give us
    
    * AO3-5493 Make queueing child tags asynchronous
    
    * AO3-5493 Get potential child tags for reindexing by going through the database
    
    The alternative would be using Elasticsearch's scroll to get all pages of results, but the code is
    more complex and won't necessarily perform faster. If the database method is to slow, we should
    explore that method. Details: #3509 (comment)
Commits on Jan 16, 2019
  1. AO3-5493 Reindex tags synchronously for wrangling changes (#3506)

    sarken committed Jan 16, 2019
    * AO3-5493 Skip index queue for tag changes
    
    * AO3-5493 Override enqueue_to_index in the tag model
    
    * AO3-5493 Remove added whitespace
    
    * AO3-5493 Add comment in searchable.rb
    
    * AO3-5493 Indexing no longer needs to be run in wrangling tests
    
    * AO3-5493 No longer need to run indexing before tag search test
    
    * AO3-5493 Check that IndexQueue can still call TagIndexer if we really want it to
    
    * AO3-5493 Run indexing for tag search test
    
    * AO3-5493 Put things back to how they were
    
    * AO3-5493 Reindex immediately only in certain instances
    
    * AO3-5493 Rename misleadingly named unwrangled? method to unfilterable?
    
    * AO3-5493 Make sure tags get reindexed quickly when parents update
Commits on Jan 15, 2019
  1. AO3-5600 Fix google_visualr git gem reference (#3507)

    redsummernight authored and sarken committed Jan 15, 2019
    The fork we've been using was deleted.
Commits on Jan 13, 2019
  1. AO3-5493 Allow searching for tags used only in drafts (#3504)

    redsummernight authored and sarken committed Jan 13, 2019
    * AO3-5493 Allow searching for tags used only in drafts
    
    This just sets up indexing/querying, without actually using it
    in the wrangling UI yet.
    
    Move TAGGINGS_COUNT_MIN_CACHE_COUNT to config.yml, so we don't
    need to specify a default every time. Use this property for
    the tagging reindex limit, instead of hard-coding 100.
    
    Tags are reindexed to get updated draft-only status in two ways:
    
    - When taggings are created/destroyed; this currently only applies
      to characters, relationships, and freeforms, so we need to add
      fandoms.
    - When works become posted; we need to add a reindex callback.
    
    * AO3-5493 Remove before(:all) from comment_spec
    
    This runs outside of transactions and doesn't get cleaned up
    properly by DatabaseCleaner. The leftover data breaks the new
    tag query specs.
    
    * AO3-5493 Combine tests with the same setup
    
    * AO3-5493 Use Tag::USER_DEFINED
    
    * AO3-5493 Use new config option TAGGINGS_COUNT_REINDEX_LIMIT
    
    Instead of TAGGINGS_COUNT_MIN_CACHE_COUNT, so we can adjust them
    separately.
    
    * AO3-5493 Add tagger check (everyone's doing it)
    
    * AO3-5493 Update config comment
    
    * AO3-5493 Rename draft_only to has_posted_works
    
    * AO3-5493 Rename has_posted_works to has_posted_works?
Commits on Jan 12, 2019
  1. AO3-5493 Add wrangling data to tag index (#3395)

    elzj authored and redsummernight committed Jan 12, 2019
    * First pass at moving wrangling status data to elasticsearch
    
    * AO3-5493: Fix params permitting
    
    * AO3-5493: Fix spec sorting
    
    * AO3-5493: Add hooks, update tests, fix a deprecation warning
    
    * AO3-5493: Update layout and quotes and fix redundancy
    
    * AO3-5493 Test unwrangled tags on wrangling pages
    
    * AO3-5493 Add test for unwrangleable tags
    
    * AO3-5493 Add unwrangleable to fields indexed
    
    * AO3-5493 Fix step in test
    
    * AO3-5493 Update test again
    
    * AO3-5493 Update link text/charcater tag count in test
    
    * AO3-5493 Update unwrangelable term query
    
    * AO3-5394 Try reindexing tags before going to wrangling page
    
    * AO3-5493 Fix test that was failing because I was wrong about desired behavior~
    
    * AO3-5493 Try reindexing tags after editing
    
    * AO3-5493 Fix indexing job running
    
    * Use exists query instead of dummy values.
    
    * Rename exclusion filter for wrangled tags
    
    * Make suggested parents distinct
Commits on Jan 10, 2019
  1. AO3-5533 & AO3-5544 Don't use after_commit for update_anon_unrevealed. (

    tickinginstant authored and sarken committed Jan 10, 2019
    #3478)
    
    * AO3-5533 & AO3-5544 Don't use after_commit.
    
    Using after_commit for the anonymous/unrevealed updates means that any
    changes to the CollectionItem that were just written to the database
    might not be available to read. So after_save/after_destroy is
    preferred, but requires a number of other changes to ensure the correct
    behavior.
    
    * AO3-5206 Test for collection juggling.
    
    * AO3-5533 & AO3-5544 Tests: no message content.
Commits on Jan 5, 2019
  1. AO3-5584 Make removal come last. (#3500)

    tickinginstant authored and redsummernight committed Jan 5, 2019
Commits on Dec 31, 2018
  1. AO3-4310 Translate invite request decline email (#3245)

    cesy authored and zz9pzza committed Dec 31, 2018
    * AO3-4310 Test for invite request decline email
    
    * Making Hound happy
    
    * AO3-4310 review comments
  2. AO3-1305 Fix word count in work preview (#3349)

    hatal175 authored and zz9pzza committed Dec 31, 2018
  3. AO3-5584 CollectionItemsController permissions. (#3486)

    tickinginstant authored and zz9pzza committed Dec 31, 2018
    * AO3-5584 CollectionItemsController permissions.
    
    * AO3-5584 Improve style for Hound.
    
    * AO3-5584 Split update_multiple.
    
    * AO3-5584 Try to reduce complexity.
    
    * AO3-5584 Switch to where for fewer DB queries.
    
    * AO3-5584 Use CollectionItem::REJECTED (suggested by redsummernight)
  4. AO3-5580 Fix nil error in SerialWork callback. (#3483)

    tickinginstant authored and zz9pzza committed Dec 31, 2018
  5. AO3-5494: Rescue search errors and respond with error message (#3396)

    elzj authored and zz9pzza committed Dec 31, 2018
Commits on Dec 29, 2018
  1. AO3-5579 Update bullet to 5.9.0 (#3499)

    redsummernight authored and sarken committed Dec 29, 2018
    The gem bullet needs to be >= 5.7.3 to be compatible with
    Active Record 5.1.5 or later.
Commits on Dec 28, 2018
  1. AO3-5579 Update Rails from 5.1.3 to 5.1.6.1 (#3481)

    redsummernight authored and sarken committed Dec 28, 2018
    * [Security] Bump rails from 5.1.3 to 5.1.6.1
    
    Bumps [rails](https://github.com/rails/rails) from 5.1.3 to 5.1.6.1. **This update includes security fixes.**
    - [Release notes](https://github.com/rails/rails/releases)
    - [Commits](rails/rails@v5.1.3...v5.1.6.1)
    
    Signed-off-by: dependabot[bot] <support@dependabot.com>
    
    * AO3-5579 Update capybara to 2.16.1
    
    Since we bumped rack-test to 1.1.0, we need capybara 2.16.1 which
    is compatible with rack-test 0.7.1 and later.
  2. AO3-5313 Set Auth Error page title correctly (#3350)

    hatal175 authored and sarken committed Dec 28, 2018
    * AO3-5313 Set Auth Error page title correctly
    
    * AO3-5313 use page_subtitle instead of page_title
  3. AO3-5438 fix typo in prompter_notification.html.erb that added extra …

    alackles authored and sarken committed Dec 28, 2018
    …%> to email (#3451)
Commits on Dec 27, 2018
  1. AO3-5589 Add password_check to unsanitized fields (#3498)

    sarken authored and redsummernight committed Dec 27, 2018
  2. AO3-5590 Fix comment on login lookup (#3497)

    redsummernight authored and sarken committed Dec 27, 2018
    [skip ci]
  3. AO3-5590 Fix performance regression in case-insensitive username look…

    zz9pzza authored and sarken committed Dec 27, 2018
    …ups (#3496)
    
    * Fix performance regression
    
    * Fix comment
  4. AO3-5589 Fix certain passwords (#3495)

    sarken authored and zz9pzza committed Dec 27, 2018
    * AO3-5589 Don't sanitize password and password confirmation field because they're encrypted and it breaks brackets
    
    * AO3-5589 Make fields that don't get sanitization configurable
    
    * AO3-5589 Remove unnecessary conversion to string
Commits on Dec 25, 2018
  1. AO3-5576 Remove outdated footnote on change email page (#3494)

    sarken authored and redsummernight committed Dec 25, 2018
  2. AO3-5587 Add unique index to user emails (#3493)

    redsummernight authored and sarken committed Dec 25, 2018
Commits on Dec 24, 2018
  1. AO3-5588 ao3-app04 returning to the fold (#3492)

    zz9pzza authored and sarken committed Dec 24, 2018
  2. AO3-2839 AO3-5576 Update login forms, password reset emails, and pass…

    redsummernight authored and sarken committed Dec 24, 2018
    …word change notice (#3491)
    
    * AO3-2839 Fix I18n typo in EmailFormatValidator
    
    * AO3-5576 Style link in reset password instructions HTML email
    
    * AO3-5576 Update reset password instructions email subject
    
    * AO3-2839 Update notice after users change password
    
    Mention that users are logged out. This is different from changing
    passwords using a reset ("Forgot password?").
    
    * AO3-2839 Update login forms to use "User name or email:"
    
    * AO3-5576 Update tests to remove mentions of temporary passwords
Commits on Dec 22, 2018
  1. AO3-2839 Add unique index to Devise token columns (#3490)

    redsummernight authored and sarken committed Dec 22, 2018
    * AO3-2839 Add unique index to reset_password_token and unlock_token
    
    * AO3-2839 Add unique index to confirmation_token
  2. AO3-5576 Use Devise::Recoverable. (#3489)

    tickinginstant authored and sarken committed Dec 22, 2018
    * AO3-5576 Use Recoverable to handle lost passwords.
    
    * AO3-5576 Test fixes.
    
    * AO3-5576 Email links don't use a different host.
    
    Email links in the tests used to use a different host, which resulted in
    sessions being "lost" because the user was visiting a different path
    (and therefore had their cookies stored elsewhere). Now it's all the
    same host, so the test can be slightly simplified.
    
    * AO3-5576 Remove unreachable form on wrong password.
    
    * AO3-5576 ArchiveConfig for reset_password_within.
    
    * AO3-5576 Remove recently_reset.
Commits on Dec 20, 2018
  1. AO3-5586 Add unicorn server ao3-app12 (#3488)

    zz9pzza authored and redsummernight committed Dec 20, 2018