Skip to content
Permalink
Tag: v0.9.252.1
Commits on Aug 13, 2019
  1. AO3-5480 Switch to Zoho Desk REST API for Support and Abuse forms (#3605

    CristinaRO authored and sarken committed Aug 13, 2019
    )
    
    * (fix) Typo in regex
    
    The typo meant we were too lenient with some blank spaces, but removing any incidental `s` after the starting paragraph mark.
    
    * (chore) Implement mini Zoho clients
    
    A client for authorisation and one for the "resources", since this is how Zoho separate their concepts (different servers, endpoints etc).
    
    * (chore) Feedback reporters use the new Zoho API
    
    * Doh
    
    Thanks, Github Desktop, I hate it.
    
    * Update default config.yml
    
    * Fix Hound comments
    
    * Move specs
    
    * Delete templates
    
    * Use ArchiveConfig to allow stubbing
    
    * Add ArchiveConfig.ZOHO_REDIRECT_URI
    
    * Encode query parameters of Zoho GET requests
    
    * Add comments for new Zoho config keys
    
    * Fall back on Language.default
    
    * Fix Hound comments on specs
    
    * Don't need both `query:` and `.to_query`.
    
    * Fix broken specs.
    
    * Cache the access token.
    
    * (chore) Obey the Hound and the sarken
    
    The double quotes were sarken's request, all the rest was Hound's hounding.
    
    * (fix) Indentation
    
    * Make contact resilient to name changes
    
    The `lastName` field is required by Zoho. It's the only required field for a contact, in fact.
    
    As we, of course, don't ask for people's last names, we are content to use the email, because that's the field that *we* require so we know it's going to be present.
    
    Furthermore, we don't want to store the name (which is *not* necessarily the username for a logged in Archive user) with the contact, because people might be giving different names for different tickets.
    
    We will introduce a custom name field for the ticket in the near future.
    
    * Use a custom field `Name` for ticket-level names
    
    Users might enter different names, or no names, for tickets they send with the same email address.
    
    The email address is the unique identifier for a contact, so we don't want to rely on Zoho's automated lookup of the `contactName`.
    
    Instead, we want to give the user the chance to tell us what name they want to be used in association with this specific ticket.
    
    * Zoho new custom fields format
    
    A very recent change! `customFields` is now deprecated, replaced with the much clearer and self-explanatory `cf`.</sarcasm>
    
    Also, the custom fields themselves must be sent as `cf_snake_case_name`, even though in the interface you can only give the display name. They automatically compute the snake case form from the display name, so `Archive Version` becomes `cf_archive_version` and so on.
    
    * AO3-5480 Change email veracity check to format check
    
    We don't want to allow email addresses with asterisks because Zoho doesn't let contacts have emails like that.
    
    * AO3-5480 Update support and abuse form tests to check for proper error message
Commits on Aug 8, 2019
  1. AO3-4592 Fix task to reveal stuck anonymous/unrevealed works (#3604)

    zz9pzza authored and sarken committed Aug 8, 2019
    * First draft
    
    * Follow review
    
    * White space
    
    * task needs to use the enviroment
    
    * 100% less syntax errors
    
    * Add tests
    
    * Whitespace
    
    * Spacing and removing extra line of code that wasn't wanted
    
    * Add more tests and whitespace
    
    * whitespace
    
    * Add some newlines
    
    * lowercase w
    
    * Follow sarken's comment
    
    * Fix style, reuse relation, flush stdout, order tests consistently
Commits on Aug 3, 2019
  1. AO3-4159 Fix formatting for user last login information (#3603)

    zz9pzza authored and sarken committed Aug 3, 2019
    * Refactor to use Devise
    
    * Fix variable name
    
    * Fix steps
    
    * Fix steps
    
    * Follow review
    
    * Spacing
    
    * Follow review
    
    * Follow review
    
    * Missed a timeago
    
    * Revert as much as possible
    
    * follow review, change all ts to use double quotes
    
    * Follow comments from staging
    
    * Follow review
    
    * Fix tests
Commits on Aug 2, 2019
  1. AO3-5720 Modify the rules of CollectionItem#approve_automatically. (#…

    tickinginstant authored and sarken committed Aug 2, 2019
Commits on Aug 1, 2019
  1. AO3-4159 Add last login information to admin user display (#3545)

    zz9pzza authored and sarken committed Aug 1, 2019
    * Refactor to use Devise
    
    * Fix variable name
    
    * Fix steps
    
    * Fix steps
    
    * Follow review
    
    * Spacing
    
    * Follow review
    
    * Follow review
    
    * Missed a timeago
    
    * Revert as much as possible
    
    * follow review, change all ts to use double quotes
  2. AO3-4592 Un-hide works affected by anon/unrevealed collection invitat…

    zz9pzza authored and sarken committed Aug 1, 2019
    …ion bug (#2484)
    
    * First draft
    
    * Follow review
    
    * White space
  3. AO3-5691 Fix error message when editing a work's publication date to …

    redsummernight authored and zz9pzza committed Aug 1, 2019
    …the future (#3597)
    
    Avoid the "translation missing" error.
  4. AO3-5039 Prevent non canonical tags from being favorited (#2936)

    sarken authored and zz9pzza committed Aug 1, 2019
    * AO3-5039 Validate canonical-ness of tag before adding to favorite tags
    
    * AO3-5039 Put the methods for the validations by the validations, and use double quotes consistently
    
    * AO3-5039 Tests for favorite tags
    
    * AO3-5039 Fixes for favorite tag validations based on test failures
    
    * AO3-5039 Style fixes
    
    * AO3-5039 Update tests to use correct ccanonical status for tags
    
    * AO3-5039 Use valid? instead of saving in favorite tag spec
Commits on Jul 20, 2019
  1. AO3-5689 Fix sorting stats by descending date (#3594)

    zz9pzza authored and redsummernight committed Jul 20, 2019
    * Fix brakeman eval issues
    
    * Fix typo
    
    * Replace hash with case
    
    * Missed an end
    
    * Follow review
    
    * elsif is not intuitive, when the conditions are mutually exclusive
    
    * Follow review
    
    * Fix comparision
    
    * just a step to the right
    
    * follow hound comments
    
    * Follow review
    
    * Follow review
    
    * Follow reivew
Commits on Jul 19, 2019
  1. Skip DeviantArt importing tests (#3593)

    redsummernight authored and bingeling committed Jul 19, 2019
Commits on Jul 17, 2019
  1. AO3-5689 Refactor code to avoid use of eval (#3577)

    zz9pzza authored and sarken committed Jul 17, 2019
    * Fix brakeman eval issues
    
    * Fix typo
    
    * Replace hash with case
    
    * Missed an end
    
    * Follow review
    
    * elsif is not intuitive, when the conditions are mutually exclusive
    
    * Follow review
    
    * Fix comparision
  2. AO3-5682 Refactor code that uses send (#3578)

    zz9pzza authored and sarken committed Jul 17, 2019
Commits on Jul 16, 2019
  1. AO3-5678 Fix Brakeman warnings for SQL injection (#3575)

    zz9pzza authored and sarken committed Jul 16, 2019
    * Work on SQL issues
    
    * Most refactoring
    
    * Fix test and hound
    
    * Fix other mistakes
    
    * Move code from view
    
    * Hopefully last bits
    
    * Fix typo
    
    * Follow review
    
    * Follow review
    
    * Listen to hound and brakeman
    
    * Fix test
    
    * fix test
    
    * Follow review
    
    * Rename reorder
    
    * Missing bit
    
    * Prefer case
    
    * fix ,
Commits on Jul 6, 2019
  1. AO3-5549 Handle deleted users in spam alert. (#3591)

    tickinginstant authored and zz9pzza committed Jul 6, 2019
    * AO3-5549 Handle deleted users in spam alert.
    
    * AO3-5549 Some style fixes for Hound.
    
    * AO3-5549 Eschew BulletproofMailer.
Commits on Jul 1, 2019
Commits on Jun 26, 2019
  1. AO3-5099 & AO3-5126 Separate "Name or email" query into two fields, a…

    tickinginstant authored and sarken committed Jun 26, 2019
    …nd fix the results count. (#3586)
    
    * AO3-5099 Split user query into name and email.
    
    * AO3-5099 Capitalization of "Search settings."
    
    * AO3-5126 Use distinct scope instead of select.
    
    * AO3-5099 Fix up "I make x an archivist" step.
    
    * AO3-5099 More cucumber test fixes.
Commits on Jun 19, 2019
  1. AO3-3953 Expire caches of work blurbs, metas, and links on tag pages (#…

    redsummernight authored and sarken committed Jun 19, 2019
  2. AO3-5697 Add unique index to meta_taggings table. (#3585)

    tickinginstant authored and sarken committed Jun 19, 2019
    For pt-online-schema-change, the argument to --alter corresponding to
    this migration is:
    
      ADD UNIQUE INDEX
        index_meta_taggings_on_meta_tag_id_and_sub_tag_id
        (meta_tag_id, sub_tag_id),
      DROP INDEX
        index_meta_taggings_on_meta_tag_id
    
    The argument --nocheck-unique-key-change may also be necessary, since
    pt-online-schema-change tries to ensure that data will not be lost when
    adding a new unique index.
Commits on Jun 8, 2019
  1. AO3-5699 Pass works instead of whole response to claim notification m…

    ariana-paris authored and sarken committed Jun 8, 2019
    …ethod (#3582)
    
    * AO3-5699 Pass works instead of whole response to claim notification method
    
    * AO3-5699 Fix mock imports in API specs to ensure test isolation
Commits on Jun 1, 2019
  1. AO3-3953 Remove collection-scoped tag links (#3454)

    redsummernight authored and sarken committed Jun 1, 2019
    Links to tag pages (showing meta tags, sub tags, etc.) should never
    be collection-scoped.
    
    Links to tag work listings should be collection-scoped only in
    two places:
    
    - collections/COLLECTIONNAME/tags
    - collections/COLLECTIONNAME/fandoms
  2. AO3-5099 Add option for exact string match for admin user search (#3141)

    hatal175 authored and sarken committed Jun 1, 2019
    * AO3-5099 Add option for exact string match for admin user search
    
    * AO3-5099 hound fixes
    
    * AO3-5099 codeclimate fix
    
    * AO3-5099 hound fixes #2
  3. AO3-5097 admin users refactoring (#2986)

    elzj authored and sarken committed Jun 1, 2019
    * AO3-5097: Refactor admin users controller
    
    * AO3-5097: Update comment and remove a dash of randomness
    
    * AO3-5097: Syntax tweaks
    
    * AO3-5097: A few additional tweaks
Commits on May 31, 2019
  1. AO3-5695 Update newrelic_rpm, drop unused newrelic-redis gem (#3581)

    zz9pzza authored and sarken committed May 31, 2019
    * Update new relic agent, drop redis agent as no longer used
    
    * Commit Gemfile
Commits on May 30, 2019
  1. AO3-5694 Don't load fandoms list on orphan_account user dashboard (#3580

    sarken authored and zz9pzza committed May 30, 2019
    )
    
    * AO3-5694 Don't load fandoms list on orphan_account user dashboard
    
    * AO3-5694 Spacing changes
Commits on May 26, 2019
  1. AO3-2452 Fix deletion tasks and add tests. (#3579)

    tickinginstant authored and sarken committed May 26, 2019
Commits on May 25, 2019
  1. AO3-2452 Add checks to CommonTaggings to prevent invalid tag associat…

    tickinginstant authored and sarken committed May 25, 2019
    …ions. (#3094)
    
    * AO3-2452 Add validations to CommonTaggings.
    
    * AO3-2452 Task for deleting invalid CommonTaggings.
    
    * AO3-2452 Hide "Wrangle to Fandom" for mergers/subs.
    
    * AO3-2452 Fix tag attribute_was deprecation warning.
    
    * AO3-2452 Make existing tests expect error messages.
    
    * AO3-2452 Add RSpec tests for associations.
    
    * AO3-2452 Some rubocop fixes.
    
    * AO3-2452 More detailed printouts in tag tasks.
    
    * AO3-2452 Cut back on meta-tagging changes.
    
    * AO3-2452 Change == 0 to .zero?
    
    * AO3-2452 Make the parent canonical in factories.
    
    * AO3-2452 Comment to help locate *_string method defs.
    
    Co-Authored-By: tickinginstant <tickinginstant@gmail.com>
    
    * AO3-2452 Spacing for Hound.
    
    * AO3-2452 Drop the "should" from test names.
    
    * AO3-2452 Avoid render_views in tests.
    
    * AO3-2452 Stop skipping the uniqueness check.
    
    The uniqueness check isn't enforced on a database level, so we shouldn't
    skip it when deleting invalid CommonTaggings/MetaTaggings.
    
    * AO3-2452 sub_tagging, not meta_tagging
    
    * AO3-2452 Reduce duplication.
Commits on May 13, 2019
  1. AO3-5687 Install Brakeman Gem and ignore all current Brakeman warnings (

    zz9pzza authored and sarken committed May 13, 2019
Commits on May 5, 2019
  1. AO3-5664 Remove API v1 routes (#3572)

    ariana-paris authored and redsummernight committed May 5, 2019
Commits on Apr 24, 2019
  1. AO3-5180 Better word breaking for mobile headings (#3563)

    sarken authored and redsummernight committed Apr 24, 2019
  2. AO3-5656 Fix downloading works with nil summary (#3564)

    lethnie authored and redsummernight committed Apr 24, 2019
  3. AO3-5664 Remove v1 API (#3565)

    ariana-paris authored and redsummernight committed Apr 24, 2019
  4. AO3-5572 Make API messages an array rather than a string (#3552)

    ariana-paris authored and redsummernight committed Apr 24, 2019
    * AO3-5572 - Make API message an array instead of a string for imported works
    
    * AO3-5572 Update tests
    
    * AO3-5572 Add test to check that the message is an array
    
    * AO3-5572 Remove debug log messages
    
    * AO3-5572 Use the return of the conditional for variable assignment
    
    * AO3-5572 Use reject instead of inverting select
  5. AO3-5245 Update Open Doors rake task to use AO3 ids to find works (#3551

    ariana-paris authored and redsummernight committed Apr 24, 2019
    )
    
    * AO3-5245 Update Open Doors rake task to use AO3 ids to find works
    
    * AO3-5245 Test that Rake task processes CSV files correctly
    
    * AO3-5245 Remove Before and After and add a file fixture
  6. AO3-5674 Bump nokogiri from 1.10.1 to 1.10.3 (#3569)

    dependabot authored and redsummernight committed Apr 24, 2019
    Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.1 to 1.10.3. **This update includes security fixes.**
    - [Release notes](https://github.com/sparklemotion/nokogiri/releases)
    - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
    - [Commits](sparklemotion/nokogiri@v1.10.1...v1.10.3)
    
    Signed-off-by: dependabot[bot] <support@dependabot.com>
Older
You can’t perform that action at this time.