Skip to content
Permalink
Tag: v0.9.253.9
Commits on Sep 5, 2019
  1. AO3-5753 Increase maximum comment length (#3624)

    zz9pzza authored and sarken committed Sep 5, 2019
    * The actual changed of the amount
    
    * The contravershal bit
    
    * Make the display 10000
    
    * Revert "Make the display 10000"
    
    This reverts commit 149e8b7.
    
    * Revert "The contravershal bit"
    
    This reverts commit c8f7632.
Commits on Sep 4, 2019
  1. AO3-5658 Update co-creator notification text (#3623)

    sarken authored and zz9pzza committed Sep 4, 2019
    * AO3-5658 Update co-creator notification text
    
    * AO3-5658 Look for new text in test
    
    * AO3-5658 Don't look for portion of test with apostrophe because test will fail
Commits on Sep 2, 2019
  1. AO3-5658 AO3-5751 Make the ability to view drafts more consistent, an…

    tickinginstant authored and sarken committed Sep 2, 2019
    …d add admin access to the user drafts page. (#3622)
    
    * AO3-5658 Fix up draft visibility checks.
    
    * AO3-5751 Let admins see the list of drafts.
    
    * AO3-5658 Fix up unrevealed check for chapters.
    
    * AO3-5658 Some clean-up for Hound.
    
    * AO3-5658 Remove hide_work_info assignment.
Commits on Sep 1, 2019
  1. AO3-5334 Update confirmation prompt when removing self from series (#…

    sarken authored and redsummernight committed Sep 1, 2019
Commits on Aug 31, 2019
  1. AO3-5334 Rename "Remove Me As Author" to "Remove Me As Co-Creator" (#…

    sarken authored and redsummernight committed Aug 31, 2019
    …3619)
    
    * AO3-5334 Rename Remove Author to Remove Co-Creator on Edit Work page
    
    * Revert "AO3-5334 Rename Remove Author to Remove Co-Creator on Edit Work page"
    
    This reverts commit 1fe3bb7.
    
    * AO3-5334 Rename 'Remove Author' to 'Remove Co-Creator' on Edit Work page
    
    * AO3-5334 Rename 'Remove Author' to 'Remove Co-Creator' on series navigation
    
    * AO3-5334 Update tests to look for new text
    
    * AO3-5334 Update capitalization on co-creator removal for mass editing
    
    * AO3-5334 Update messages when removing creators from works and series
    
    * AO3-5334 Update text in spec to look for 'creator'
    
    * AO3-5334 Update spacing and quotes on a line I touched
  2. AO3-5658 Remove sentence from privacy help pop-up (#3616)

    sarken authored and zz9pzza committed Aug 31, 2019
Commits on Aug 28, 2019
  1. AO3-5658 Co-creator email changes and front end tweaks (#3612)

    sarken authored and redsummernight committed Aug 28, 2019
    * AO3-5658 Update creator-related bits on edit multiple form
    
    * Button-styling to make Remove option easier to see and click
    * Only display Remove option when usable
    * Only display pseud selection list when relevant
    
    * AO3-5658 Put co-creator checkboxes in fieldsets on work form
    
    * AO3-5658 Add new preference to help file
    
    * AO3-5658 Update co-creator email text
    
    * AO3-5658 Make sure archivist co-creator email uses wrong subject
    
    * AO3-5658 Fix incorrect interpolation argument
    
    * AO3-5658 Use the right key
    
    * AO3-5658 Update test to look for new email text
    
    * AO3-5658 Adjust co-creator section of mass edit form
    
    * Fix capitalization on remove button
    * Get rid of superflous code for disabling remove button
    
    * AO3-5658 Correct privacy pref help text
    
    * AO3-5658 Make edit multiple test look for new capitalization
    
    * AO3-5658 Correct it again
Commits on Aug 20, 2019
  1. AO3-5658 Don't escape error messages on the Edit Multiple Works page,…

    tickinginstant authored and redsummernight committed Aug 20, 2019
    … and make the invalid tag error message appear. (#3611)
    
    * Don't escape error messages for update_multiple.
    
    * Fix handling of invalid tags.
Commits on Aug 17, 2019
  1. AO3-5658 Add creator invitations, and a preference option to disable …

    tickinginstant authored and sarken committed Aug 17, 2019
    …them. (#3596)
    
    * First step to co creator banning
    
    * Clean up code
    
    * Clean up code
    
    * Make the removal of people optional
    
    * More work getting orignal tests working
    
    * Fix the tests
    
    * More test
    
    * Fix tests before breaking it all
    
    * Minimal spec
    
    * Another day looking at tests
    
    * Save preferences
    
    * Testing
    
    * Hack in place to help with tests
    
    * More fixing tests
    
    * More test
    
    * Need a full test run
    
    * Time for another rerun
    
    * Fix - _
    
    * MOre test runs
    
    * Fixing last test ?
    
    * Clean up
    
    * Migrate to class method in Psued
    
    * fix typo
    
    * Add a co author test
    
    * Add additional tests
    
    * consistent co-creator
    
    * Add support for chapters
    
    * Admins can save works
    
    * revert allow admins all the things
    
    * More chapter work
    
    * Try more common code
    
    * Start series
    
    * Add series support, brake Works
    
    * Find bug with author attributes
    
    * Revert earlier change
    
    * Fix Ao3-5083
    
    * Fix specs
    
    * External works do not have pseuds
    
    * We redirect to edit rather than rendering the template
    
    * Work on error
    
    * Hidden fields and other evil things
    
    * Final bit before pushing on to chapters
    
    * Use common set_author_attributes
    
    * move common bits to load_pseuds
    
    * Put readme back
    
    * Whitespace
    
    * Fix https://otwarchive.atlassian.net/browse/AO3-5662
    
    * Update app/views/works/_hidden_fields.html.erb
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update spec/models/series_spec.rb
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/bookmark_indexing.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/bookmark_indexing.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update spec/models/series_spec.rb
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/series.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/series.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/series.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/prompt_memes_b/challenge_promptmeme_posting_fills.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/series.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_create.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_create.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_create.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_create.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * First pass though review
    
    * More reviews
    
    * More reviews
    
    * undefined method before_save for CreatorshipValidations:Module
    
    * Do it the right way round
    
    * Try and fix concerns, whitespace
    
    * Use before save as is intended
    
    * Add defaults
    
    * Refactor list of isse psueds
    
    * Don't always abort
    
    * Back to original code
    
    * Fix tests
    
    * Fix syntax
    
    * Apply suggestions from code review
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Whitespace
    
    * More hound suggestions
    
    * Fix issue
    
    * Hopefully make this better (following sarken's comment)
    
    * More whitespace and hound
    
    * Whitespace
    
    * Add priority overrides
    
    * missed a puts
    
    * Listen to the hound
    
    * Fix nil issues
    
    * Refactor check to be instance method, disallow admins from making co-creators
    
    * WIP
    
    * Fix up specs and clean up code.
    
    * Numerous fixes for cucumber tests.
    
    * Continue fixing up tests, and some minor fixes.
    
    * Fix up a few automated tests (+ whitespace).
    
    * Switch to approval_status (1, 0, -1).
    
    * Fix up Edit Multiple Works spec.
    
    * Bring over some parse_bylines changes from zz9pzza.
    
    * Fix up some deletion behavior, plus page titles.
    
    * Start work on suggested changes.
    
    - Change description of preference option.
    
    - Remove "Accept Co-Creator Invitation" button and replace with a flash
    notice at the top of the work/chapter/series.
    
    - Move "Creator Invitations" link further down the user sidebar.
    
    * Fix up cucumber tests.
    
    * Remove unused Creatorships#accept action.
    
    * Make unrevealed works visible to invited creators.
    
    * Handle series better if posting a new work fails.
    
    * More cucumber fixes.
    
    * Revert back to boolean for approval status.
    
    * Fix up editing multiple works.
    
    * Assorted style changes.
    
    * Temporary fix for the email text.
    
    * Handle pseud deletion better.
    
    * Orphan works in AdminMailer test.
    
    * Change "Delete" to "Reject."
    
    * Move the will_paginate blocks outside the if.
    
    * Remove outdated comment.
    
    * Destroy empty series when deleting account.
    
    * Add transaction around change_ownership.
    
    * Remove admin access to creatorships page.
    
    * Handle creatorships will null pseuds better.
    
    * Don't use "Post Without Preview" for new tests.
    
    * Add tasks for cleaning up creatorships.
    
    * Add more info to creator notification email.
    
    * Remove unused method that called authors.
    
    * New test for editing multiple works.
    
    * Assorted fixes for Hound.
    
    * More changes for Hound.
    
    * Disable notifications on Work#remove_author.
    
    * Add custom message for archivists.
    
    * Start following redsummernight's review.
    
    * Start following Sarken's review.
    
    * Add archivist tests and flip notification default.
    
    * Fix up broken join in creatorship deletion task.
    
    * Follow more of redsummernight's review.
    
    * More review comments.
    
    * Fix up new test.
    
    * Another test fix.
    
    * Change error message, comment, associations.
    
    * Fix minor typos
  2. AO3-5729 [Security] Bump nokogiri from 1.10.3 to 1.10.4 (#3608)

    dependabot-preview authored and sarken committed Aug 17, 2019
    Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.3 to 1.10.4. **This update includes a security fix.**
    - [Release notes](https://github.com/sparklemotion/nokogiri/releases)
    - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
    - [Commits](sparklemotion/nokogiri@v1.10.3...v1.10.4)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Commits on Aug 13, 2019
  1. AO3-5480 Switch to Zoho Desk REST API for Support and Abuse forms (#3605

    CristinaRO authored and sarken committed Aug 13, 2019
    )
    
    * (fix) Typo in regex
    
    The typo meant we were too lenient with some blank spaces, but removing any incidental `s` after the starting paragraph mark.
    
    * (chore) Implement mini Zoho clients
    
    A client for authorisation and one for the "resources", since this is how Zoho separate their concepts (different servers, endpoints etc).
    
    * (chore) Feedback reporters use the new Zoho API
    
    * Doh
    
    Thanks, Github Desktop, I hate it.
    
    * Update default config.yml
    
    * Fix Hound comments
    
    * Move specs
    
    * Delete templates
    
    * Use ArchiveConfig to allow stubbing
    
    * Add ArchiveConfig.ZOHO_REDIRECT_URI
    
    * Encode query parameters of Zoho GET requests
    
    * Add comments for new Zoho config keys
    
    * Fall back on Language.default
    
    * Fix Hound comments on specs
    
    * Don't need both `query:` and `.to_query`.
    
    * Fix broken specs.
    
    * Cache the access token.
    
    * (chore) Obey the Hound and the sarken
    
    The double quotes were sarken's request, all the rest was Hound's hounding.
    
    * (fix) Indentation
    
    * Make contact resilient to name changes
    
    The `lastName` field is required by Zoho. It's the only required field for a contact, in fact.
    
    As we, of course, don't ask for people's last names, we are content to use the email, because that's the field that *we* require so we know it's going to be present.
    
    Furthermore, we don't want to store the name (which is *not* necessarily the username for a logged in Archive user) with the contact, because people might be giving different names for different tickets.
    
    We will introduce a custom name field for the ticket in the near future.
    
    * Use a custom field `Name` for ticket-level names
    
    Users might enter different names, or no names, for tickets they send with the same email address.
    
    The email address is the unique identifier for a contact, so we don't want to rely on Zoho's automated lookup of the `contactName`.
    
    Instead, we want to give the user the chance to tell us what name they want to be used in association with this specific ticket.
    
    * Zoho new custom fields format
    
    A very recent change! `customFields` is now deprecated, replaced with the much clearer and self-explanatory `cf`.</sarcasm>
    
    Also, the custom fields themselves must be sent as `cf_snake_case_name`, even though in the interface you can only give the display name. They automatically compute the snake case form from the display name, so `Archive Version` becomes `cf_archive_version` and so on.
    
    * AO3-5480 Change email veracity check to format check
    
    We don't want to allow email addresses with asterisks because Zoho doesn't let contacts have emails like that.
    
    * AO3-5480 Update support and abuse form tests to check for proper error message
Commits on Aug 8, 2019
  1. AO3-4592 Fix task to reveal stuck anonymous/unrevealed works (#3604)

    zz9pzza authored and sarken committed Aug 8, 2019
    * First draft
    
    * Follow review
    
    * White space
    
    * task needs to use the enviroment
    
    * 100% less syntax errors
    
    * Add tests
    
    * Whitespace
    
    * Spacing and removing extra line of code that wasn't wanted
    
    * Add more tests and whitespace
    
    * whitespace
    
    * Add some newlines
    
    * lowercase w
    
    * Follow sarken's comment
    
    * Fix style, reuse relation, flush stdout, order tests consistently
Commits on Aug 3, 2019
  1. AO3-4159 Fix formatting for user last login information (#3603)

    zz9pzza authored and sarken committed Aug 3, 2019
    * Refactor to use Devise
    
    * Fix variable name
    
    * Fix steps
    
    * Fix steps
    
    * Follow review
    
    * Spacing
    
    * Follow review
    
    * Follow review
    
    * Missed a timeago
    
    * Revert as much as possible
    
    * follow review, change all ts to use double quotes
    
    * Follow comments from staging
    
    * Follow review
    
    * Fix tests
Commits on Aug 2, 2019
  1. AO3-5720 Modify the rules of CollectionItem#approve_automatically. (#…

    tickinginstant authored and sarken committed Aug 2, 2019
Commits on Aug 1, 2019
  1. AO3-4159 Add last login information to admin user display (#3545)

    zz9pzza authored and sarken committed Aug 1, 2019
    * Refactor to use Devise
    
    * Fix variable name
    
    * Fix steps
    
    * Fix steps
    
    * Follow review
    
    * Spacing
    
    * Follow review
    
    * Follow review
    
    * Missed a timeago
    
    * Revert as much as possible
    
    * follow review, change all ts to use double quotes
  2. AO3-4592 Un-hide works affected by anon/unrevealed collection invitat…

    zz9pzza authored and sarken committed Aug 1, 2019
    …ion bug (#2484)
    
    * First draft
    
    * Follow review
    
    * White space
  3. AO3-5691 Fix error message when editing a work's publication date to …

    redsummernight authored and zz9pzza committed Aug 1, 2019
    …the future (#3597)
    
    Avoid the "translation missing" error.
  4. AO3-5039 Prevent non canonical tags from being favorited (#2936)

    sarken authored and zz9pzza committed Aug 1, 2019
    * AO3-5039 Validate canonical-ness of tag before adding to favorite tags
    
    * AO3-5039 Put the methods for the validations by the validations, and use double quotes consistently
    
    * AO3-5039 Tests for favorite tags
    
    * AO3-5039 Fixes for favorite tag validations based on test failures
    
    * AO3-5039 Style fixes
    
    * AO3-5039 Update tests to use correct ccanonical status for tags
    
    * AO3-5039 Use valid? instead of saving in favorite tag spec
Commits on Jul 20, 2019
  1. AO3-5689 Fix sorting stats by descending date (#3594)

    zz9pzza authored and redsummernight committed Jul 20, 2019
    * Fix brakeman eval issues
    
    * Fix typo
    
    * Replace hash with case
    
    * Missed an end
    
    * Follow review
    
    * elsif is not intuitive, when the conditions are mutually exclusive
    
    * Follow review
    
    * Fix comparision
    
    * just a step to the right
    
    * follow hound comments
    
    * Follow review
    
    * Follow review
    
    * Follow reivew
Commits on Jul 19, 2019
  1. Skip DeviantArt importing tests (#3593)

    redsummernight authored and bingeling committed Jul 19, 2019
Commits on Jul 17, 2019
  1. AO3-5689 Refactor code to avoid use of eval (#3577)

    zz9pzza authored and sarken committed Jul 17, 2019
    * Fix brakeman eval issues
    
    * Fix typo
    
    * Replace hash with case
    
    * Missed an end
    
    * Follow review
    
    * elsif is not intuitive, when the conditions are mutually exclusive
    
    * Follow review
    
    * Fix comparision
  2. AO3-5682 Refactor code that uses send (#3578)

    zz9pzza authored and sarken committed Jul 17, 2019
Commits on Jul 16, 2019
  1. AO3-5678 Fix Brakeman warnings for SQL injection (#3575)

    zz9pzza authored and sarken committed Jul 16, 2019
    * Work on SQL issues
    
    * Most refactoring
    
    * Fix test and hound
    
    * Fix other mistakes
    
    * Move code from view
    
    * Hopefully last bits
    
    * Fix typo
    
    * Follow review
    
    * Follow review
    
    * Listen to hound and brakeman
    
    * Fix test
    
    * fix test
    
    * Follow review
    
    * Rename reorder
    
    * Missing bit
    
    * Prefer case
    
    * fix ,
Commits on Jul 6, 2019
  1. AO3-5549 Handle deleted users in spam alert. (#3591)

    tickinginstant authored and zz9pzza committed Jul 6, 2019
    * AO3-5549 Handle deleted users in spam alert.
    
    * AO3-5549 Some style fixes for Hound.
    
    * AO3-5549 Eschew BulletproofMailer.
Commits on Jul 1, 2019
Commits on Jun 26, 2019
  1. AO3-5099 & AO3-5126 Separate "Name or email" query into two fields, a…

    tickinginstant authored and sarken committed Jun 26, 2019
    …nd fix the results count. (#3586)
    
    * AO3-5099 Split user query into name and email.
    
    * AO3-5099 Capitalization of "Search settings."
    
    * AO3-5126 Use distinct scope instead of select.
    
    * AO3-5099 Fix up "I make x an archivist" step.
    
    * AO3-5099 More cucumber test fixes.
Commits on Jun 19, 2019
  1. AO3-3953 Expire caches of work blurbs, metas, and links on tag pages (#…

    redsummernight authored and sarken committed Jun 19, 2019
  2. AO3-5697 Add unique index to meta_taggings table. (#3585)

    tickinginstant authored and sarken committed Jun 19, 2019
    For pt-online-schema-change, the argument to --alter corresponding to
    this migration is:
    
      ADD UNIQUE INDEX
        index_meta_taggings_on_meta_tag_id_and_sub_tag_id
        (meta_tag_id, sub_tag_id),
      DROP INDEX
        index_meta_taggings_on_meta_tag_id
    
    The argument --nocheck-unique-key-change may also be necessary, since
    pt-online-schema-change tries to ensure that data will not be lost when
    adding a new unique index.
Commits on Jun 8, 2019
  1. AO3-5699 Pass works instead of whole response to claim notification m…

    ariana-paris authored and sarken committed Jun 8, 2019
    …ethod (#3582)
    
    * AO3-5699 Pass works instead of whole response to claim notification method
    
    * AO3-5699 Fix mock imports in API specs to ensure test isolation
Commits on Jun 1, 2019
  1. AO3-3953 Remove collection-scoped tag links (#3454)

    redsummernight authored and sarken committed Jun 1, 2019
    Links to tag pages (showing meta tags, sub tags, etc.) should never
    be collection-scoped.
    
    Links to tag work listings should be collection-scoped only in
    two places:
    
    - collections/COLLECTIONNAME/tags
    - collections/COLLECTIONNAME/fandoms
  2. AO3-5099 Add option for exact string match for admin user search (#3141)

    hatal175 authored and sarken committed Jun 1, 2019
    * AO3-5099 Add option for exact string match for admin user search
    
    * AO3-5099 hound fixes
    
    * AO3-5099 codeclimate fix
    
    * AO3-5099 hound fixes #2
  3. AO3-5097 admin users refactoring (#2986)

    elzj authored and sarken committed Jun 1, 2019
    * AO3-5097: Refactor admin users controller
    
    * AO3-5097: Update comment and remove a dash of randomness
    
    * AO3-5097: Syntax tweaks
    
    * AO3-5097: A few additional tweaks
Commits on May 31, 2019
  1. AO3-5695 Update newrelic_rpm, drop unused newrelic-redis gem (#3581)

    zz9pzza authored and sarken committed May 31, 2019
    * Update new relic agent, drop redis agent as no longer used
    
    * Commit Gemfile
Commits on May 30, 2019
  1. AO3-5694 Don't load fandoms list on orphan_account user dashboard (#3580

    sarken authored and zz9pzza committed May 30, 2019
    )
    
    * AO3-5694 Don't load fandoms list on orphan_account user dashboard
    
    * AO3-5694 Spacing changes
Older
You can’t perform that action at this time.