Skip to content
Permalink
Tag: v0.9.254.4
Commits on Sep 12, 2019
  1. AO3-5688 Use double quotes and translatable text on delete user previ…

    sarken authored and redsummernight committed Sep 12, 2019
    …ew page (#3632)
    
    * AO3-5688 Look for new co-creator terminology when deleting account
    
    * AO3-5688 Change 'co-author' to 'co-creator' on delete preview
    
    * AO3-5688 Fix indenting
    
    * AO3-5688 From => to :
    
    * AO3-5688 Prefer symbols
    
    * AO3-5688 Prefer double quotes
    
    * AO3-5688 Mostly i18n delete preview page
    
    * AO3-5688 Use double quotes in text
    
    * AO3-5688 Change tests to look for double-quoted orphan
    
    * AO3-5688 Update radio selection step definition to work when there are double quotes
    
    * AO3-5688 Remove unused clause in step definition that would no longer work
    
    * AO3-5688 ...remove the last ? from the clause too
    
    * AO3-5688 Finish removing the unused part of the step definition
Commits on Sep 10, 2019
  1. [Security] Bump devise from 4.6.1 to 4.7.1 (#3627)

    dependabot-preview authored and CristinaRO committed Sep 10, 2019
    Bumps [devise](https://github.com/plataformatec/devise) from 4.6.1 to 4.7.1. **This update includes a security fix.**
    - [Release notes](https://github.com/plataformatec/devise/releases)
    - [Changelog](https://github.com/plataformatec/devise/blob/master/CHANGELOG.md)
    - [Commits](plataformatec/devise@v4.6.1...v4.7.1)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
  2. AO3-5688 Change "co-author" to "co-creator" on delete preview page (#…

    sarken authored and CristinaRO committed Sep 10, 2019
    …3630)
    
    * AO3-5688 Look for new co-creator terminology when deleting account
    
    * AO3-5688 Change 'co-author' to 'co-creator' on delete preview
    
    * AO3-5688 Fix indenting
    
    * AO3-5688 From => to :
    
    * AO3-5688 Prefer symbols
    
    * AO3-5688 Prefer double quotes
  3. AO3-5024 Correct error message when entering wrong password for admin (

    sarken authored and CristinaRO committed Sep 10, 2019
    …#3629)
    
    * AO3-5024 Add test to look for correct error message
    
    * AO3-5024 Update error message when entering wrong password for existing admin
    
    * AO3-5024 Tidy authenticate_admins feature tests
    
    * Spacing!
    * Use the user-facing labels!
    * New descriptions of scenarios!
  4. AO3-5655 Move admin_helper_spec to the correct folder (#3626)

    redsummernight authored and sarken committed Sep 10, 2019
    Mark all specs in spec/miscellaneous/helpers as helper specs
    by default.
  5. AO3-5750 Upgrade factory_girl to factory_bot (#3615)

    CristinaRO committed Sep 10, 2019
    * (chore) Use dynamic attributes in all factories
    
    Latest factory_bot doesn't allow static attributes, so we need to replace all of them with dynamic attributes before updating the bot.
    
    * Use the factory_bot gems instead of factory_girl
    
    The gem previously known as `factory_girl` (with its associated Rails specific `factory_girl_rails`) is now `factory_bot` (and `factory_bot_rails` respectively), so any version updates will happen to the ’`bot`.
    
    It’s good practice to have the latest stable versions of gems if they’re compatible with our code without too much fuss.
    
    I’ve used the official migration guide:
    https://github.com/thoughtbot/factory_bot/blob/4-9-0-stable/UPGRADE_FROM_FACTORY_GIRL.md
    
    Attempting to jump to the latest version (5.0.2 at the time of writing) had too many failures, so I'm now taking it in steps.
    
    The first step is as close to a drop-in replacement as possible, by locking `factory_bot` at 4.8.2.
    
    We still needed to update pickle at the same time, or the tests would fail because of some nonsense with virtual attributes such as `terms_of_service` and `age_over_13` in user factories.
    
    * Obey the Hound
    
    * Attempt upgrade from 4.8.2 to 4.11.1
    
    This is the last 4.x version.
    
    * Upgrade to the latest version of factory_bot
    
    At the time of writing, the latest version is 5.0.2.
    
    * Allow any 5.x versions of factory_bot
    
    There doesn't seem to be a point to locking down to a specific minor version of factory_bot. Matching to major versions only is a good idea, though.
    
    * Downgrade gems shared with non-test environments
    
    In order to keep this PR's scope test-only, downgrade the gems that are shared between test and non-test environments as requested [1], and see if the tests still pass.
    
    [1] #3615 (comment)
  6. AO3-5733 Check the current user is a maintainer before showing privil…

    CristinaRO committed Sep 10, 2019
    …eged info (#3613)
    
    * (fix) Check the current user is a maintainer before showing privileged info
    
    Previously, we were assuming that the `@collection` variable being set means a mod is the user currently looking at the page.
    
    This assumption turned out to be erroneous, because `@collection` is also set when a non-maintainer user has multiple assignments in the same challenge.
    
    The reason this happens for users with multiple assignments is that the challenge sidebar sends the user to a different path when that's the case:
    ```
        <% elsif @challenge_assignments.size > 1 %>
          <li><%= span_if_current ts("My Assignments"), user_assignments_path(current_user, :collection_id => @collection.name) %>
        <% end %>
    ```
    
    This goes to the `index` action of the `challenge_assignments_controller`, where this happens:
    ```
      def index
        if params[:user_id] && (@user = User.find_by(login: params[:user_id]))
          if current_user == @user
            if params[:collection_id] && (@collection = Collection.find_by(name: params[:collection_id]))
    ```
    and `@collection` gets assigned.
    
    * AO3-5733 Add tests
    
    * AO3-5733 Remove extra blank line in tests
    
    * AO3-5733 Update syntax before red has to tell me to
    
    * AO3-5733 Add code comment
  7. AO3-5688 link to orphaning faq in account deletion preview (#3599)

    dlhardin authored and CristinaRO committed Sep 10, 2019
  8. AO3-5673 added delimiter to fandom/users/works count on homepage (#3600)

    dlhardin authored and CristinaRO committed Sep 10, 2019
  9. AO3-5179 Delete About Orphaning page and replace links with FAQ (#3083)

    sarken authored and CristinaRO committed Sep 10, 2019
    * AO3-5179 Delete About Orphaning page and replace links with FAQ
    
    * AO3-5179 Remove all trace of the About Orphaning page
  10. AO3-5077 Fix TOS FAQ Anchor Links (#3606)

    sarken authored and CristinaRO committed Sep 10, 2019
  11. AO3-5730 Fix labels for chapter title and number in new work form (#3621

    lethnie authored and CristinaRO committed Sep 10, 2019
    )
  12. AO3-5583 Add an anchor to the comment page links. (#3598)

    tickinginstant authored and CristinaRO committed Sep 10, 2019
  13. AO3-5076 Make requested link changes in FAQ page (#3170)

    hatal175 authored and sarken committed Sep 10, 2019
  14. AO3-5024 Reword error message when failing to log in as admin (#3133)

    hatal175 authored and sarken committed Sep 10, 2019
    * AO3-5024 Admin login now has login error message
    
    * AO3-5024 Used simpler override of devise recall function
    
    * AO3-5024 Added final new line to custom_devise_failure.rb
    
    * AO3-5024 Change admin login failure message to be distinct from user
    
    * AO3-5024 Remove custom Devise error handling
    
    * AO3-5024 Update Devise error messages
Commits on Sep 5, 2019
  1. AO3-5753 Increase maximum comment length (#3624)

    zz9pzza authored and sarken committed Sep 5, 2019
    * The actual changed of the amount
    
    * The contravershal bit
    
    * Make the display 10000
    
    * Revert "Make the display 10000"
    
    This reverts commit 149e8b7.
    
    * Revert "The contravershal bit"
    
    This reverts commit c8f7632.
Commits on Sep 4, 2019
  1. AO3-5658 Update co-creator notification text (#3623)

    sarken authored and zz9pzza committed Sep 4, 2019
    * AO3-5658 Update co-creator notification text
    
    * AO3-5658 Look for new text in test
    
    * AO3-5658 Don't look for portion of test with apostrophe because test will fail
Commits on Sep 2, 2019
  1. AO3-5658 AO3-5751 Make the ability to view drafts more consistent, an…

    tickinginstant authored and sarken committed Sep 2, 2019
    …d add admin access to the user drafts page. (#3622)
    
    * AO3-5658 Fix up draft visibility checks.
    
    * AO3-5751 Let admins see the list of drafts.
    
    * AO3-5658 Fix up unrevealed check for chapters.
    
    * AO3-5658 Some clean-up for Hound.
    
    * AO3-5658 Remove hide_work_info assignment.
Commits on Sep 1, 2019
  1. AO3-5334 Update confirmation prompt when removing self from series (#…

    sarken authored and redsummernight committed Sep 1, 2019
Commits on Aug 31, 2019
  1. AO3-5334 Rename "Remove Me As Author" to "Remove Me As Co-Creator" (#…

    sarken authored and redsummernight committed Aug 31, 2019
    …3619)
    
    * AO3-5334 Rename Remove Author to Remove Co-Creator on Edit Work page
    
    * Revert "AO3-5334 Rename Remove Author to Remove Co-Creator on Edit Work page"
    
    This reverts commit 1fe3bb7.
    
    * AO3-5334 Rename 'Remove Author' to 'Remove Co-Creator' on Edit Work page
    
    * AO3-5334 Rename 'Remove Author' to 'Remove Co-Creator' on series navigation
    
    * AO3-5334 Update tests to look for new text
    
    * AO3-5334 Update capitalization on co-creator removal for mass editing
    
    * AO3-5334 Update messages when removing creators from works and series
    
    * AO3-5334 Update text in spec to look for 'creator'
    
    * AO3-5334 Update spacing and quotes on a line I touched
  2. AO3-5658 Remove sentence from privacy help pop-up (#3616)

    sarken authored and zz9pzza committed Aug 31, 2019
Commits on Aug 28, 2019
  1. AO3-5658 Co-creator email changes and front end tweaks (#3612)

    sarken authored and redsummernight committed Aug 28, 2019
    * AO3-5658 Update creator-related bits on edit multiple form
    
    * Button-styling to make Remove option easier to see and click
    * Only display Remove option when usable
    * Only display pseud selection list when relevant
    
    * AO3-5658 Put co-creator checkboxes in fieldsets on work form
    
    * AO3-5658 Add new preference to help file
    
    * AO3-5658 Update co-creator email text
    
    * AO3-5658 Make sure archivist co-creator email uses wrong subject
    
    * AO3-5658 Fix incorrect interpolation argument
    
    * AO3-5658 Use the right key
    
    * AO3-5658 Update test to look for new email text
    
    * AO3-5658 Adjust co-creator section of mass edit form
    
    * Fix capitalization on remove button
    * Get rid of superflous code for disabling remove button
    
    * AO3-5658 Correct privacy pref help text
    
    * AO3-5658 Make edit multiple test look for new capitalization
    
    * AO3-5658 Correct it again
Commits on Aug 20, 2019
  1. AO3-5658 Don't escape error messages on the Edit Multiple Works page,…

    tickinginstant authored and redsummernight committed Aug 20, 2019
    … and make the invalid tag error message appear. (#3611)
    
    * Don't escape error messages for update_multiple.
    
    * Fix handling of invalid tags.
Commits on Aug 17, 2019
  1. AO3-5658 Add creator invitations, and a preference option to disable …

    tickinginstant authored and sarken committed Aug 17, 2019
    …them. (#3596)
    
    * First step to co creator banning
    
    * Clean up code
    
    * Clean up code
    
    * Make the removal of people optional
    
    * More work getting orignal tests working
    
    * Fix the tests
    
    * More test
    
    * Fix tests before breaking it all
    
    * Minimal spec
    
    * Another day looking at tests
    
    * Save preferences
    
    * Testing
    
    * Hack in place to help with tests
    
    * More fixing tests
    
    * More test
    
    * Need a full test run
    
    * Time for another rerun
    
    * Fix - _
    
    * MOre test runs
    
    * Fixing last test ?
    
    * Clean up
    
    * Migrate to class method in Psued
    
    * fix typo
    
    * Add a co author test
    
    * Add additional tests
    
    * consistent co-creator
    
    * Add support for chapters
    
    * Admins can save works
    
    * revert allow admins all the things
    
    * More chapter work
    
    * Try more common code
    
    * Start series
    
    * Add series support, brake Works
    
    * Find bug with author attributes
    
    * Revert earlier change
    
    * Fix Ao3-5083
    
    * Fix specs
    
    * External works do not have pseuds
    
    * We redirect to edit rather than rendering the template
    
    * Work on error
    
    * Hidden fields and other evil things
    
    * Final bit before pushing on to chapters
    
    * Use common set_author_attributes
    
    * move common bits to load_pseuds
    
    * Put readme back
    
    * Whitespace
    
    * Fix https://otwarchive.atlassian.net/browse/AO3-5662
    
    * Update app/views/works/_hidden_fields.html.erb
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update spec/models/series_spec.rb
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/bookmark_indexing.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/bookmark_indexing.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update spec/models/series_spec.rb
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/series.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/series.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/series.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/prompt_memes_b/challenge_promptmeme_posting_fills.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/other_b/series.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/chapter_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_create.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_create.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_create.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_create.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Update features/works/work_edit.feature
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * First pass though review
    
    * More reviews
    
    * More reviews
    
    * undefined method before_save for CreatorshipValidations:Module
    
    * Do it the right way round
    
    * Try and fix concerns, whitespace
    
    * Use before save as is intended
    
    * Add defaults
    
    * Refactor list of isse psueds
    
    * Don't always abort
    
    * Back to original code
    
    * Fix tests
    
    * Fix syntax
    
    * Apply suggestions from code review
    
    Co-Authored-By: zz9pzza <zz9pzza@gmail.com>
    
    * Whitespace
    
    * More hound suggestions
    
    * Fix issue
    
    * Hopefully make this better (following sarken's comment)
    
    * More whitespace and hound
    
    * Whitespace
    
    * Add priority overrides
    
    * missed a puts
    
    * Listen to the hound
    
    * Fix nil issues
    
    * Refactor check to be instance method, disallow admins from making co-creators
    
    * WIP
    
    * Fix up specs and clean up code.
    
    * Numerous fixes for cucumber tests.
    
    * Continue fixing up tests, and some minor fixes.
    
    * Fix up a few automated tests (+ whitespace).
    
    * Switch to approval_status (1, 0, -1).
    
    * Fix up Edit Multiple Works spec.
    
    * Bring over some parse_bylines changes from zz9pzza.
    
    * Fix up some deletion behavior, plus page titles.
    
    * Start work on suggested changes.
    
    - Change description of preference option.
    
    - Remove "Accept Co-Creator Invitation" button and replace with a flash
    notice at the top of the work/chapter/series.
    
    - Move "Creator Invitations" link further down the user sidebar.
    
    * Fix up cucumber tests.
    
    * Remove unused Creatorships#accept action.
    
    * Make unrevealed works visible to invited creators.
    
    * Handle series better if posting a new work fails.
    
    * More cucumber fixes.
    
    * Revert back to boolean for approval status.
    
    * Fix up editing multiple works.
    
    * Assorted style changes.
    
    * Temporary fix for the email text.
    
    * Handle pseud deletion better.
    
    * Orphan works in AdminMailer test.
    
    * Change "Delete" to "Reject."
    
    * Move the will_paginate blocks outside the if.
    
    * Remove outdated comment.
    
    * Destroy empty series when deleting account.
    
    * Add transaction around change_ownership.
    
    * Remove admin access to creatorships page.
    
    * Handle creatorships will null pseuds better.
    
    * Don't use "Post Without Preview" for new tests.
    
    * Add tasks for cleaning up creatorships.
    
    * Add more info to creator notification email.
    
    * Remove unused method that called authors.
    
    * New test for editing multiple works.
    
    * Assorted fixes for Hound.
    
    * More changes for Hound.
    
    * Disable notifications on Work#remove_author.
    
    * Add custom message for archivists.
    
    * Start following redsummernight's review.
    
    * Start following Sarken's review.
    
    * Add archivist tests and flip notification default.
    
    * Fix up broken join in creatorship deletion task.
    
    * Follow more of redsummernight's review.
    
    * More review comments.
    
    * Fix up new test.
    
    * Another test fix.
    
    * Change error message, comment, associations.
    
    * Fix minor typos
  2. AO3-5729 [Security] Bump nokogiri from 1.10.3 to 1.10.4 (#3608)

    dependabot-preview authored and sarken committed Aug 17, 2019
    Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.3 to 1.10.4. **This update includes a security fix.**
    - [Release notes](https://github.com/sparklemotion/nokogiri/releases)
    - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
    - [Commits](sparklemotion/nokogiri@v1.10.3...v1.10.4)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Commits on Aug 13, 2019
  1. AO3-5480 Switch to Zoho Desk REST API for Support and Abuse forms (#3605

    CristinaRO authored and sarken committed Aug 13, 2019
    )
    
    * (fix) Typo in regex
    
    The typo meant we were too lenient with some blank spaces, but removing any incidental `s` after the starting paragraph mark.
    
    * (chore) Implement mini Zoho clients
    
    A client for authorisation and one for the "resources", since this is how Zoho separate their concepts (different servers, endpoints etc).
    
    * (chore) Feedback reporters use the new Zoho API
    
    * Doh
    
    Thanks, Github Desktop, I hate it.
    
    * Update default config.yml
    
    * Fix Hound comments
    
    * Move specs
    
    * Delete templates
    
    * Use ArchiveConfig to allow stubbing
    
    * Add ArchiveConfig.ZOHO_REDIRECT_URI
    
    * Encode query parameters of Zoho GET requests
    
    * Add comments for new Zoho config keys
    
    * Fall back on Language.default
    
    * Fix Hound comments on specs
    
    * Don't need both `query:` and `.to_query`.
    
    * Fix broken specs.
    
    * Cache the access token.
    
    * (chore) Obey the Hound and the sarken
    
    The double quotes were sarken's request, all the rest was Hound's hounding.
    
    * (fix) Indentation
    
    * Make contact resilient to name changes
    
    The `lastName` field is required by Zoho. It's the only required field for a contact, in fact.
    
    As we, of course, don't ask for people's last names, we are content to use the email, because that's the field that *we* require so we know it's going to be present.
    
    Furthermore, we don't want to store the name (which is *not* necessarily the username for a logged in Archive user) with the contact, because people might be giving different names for different tickets.
    
    We will introduce a custom name field for the ticket in the near future.
    
    * Use a custom field `Name` for ticket-level names
    
    Users might enter different names, or no names, for tickets they send with the same email address.
    
    The email address is the unique identifier for a contact, so we don't want to rely on Zoho's automated lookup of the `contactName`.
    
    Instead, we want to give the user the chance to tell us what name they want to be used in association with this specific ticket.
    
    * Zoho new custom fields format
    
    A very recent change! `customFields` is now deprecated, replaced with the much clearer and self-explanatory `cf`.</sarcasm>
    
    Also, the custom fields themselves must be sent as `cf_snake_case_name`, even though in the interface you can only give the display name. They automatically compute the snake case form from the display name, so `Archive Version` becomes `cf_archive_version` and so on.
    
    * AO3-5480 Change email veracity check to format check
    
    We don't want to allow email addresses with asterisks because Zoho doesn't let contacts have emails like that.
    
    * AO3-5480 Update support and abuse form tests to check for proper error message
Commits on Aug 8, 2019
  1. AO3-4592 Fix task to reveal stuck anonymous/unrevealed works (#3604)

    zz9pzza authored and sarken committed Aug 8, 2019
    * First draft
    
    * Follow review
    
    * White space
    
    * task needs to use the enviroment
    
    * 100% less syntax errors
    
    * Add tests
    
    * Whitespace
    
    * Spacing and removing extra line of code that wasn't wanted
    
    * Add more tests and whitespace
    
    * whitespace
    
    * Add some newlines
    
    * lowercase w
    
    * Follow sarken's comment
    
    * Fix style, reuse relation, flush stdout, order tests consistently
Commits on Aug 3, 2019
  1. AO3-4159 Fix formatting for user last login information (#3603)

    zz9pzza authored and sarken committed Aug 3, 2019
    * Refactor to use Devise
    
    * Fix variable name
    
    * Fix steps
    
    * Fix steps
    
    * Follow review
    
    * Spacing
    
    * Follow review
    
    * Follow review
    
    * Missed a timeago
    
    * Revert as much as possible
    
    * follow review, change all ts to use double quotes
    
    * Follow comments from staging
    
    * Follow review
    
    * Fix tests
Commits on Aug 2, 2019
  1. AO3-5720 Modify the rules of CollectionItem#approve_automatically. (#…

    tickinginstant authored and sarken committed Aug 2, 2019
Commits on Aug 1, 2019
  1. AO3-4159 Add last login information to admin user display (#3545)

    zz9pzza authored and sarken committed Aug 1, 2019
    * Refactor to use Devise
    
    * Fix variable name
    
    * Fix steps
    
    * Fix steps
    
    * Follow review
    
    * Spacing
    
    * Follow review
    
    * Follow review
    
    * Missed a timeago
    
    * Revert as much as possible
    
    * follow review, change all ts to use double quotes
  2. AO3-4592 Un-hide works affected by anon/unrevealed collection invitat…

    zz9pzza authored and sarken committed Aug 1, 2019
    …ion bug (#2484)
    
    * First draft
    
    * Follow review
    
    * White space
  3. AO3-5691 Fix error message when editing a work's publication date to …

    redsummernight authored and zz9pzza committed Aug 1, 2019
    …the future (#3597)
    
    Avoid the "translation missing" error.
  4. AO3-5039 Prevent non canonical tags from being favorited (#2936)

    sarken authored and zz9pzza committed Aug 1, 2019
    * AO3-5039 Validate canonical-ness of tag before adding to favorite tags
    
    * AO3-5039 Put the methods for the validations by the validations, and use double quotes consistently
    
    * AO3-5039 Tests for favorite tags
    
    * AO3-5039 Fixes for favorite tag validations based on test failures
    
    * AO3-5039 Style fixes
    
    * AO3-5039 Update tests to use correct ccanonical status for tags
    
    * AO3-5039 Use valid? instead of saving in favorite tag spec
Commits on Jul 20, 2019
  1. AO3-5689 Fix sorting stats by descending date (#3594)

    zz9pzza authored and redsummernight committed Jul 20, 2019
    * Fix brakeman eval issues
    
    * Fix typo
    
    * Replace hash with case
    
    * Missed an end
    
    * Follow review
    
    * elsif is not intuitive, when the conditions are mutually exclusive
    
    * Follow review
    
    * Fix comparision
    
    * just a step to the right
    
    * follow hound comments
    
    * Follow review
    
    * Follow review
    
    * Follow reivew
Older
You can’t perform that action at this time.