Skip to content
Permalink
Tag: v0.9.256.1
Commits on Oct 6, 2019
  1. Merge pull request #3648 from zz9pzza/AO3-5784

    sarken committed Oct 6, 2019
    AO3-5784 Update Ruby to 2.6.5
Commits on Oct 5, 2019
  1. Try rubocop name

    zz9pzza committed Oct 5, 2019
  2. Use a later rubocop for hound

    zz9pzza committed Oct 5, 2019
  3. Bump webmock

    zz9pzza committed Oct 5, 2019
  4. Bump version

    zz9pzza committed Oct 5, 2019
Commits on Sep 29, 2019
  1. Merge branch 'master' into AO3-5037_ruby_2_4_5_upgrade

    sarken committed Sep 29, 2019
  2. AO3-5613 Avoid breaking work warnings for mass import API (#3645)

    redsummernight authored and sarken committed Sep 29, 2019
Commits on Sep 27, 2019
  1. AO3-5037 Update Ruby version used by Hound

    sarken committed Sep 27, 2019
  2. Adss WebMock.enable! That's required with new gem.

    mattsears authored and sarken committed Mar 8, 2019
  3. Resolve conflicts in previous commit

    mattsears authored and sarken committed Mar 7, 2019
Commits on Sep 21, 2019
  1. AO3-5613 Prevent error when challenge assignment email contains warni…

    sarken authored and redsummernight committed Sep 21, 2019
    …ng tags (#3639)
    
    * AO3-5613 Tests for challenge notification emails with warning tags
    
    * AO3-5613 Challenge assignment emails with warning tags should not error
    
    * AO3-5613 Challenge assignment emails with warning tags should display proper label
    
    * AO3-5613 Update warning model in locale file
Commits on Sep 17, 2019
  1. AO3-5707 Legacy warning search (#3631)

    elzj authored and sarken committed Sep 17, 2019
    * Refactor Warnings class name as it is used in ruby 2.4
    \o/ rubymine
    
    * Add a migration for single table inheritence.
    
    * Fix typo
    
    * test test
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Correct typo
    
    * Rename archivewarning to archive_warning and archivewarnings to archive_warnings
    
    * Parse tags should underscore klass names, which also conviently downcases them
    
    * Fix display of warning tags in work blurbs
    
    * Fix display of warnings in share
    
    * Fix display of warnings in work meta
    
    * Revert "Fix display of warnings in work meta"
    
    This reverts commit d1802b6.
    
    * Fix display of warnings in work meta
    
    * Fix 500 error on warning facets
    
    * Updates minor version number of scrypt since 3.0.5 doesn't compile on my machine.
    
    * Fixes the warnings -> archive warnings params.
    
    * Migrates warning to archive_warning in all references.
    
    * Updates more Warning -> ArchiveWarning codes.
    
    * Replaces warning for archive_warning in the filters.
    
    * More warning conversion found lurking in the weeds.
    
    * Fixes more tests around the warning -> archive warning tags.
    
    * AO3-5037 Renames the migrations to something more obvious to what it does.
    
    * Remove scrypt from Gemfile since it's no longer a dependency.
    
    * Corrects type and removes extra whitespace from the top of the file.
    
    * Removes unneeded class name checks for Archive Warning classes.
    
    * WIP: Updates views to keep 'warnings' as class names.
    
    * WIP: More updates to keep 'warnings' 'warnings'.
    
    * Updates tags label to "Warnings" and no longer need to check for archive_warning type anymore.
    
    * Adds new method TagSet.find_type_label to find labels for Tags.
    
    * Restores the original version number of Bundler that matches master.
    
    * Repairs the gifts exchange edit page with "Archive Warnings".
    
    * More updates made to the UI for "Archive Warnings"
    
    * Updates more Warnings vs Archive Warnings in the views.
    
    * Fixes a few broken tests.
    
    * Fixes translation issue with archive_warning.
    
    * Uses "Archive Warnings" for the label.
    
    * Add helper method for determining class name for HTML
    
    * Move the elastic seach port.
    
    * Corrects params values for archive warnings.
    
    * Updates warning_string to archive_warning_string
    
    * Changes Warning back to ArchiveWarning.
    
    * Updates warnings to archive_warnings.
    
    * WIP: Adds prototype for tag typle labeling.
    
    * Updates code to unify a method that renders the appropriate value for the tag type label.
    
    * Adds suggested code updates based on PR feedback.
    
    * Reverts previous ES port number change.
    
    * Moves tag_type_class method to TagTypeHelper module.
    
    * Corrects the appropriate keys/value for building error messages.
    
    * Adds tests and some more documentation that shows example usage.
    
    * Adds pluralize and downcase calls where needed.
    
    * Pluralizes the tag type on the filters list.
    
    * Pluralizes the tag types in teh bookmarks filters.
    
    * Added a condition for 'tag' label.
    
    * Removes comment and cleans it up a little. More can be done here, but will require more time refactor that method.
    
    * Adds updates based on latest PR feedback.
    
    * Update app/views/tag_set_nominations/_tag_nominations.html.erb
    
    Co-Authored-By: sarken <sarken@gmail.com>
    
    * Update app/views/tag_set_nominations/_tag_nominations_by_fandom.html.erb
    
    Co-Authored-By: sarken <sarken@gmail.com>
    
    * Update app/views/tag_set_nominations/_tag_nominations_by_fandom.html.erb
    
    Co-Authored-By: sarken <sarken@gmail.com>
    
    * Wraps tag_type_label_name with ts().
    
    * Removes dump.rdb from repository.
    
    * Updates header to use tag_type_label_name helper.
    
    * Address Hound comments regarding spacing and indenting
    
    * Remove use of locale
    
    * Rename tag_type_class to tag_type_css_class
    
    * Update title text on request and offer settings and update pluralization on minimum number to match settings
    
    * Make sure the class and label methods can handle getting a plural passed in
    
    * Correct class name on challenge sign up form
    
    * Correct tag types for tag sets
    
    * Remove extra singularization
    
    * Fix a few more places we were using the tag class rather than the label_name
    
    * Use Freeform.label_name in tag_type_label_name helper
    
    * Downcase tag type in error message and update tag cloud tests to look for 'Additional Tag'
    
    * Update two more wrangling tests to look for Additional Tag rather than Freeform
    
    * Remove a pluralize we don't want
    
    * Adds tag type label updates based on latest PR feedback.
    
    * (refactor) Remove duplication and nesting
    
    This is a code structure change only, attempting to get the code to pass CodeClimate's checks.
    
    * Revert "(refactor) Remove duplication and nesting"
    
    This reverts commit f574bc9.
    
    * AO3-5707: Support bookmarked warning searches after rename
    
    * AO3-5707: Fix escaped file and comment
    
    * AO3-5707: Add whitespace
    
    * AO3-5707: Comments
Commits on Sep 15, 2019
  1. AO3-5703 Search for works and bookmarks by language short name (#3628)

    redsummernight authored and sarken committed Sep 15, 2019
    * AO3-5703 Search for works and bookmarks by language short name
    
    Maintain backward compatibility for old work/bookmark searches/filters
    using language IDs.
    
    * Fix code style
    
    * Fix code style
  2. AO3-5391 Remove unused taggable methods (#3290)

    sarken authored and redsummernight committed Sep 15, 2019
    * AO3-5391 Remove unused taggable methods
    
    * AO3-5391 Use new method of determining fandom tags for external works
    
    * AO3-5391 Don't use removed methods for showing series tags
    
    * AO3-5391 Update tests for revealing hidden tags
    
    * AO3-5391 Be more specific about where I should not see the warning
    
    * AO3-5391 Enable JavaScript for the more complex hidden tag scenario
    
    * AO3-5391 Use archive_warnings following Warning class rename
    
    * AO3-5391 Ignore Brakeman warning
  3. AO3-5652 Index more series data (#3635)

    elzj authored and redsummernight committed Sep 15, 2019
    * AO3-5652: Index series data with ids and positions
    
    * AO3-5652: A few small improvements c/o redsummernight
    
    * AO3-5652: Remove unused method
  4. AO3-5613 Fix revealing hidden warning tags in work meta (#3636)

    sarken authored and redsummernight committed Sep 15, 2019
    * AO3-5613 Update tests to better cover the hide warnings and freeforms preferences
    
    * AO3-5613 Update JavaScript used for hiding warnings
    
    * AO3-5613 Break down blurb_tag_block helper method so the part for handling hidden tags can be reused in work meta
    
    * AO3-5613 Use new show_hidden_tag_link_list_item method to hide warnings and freeforms in work meta
    
    * AO3-5613 Don't include the warnings or freeforms class on the toggle for showing warning or freeform tags in work meta
    
    This is only to be consistent with current behavior. Nothing breaks if it's there.
    
    * AO3-5613 Clarify code comment on tag_block_class_name
    
    * AO3-5613 Bump cache version on work meta
Commits on Sep 12, 2019
  1. AO3-5652 Index works with their series titles (#3584)

    redsummernight authored and sarken committed Sep 12, 2019
    * AO3-5652 Index works with their series titles
    
    * Update work search spec
    
    * Change after_update to after_update_commit
    
    * Split work search spec
    
    * Search for series titles with numbers
    
    * Split specs, check if series title queries exclude standalone works
  2. AO3-5649 Sort authors_to_sort_on to match byline (#3555)

    redsummernight authored and sarken committed Sep 12, 2019
    * AO3-5649 Sort authors_to_sort_on to match byline
    
    * AO3-5649 Sort the pseuds themselves, not the names
    
    * Update work spec
  3. AO3-5492 Index work tags with numbers (#3547)

    redsummernight authored and sarken committed Sep 12, 2019
    Use the default analyzer which doesn't discard numbers.
  4. AO3-5613 Rename Warning class to ArchiveWarning (#3526)

    mattsears authored and sarken committed Sep 12, 2019
    * Refactor Warnings class name as it is used in ruby 2.4
    \o/ rubymine
    
    * Add a migration for single table inheritence.
    
    * Fix typo
    
    * test test
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Classes in strings.....
    
    * Correct typo
    
    * Rename archivewarning to archive_warning and archivewarnings to archive_warnings
    
    * Parse tags should underscore klass names, which also conviently downcases them
    
    * Fix display of warning tags in work blurbs
    
    * Fix display of warnings in share
    
    * Fix display of warnings in work meta
    
    * Revert "Fix display of warnings in work meta"
    
    This reverts commit d1802b6.
    
    * Fix display of warnings in work meta
    
    * Fix 500 error on warning facets
    
    * Updates minor version number of scrypt since 3.0.5 doesn't compile on my machine.
    
    * Fixes the warnings -> archive warnings params.
    
    * Migrates warning to archive_warning in all references.
    
    * Updates more Warning -> ArchiveWarning codes.
    
    * Replaces warning for archive_warning in the filters.
    
    * More warning conversion found lurking in the weeds.
    
    * Fixes more tests around the warning -> archive warning tags.
    
    * AO3-5037 Renames the migrations to something more obvious to what it does.
    
    * Remove scrypt from Gemfile since it's no longer a dependency.
    
    * Corrects type and removes extra whitespace from the top of the file.
    
    * Removes unneeded class name checks for Archive Warning classes.
    
    * WIP: Updates views to keep 'warnings' as class names.
    
    * WIP: More updates to keep 'warnings' 'warnings'.
    
    * Updates tags label to "Warnings" and no longer need to check for archive_warning type anymore.
    
    * Adds new method TagSet.find_type_label to find labels for Tags.
    
    * Restores the original version number of Bundler that matches master.
    
    * Repairs the gifts exchange edit page with "Archive Warnings".
    
    * More updates made to the UI for "Archive Warnings"
    
    * Updates more Warnings vs Archive Warnings in the views.
    
    * Fixes a few broken tests.
    
    * Fixes translation issue with archive_warning.
    
    * Uses "Archive Warnings" for the label.
    
    * Add helper method for determining class name for HTML
    
    * Move the elastic seach port.
    
    * Corrects params values for archive warnings.
    
    * Updates warning_string to archive_warning_string
    
    * Changes Warning back to ArchiveWarning.
    
    * Updates warnings to archive_warnings.
    
    * WIP: Adds prototype for tag typle labeling.
    
    * Updates code to unify a method that renders the appropriate value for the tag type label.
    
    * Adds suggested code updates based on PR feedback.
    
    * Reverts previous ES port number change.
    
    * Moves tag_type_class method to TagTypeHelper module.
    
    * Corrects the appropriate keys/value for building error messages.
    
    * Adds tests and some more documentation that shows example usage.
    
    * Adds pluralize and downcase calls where needed.
    
    * Pluralizes the tag type on the filters list.
    
    * Pluralizes the tag types in teh bookmarks filters.
    
    * Added a condition for 'tag' label.
    
    * Removes comment and cleans it up a little. More can be done here, but will require more time refactor that method.
    
    * Adds updates based on latest PR feedback.
    
    * Update app/views/tag_set_nominations/_tag_nominations.html.erb
    
    Co-Authored-By: sarken <sarken@gmail.com>
    
    * Update app/views/tag_set_nominations/_tag_nominations_by_fandom.html.erb
    
    Co-Authored-By: sarken <sarken@gmail.com>
    
    * Update app/views/tag_set_nominations/_tag_nominations_by_fandom.html.erb
    
    Co-Authored-By: sarken <sarken@gmail.com>
    
    * Wraps tag_type_label_name with ts().
    
    * Removes dump.rdb from repository.
    
    * Updates header to use tag_type_label_name helper.
    
    * Address Hound comments regarding spacing and indenting
    
    * Remove use of locale
    
    * Rename tag_type_class to tag_type_css_class
    
    * Update title text on request and offer settings and update pluralization on minimum number to match settings
    
    * Make sure the class and label methods can handle getting a plural passed in
    
    * Correct class name on challenge sign up form
    
    * Correct tag types for tag sets
    
    * Remove extra singularization
    
    * Fix a few more places we were using the tag class rather than the label_name
    
    * Use Freeform.label_name in tag_type_label_name helper
    
    * Downcase tag type in error message and update tag cloud tests to look for 'Additional Tag'
    
    * Update two more wrangling tests to look for Additional Tag rather than Freeform
    
    * Remove a pluralize we don't want
    
    * Adds tag type label updates based on latest PR feedback.
    
    * (refactor) Remove duplication and nesting
    
    This is a code structure change only, attempting to get the code to pass CodeClimate's checks.
    
    * Revert "(refactor) Remove duplication and nesting"
    
    This reverts commit f574bc9.
  5. AO3-5688 Use double quotes and translatable text on delete user previ…

    sarken authored and redsummernight committed Sep 12, 2019
    …ew page (#3632)
    
    * AO3-5688 Look for new co-creator terminology when deleting account
    
    * AO3-5688 Change 'co-author' to 'co-creator' on delete preview
    
    * AO3-5688 Fix indenting
    
    * AO3-5688 From => to :
    
    * AO3-5688 Prefer symbols
    
    * AO3-5688 Prefer double quotes
    
    * AO3-5688 Mostly i18n delete preview page
    
    * AO3-5688 Use double quotes in text
    
    * AO3-5688 Change tests to look for double-quoted orphan
    
    * AO3-5688 Update radio selection step definition to work when there are double quotes
    
    * AO3-5688 Remove unused clause in step definition that would no longer work
    
    * AO3-5688 ...remove the last ? from the clause too
    
    * AO3-5688 Finish removing the unused part of the step definition
Commits on Sep 10, 2019
  1. [Security] Bump devise from 4.6.1 to 4.7.1 (#3627)

    dependabot-preview authored and CristinaRO committed Sep 10, 2019
    Bumps [devise](https://github.com/plataformatec/devise) from 4.6.1 to 4.7.1. **This update includes a security fix.**
    - [Release notes](https://github.com/plataformatec/devise/releases)
    - [Changelog](https://github.com/plataformatec/devise/blob/master/CHANGELOG.md)
    - [Commits](plataformatec/devise@v4.6.1...v4.7.1)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
  2. AO3-5688 Change "co-author" to "co-creator" on delete preview page (#…

    sarken authored and CristinaRO committed Sep 10, 2019
    …3630)
    
    * AO3-5688 Look for new co-creator terminology when deleting account
    
    * AO3-5688 Change 'co-author' to 'co-creator' on delete preview
    
    * AO3-5688 Fix indenting
    
    * AO3-5688 From => to :
    
    * AO3-5688 Prefer symbols
    
    * AO3-5688 Prefer double quotes
  3. AO3-5024 Correct error message when entering wrong password for admin (

    sarken authored and CristinaRO committed Sep 10, 2019
    …#3629)
    
    * AO3-5024 Add test to look for correct error message
    
    * AO3-5024 Update error message when entering wrong password for existing admin
    
    * AO3-5024 Tidy authenticate_admins feature tests
    
    * Spacing!
    * Use the user-facing labels!
    * New descriptions of scenarios!
  4. AO3-5655 Move admin_helper_spec to the correct folder (#3626)

    redsummernight authored and sarken committed Sep 10, 2019
    Mark all specs in spec/miscellaneous/helpers as helper specs
    by default.
  5. AO3-5750 Upgrade factory_girl to factory_bot (#3615)

    CristinaRO committed Sep 10, 2019
    * (chore) Use dynamic attributes in all factories
    
    Latest factory_bot doesn't allow static attributes, so we need to replace all of them with dynamic attributes before updating the bot.
    
    * Use the factory_bot gems instead of factory_girl
    
    The gem previously known as `factory_girl` (with its associated Rails specific `factory_girl_rails`) is now `factory_bot` (and `factory_bot_rails` respectively), so any version updates will happen to the ’`bot`.
    
    It’s good practice to have the latest stable versions of gems if they’re compatible with our code without too much fuss.
    
    I’ve used the official migration guide:
    https://github.com/thoughtbot/factory_bot/blob/4-9-0-stable/UPGRADE_FROM_FACTORY_GIRL.md
    
    Attempting to jump to the latest version (5.0.2 at the time of writing) had too many failures, so I'm now taking it in steps.
    
    The first step is as close to a drop-in replacement as possible, by locking `factory_bot` at 4.8.2.
    
    We still needed to update pickle at the same time, or the tests would fail because of some nonsense with virtual attributes such as `terms_of_service` and `age_over_13` in user factories.
    
    * Obey the Hound
    
    * Attempt upgrade from 4.8.2 to 4.11.1
    
    This is the last 4.x version.
    
    * Upgrade to the latest version of factory_bot
    
    At the time of writing, the latest version is 5.0.2.
    
    * Allow any 5.x versions of factory_bot
    
    There doesn't seem to be a point to locking down to a specific minor version of factory_bot. Matching to major versions only is a good idea, though.
    
    * Downgrade gems shared with non-test environments
    
    In order to keep this PR's scope test-only, downgrade the gems that are shared between test and non-test environments as requested [1], and see if the tests still pass.
    
    [1] #3615 (comment)
  6. AO3-5733 Check the current user is a maintainer before showing privil…

    CristinaRO committed Sep 10, 2019
    …eged info (#3613)
    
    * (fix) Check the current user is a maintainer before showing privileged info
    
    Previously, we were assuming that the `@collection` variable being set means a mod is the user currently looking at the page.
    
    This assumption turned out to be erroneous, because `@collection` is also set when a non-maintainer user has multiple assignments in the same challenge.
    
    The reason this happens for users with multiple assignments is that the challenge sidebar sends the user to a different path when that's the case:
    ```
        <% elsif @challenge_assignments.size > 1 %>
          <li><%= span_if_current ts("My Assignments"), user_assignments_path(current_user, :collection_id => @collection.name) %>
        <% end %>
    ```
    
    This goes to the `index` action of the `challenge_assignments_controller`, where this happens:
    ```
      def index
        if params[:user_id] && (@user = User.find_by(login: params[:user_id]))
          if current_user == @user
            if params[:collection_id] && (@collection = Collection.find_by(name: params[:collection_id]))
    ```
    and `@collection` gets assigned.
    
    * AO3-5733 Add tests
    
    * AO3-5733 Remove extra blank line in tests
    
    * AO3-5733 Update syntax before red has to tell me to
    
    * AO3-5733 Add code comment
  7. AO3-5688 link to orphaning faq in account deletion preview (#3599)

    dlhardin authored and CristinaRO committed Sep 10, 2019
  8. AO3-5673 added delimiter to fandom/users/works count on homepage (#3600)

    dlhardin authored and CristinaRO committed Sep 10, 2019
  9. AO3-5179 Delete About Orphaning page and replace links with FAQ (#3083)

    sarken authored and CristinaRO committed Sep 10, 2019
    * AO3-5179 Delete About Orphaning page and replace links with FAQ
    
    * AO3-5179 Remove all trace of the About Orphaning page
  10. AO3-5077 Fix TOS FAQ Anchor Links (#3606)

    sarken authored and CristinaRO committed Sep 10, 2019
  11. AO3-5730 Fix labels for chapter title and number in new work form (#3621

    lethnie authored and CristinaRO committed Sep 10, 2019
    )
  12. AO3-5583 Add an anchor to the comment page links. (#3598)

    tickinginstant authored and CristinaRO committed Sep 10, 2019
Older
You can’t perform that action at this time.