Skip to content
Permalink
Tag: v0.9.265.1
Commits on Nov 28, 2019
  1. AO3-5825 Cache work and bookmark counts on dashboard sidebar (#3695)

    redsummernight authored and sarken committed Nov 28, 2019
    * AO3-5825 Cache work and bookmark counts on dashboard sidebar
    
    This cuts down on the number of Elasticsearch count queries.
    
    Unlike cached search results in WorksController, cached keys
    for the counts are not timestamped and cannot be invalidated by
    e.g. WorksOwner#update_works_index_timestamp. The counts will lag
    behind the actual search results.
    
    * AO3-5825 Remove print_ prefix in related sidebar helpers
    
    * AO3-5825 Add race_condition_ttl
    
    * AO3-5825 Fix style
    
    * AO3-5825 Add comment on alternative cache key implementation
  2. AO3-5826 Update nokogiri to 1.10.5 (#3697)

    sarken authored and redsummernight committed Nov 28, 2019
    * [Security] Bump nokogiri from 1.10.4 to 1.10.5
    
    Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.4 to 1.10.5. **This update includes a security fix.**
    - [Release notes](https://github.com/sparklemotion/nokogiri/releases)
    - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
    - [Commits](sparklemotion/nokogiri@v1.10.4...v1.10.5)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    * Remove code for closing uncode tags that relied on an error message that no longer exists in libxml2
    
    * Test that shows contents of third paragraph are not as expected
    
    * Remove code for closing uncode tags that relied on an error message that no longer exists in libxml2
    
    * ACTUALLY the test that shows the contents of the third paragraph
    
    * Third time is the charm showing the useful test failure
    
    * Write a passing test and add a comment explaining it does not really resemble reality
Commits on Nov 23, 2019
  1. AO3-5749 Fix Elasticsearch 6.8.5 on Codeship (#3694)

    redsummernight authored and elzj committed Nov 23, 2019
    Change --strip-components=1 to --strip-components=2 in tar.
Commits on Nov 22, 2019
  1. AO3-5749 Update Elasticsearch to 6.8.5 and its gem to 6.8.0 (#3617)

    3 people committed Nov 22, 2019
    * Update to last 6.x release
    
    * Update to 6.8.4 in CI
    
    * AO3-5749 Bump to tests to 6.8.5
    
    Co-authored-by: sarken <sarken@gmail.com>
    Co-authored-by: redsummernight <redsummernight@users.noreply.github.com>
Commits on Nov 16, 2019
  1. AO3-4605 Add language field to import work form (#3153)

    3 people committed Nov 16, 2019
    * AO3-4605 Add language field to import from url page
    
    * Use no default in language dropdown
    
    * Validate required language on the import form
    
    * Move the required language select up top
    
    * Keep language selection after errors, update all importing tests
    
    Co-authored-by: sarken <sarken@gmail.com>
    Co-authored-by: redsummernight <redsummernight@users.noreply.github.com>
Commits on Nov 15, 2019
  1. AO3-5814 Allow skipping Codeship tests using commit messages (#3690)

    redsummernight authored and sarken committed Nov 15, 2019
    Update Codeship scripts to skip the setup and test pipelines
    when the commit message contains "skip codeship tests" (with
    square brackets).
    
    Other updates:
    
    - Skip installing Redis 3.2.1, as Codeship's version is now later (4.0.9).
    - Skip installing MySQL 5.7.22, as Codeship's version is now later (5.7.27).
      The default instance uses port 3306.
    - Use Codeship's script for installing and starting Elasticsearch.
    - Remove code for resetting coverage in the retry script, as we
      no longer generate coverage on Codeship.
    - Generate just the test database using rake db:create instead of
      rake db:create:all.
    - Split up test_prepare.sh. This script is run twice (once for specs,
      once for features) but most of it only needs to be run once
      (e.g. installing dependencies).
    - Download wkhtmltopdf into a directory cached between builds.
Commits on Nov 13, 2019
  1. AO3-5102 Don't show when challenge sign-ups were closed; change "auth…

    sarken authored and redsummernight committed Nov 13, 2019
    …ors revealed" to "creators" (#2996)
    
    * AO3-5102 Don't display what date a challenge's sign-ups were closed at, because the date did not reflect reality, just the inputted date
    
    * AO3-5102 Change 'Authors Revealed' to 'Creators Revealed' on collection profile page
    
    * AO3-5102 Change 'Authors revealed' on challenge form to 'Creators revealed'
    
    * AO3-5102 Update the time zone test for gift exchanges to make sure there is still a time zone listed on the challenge profile
    
    * AO3-5102 Fix test I mangled in the merge
    
    * AO3-5102 Fix test steps being in wrong order
  2. AO3-5616 Fix FAQ category display with RTL scripts (#3670)

    palindromordnilap authored and sarken committed Nov 13, 2019
Commits on Nov 12, 2019
  1. AO3-5814 Move CI scripts, remove unused scripts (#3688)

    redsummernight authored and sarken committed Nov 12, 2019
    CI scripts now live in script/codeship and script/travis.
    Get the renames out of the way before modifying the files.
    
    Remove scripts that use absent gems (delayed_job, find), that are
    deprecated (script/process, see https://github.com/rails/irs_process_scripts)
    or redundant (rails, cucumber).
  2. Update README.md (#3689)

    redsummernight authored and sarken committed Nov 12, 2019
    - Rename ACKNOWLEGMENTS.md to ACKNOWLEDGMENTS.md
    - Use https where possible
    - Link coverage badge to the master branch on Codecov
    
    [skip ci]
  3. AO3-5815 Add shared examples for mailer specs (#3687)

    sarken authored and redsummernight committed Nov 12, 2019
    * AO3-5815 Create and use shared example for translated emails
    
    * AO3-5815 Create and use shared example for emails with valid senders
    
    * AO3-5815 Create and use shared example for checking for exposed HTML
    
    * AO3-5815 Use have_subject when checking subject
    
    * AO3-5815 Put shared examples in own file and folder
    
    * AO3-5815 Prefer let to instance variables
    
    * AO3-5815 Use Faker for work titles in user_mailer_spec
    
    The work titles in the test were previously set up in such a way
    that even if the work with the first title wasn't being listed,
    the tests would still pass (because the second title contained
    the full text of the first). Further, the text of the first title
    was also in the email body.
    
    * AO3-5815 Use consistent description when checking email content
    
    * AO3-5815 Prefer email spec helpers when checking email content
    
    * AO3-5815 Arrange by method name
    
    * AO3-5815 Use double quotes in user_mailer_spec
    
    * AO3-5815 Alignment fixes in user_mailer_spec
    
    * AO3-5815 Use map instead of collect in multipart email shared example
    
    * AO3-5815 Combine HTML quality check shared example with multipart email shared example
    
    * AO3-5815 Remove old helper for multipart emails
    
    * AO3-5815 Remove mailer_macros which appears to be unused
Commits on Nov 11, 2019
  1. AO3-5101 Fix saving open challenges with sign-up close date & no sign…

    sarken authored and redsummernight committed Nov 11, 2019
    …-up open date (#2995)
    
    * AO3-5101 Before comparing the close_ and open_date of challenges with open sign-ups, make sure both dates are actually present
    
    * AO3-5101 Extend prompt meme date test to check a case wherein the sign-up close date is set and sign-up open date is left blank
    
    * AO3-5101 The sign-up close date has to be in the future, so create a step setting it to 'tomorrow'
    
    * AO3-5101 Fix a missing do in a step definition, and change 'updated' to 'created' in the feature for challenge dates
    
    * AO3-5101 Was successfully created. WAS. There is a verb in the message.
  2. AO3-4571 Fix challenge assignment equality check. (#3590)

    tickinginstant authored and sarken committed Nov 11, 2019
    * AO3-4571 Remove "include Comparable."
    
    * AO3-4571 Remove unused comparison function.
    
    * AO3-4571 Re-enable pending cucumber test.
  3. AO3-5194 Update schema and structure files (#3677)

    redsummernight authored and sarken committed Nov 11, 2019
    * AO3-5194 Commit raw schema dumps
    
    * AO3-5194 Remove AUTO_INCREMENTs from SQL dump
    
    * AO3-5194 Update version of schema.rb
  4. AO3-5593 Rewrite definition of approved_collections. (#3502)

    tickinginstant authored and sarken committed Nov 11, 2019
    * AO3-5593 Fix approved_collections definition.
    
    * AO3-5593 Make includes() use approved_collections.
    
    * AO3-5593 Fix up two more includes().
  5. AO3-5639 Don't count hits on unrevealed and hidden works (#3633)

    CristinaRO authored and sarken committed Nov 11, 2019
    * AO3-5639 Don't count hits on unrevealed and hidden works
    
    Previously, visiting a work that was part of an unrevealed collection was increasing the hit count, even though all a regular (non-admin) visitor could access was a message about the work being unrevealed, and not the work itself. This was upsetting or spooking out the creators, because "unrevealed" suggests no one can access the work other than its creator(s).
    
    This commit adds a check that the work is not part of an unrevealed collection.
    
    Previously, visiting a work that was hidden by an admin (which all admins can do) was increasing the hit count. This was upsetting to the creators, because "hidden" suggests no one can access the work other than its creator(s).
    
    This commit adds a check that the work is not hidden by admin.
    
    I've also consolidated the checks that prevent a hit count from being recorded into one method, to make the code more readable.
    
    We have briefly discussed disregarding *all* admins visits from hit counts, but decided this was out of scope for this issue, and we do not feel strongly enough about this to allow the scope creep.
    
    * Refactor to respect the house style
    
    We don't usually place access modifiers at method level.
    
    * Obey the reasonable Hounds
    
    Multiline blocks are probably better off surrounded by `do`...`end`.
  6. AO3-5702 Require language when posting a new work (#3614)

    CristinaRO authored and sarken committed Nov 11, 2019
    * AO3-5702 Require language when posting a new work
    
    Previously, the form to post a new work defaulted to selecting English[1] as the work language.
    
    This has lead to numerous works in different languages being listed as "English".
    
    In order to minimise the number of mislabeled works, the language is now required, and there is no default selection.
    
    [1] Or rather the default language, which for the Archive is English.
    
    * AO3-5702 Add the asterisk of requirement
  7. AO3-5790 Fix work and bookmark searches for certain languages (#3667)

    CristinaRO authored and sarken committed Nov 11, 2019
    With thanks to Elz for both figuring out what the issue was, and for the solution.
    
    When we changed the language search to use the language code instead of the numeric ID,
    we didn't set the mapping for that field to `keyword`.
    
    This has worked ok for languages with simple codes having the same capitalisation throughout, but has broken down for languages with mixed capitalisation in their codes, such as português brasileiro (`ptBR`) and português europeu (`ptPT`).
    
    The most elegant solution would be to set the mapping and reindex, but we don't want to do another reindex so soon after we just did a big one, so what we are doing is change the filter.
Commits on Nov 9, 2019
  1. AO3-5812 Disable mobile RTE (#3684)

    sarken authored and redsummernight committed Nov 9, 2019
  2. AO3-5772 Exclude third party or minified JS files from checks (#3685)

    redsummernight authored and sarken committed Nov 9, 2019
    * AO3-5772 Exclude third party or minified JS files from checks
    
    For Hound (jshint) and CodeClimate.
    
    * Use JSHint default configuration
    
    In 2017, Hound started having new clients use JSHint defaults:
    houndci/hound#1294
    
    We started using Hound earlier, so we're still on Hound's
    old config, which is more opinionated:
    https://github.com/houndci/legacy-config/blob/master/jshintrc
    
    Let's start using JSHint defaults.
Commits on Nov 8, 2019
  1. AO3-5811 Disable TinyMCE's context menu (#3683)

    sarken authored and CristinaRO committed Nov 8, 2019
    This stops overriding the browser context menu and thus allows more
    functionality. The trick: you have to right click on text, not empty
    area.
Commits on Nov 7, 2019
  1. AO3-5809 Add paste to RTE context menu and toolbar, and and hr to the…

    sarken authored and redsummernight committed Nov 7, 2019
    … context menu (#3682)
    
    * AO3-5809 Add paste and hr to RTE context menu
    
    * AO3-5809 Re-add image option to context menu
    
    * AO3-5809 Add paste to the toolbar too
    
    And stop Hound's whining about the quotation marks for context menu
Commits on Nov 6, 2019
  1. AO3-5693 Add comment about media blacklist format (#3681)

    sarken authored and zz9pzza committed Nov 6, 2019
Commits on Nov 4, 2019
  1. AO3-5693 Remove invalid closing tags on track and source elements (#3679

    redsummernight authored and sarken committed Nov 4, 2019
    )
    
    * AO3-5693 Remove invalid closing tags on track and source elements
    
    This is a hack until we switch to an HTML5 serializer.
    
    * Fix style
Commits on Nov 3, 2019
  1. AO3-5693 Supply values for whitelisted boolean attributes (#3676)

    sarken authored and redsummernight committed Nov 3, 2019
Commits on Oct 31, 2019
  1. AO3-5693 Restrict width of video elements (#3675)

    sarken authored and redsummernight committed Oct 31, 2019
Commits on Oct 27, 2019
  1. AO3-5693 Allow standard html within audio and video tags (#3668)

    elzj authored and redsummernight committed Oct 27, 2019
    * AO3-5693: Allow standard html within audio and video tags
    
    * Stop the html cleaner from messing with audio and video
  2. AO3-5800 New frontend server for staging (#3671)

    zz9pzza authored and sarken committed Oct 27, 2019
Commits on Oct 26, 2019
  1. AO3-5798 Bump loofah from 2.2.3 to 2.3.1 (#3666)

    dependabot-preview authored and redsummernight committed Oct 26, 2019
    Bumps [loofah](https://github.com/flavorjones/loofah) from 2.2.3 to 2.3.1. **This update includes a security fix.**
    - [Release notes](https://github.com/flavorjones/loofah/releases)
    - [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md)
    - [Commits](flavorjones/loofah@v2.2.3...v2.3.1)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Commits on Oct 24, 2019
  1. AO3-5758 Fix renamed cop in rubocop 0.72.0 (#3665)

    redsummernight authored and sarken committed Oct 24, 2019
    [skip ci]
  2. AO3-5758 Add Hound rules for bundler, layout, and style (#3641)

    redsummernight authored and sarken committed Oct 24, 2019
    * AO3-5758 Add Hound rules for bundler, layout, and style
    
    * Add Layout/IndentArray rule
    
    * Use aligned + trailing for multiline method calls
    
    * Use indented + leading for multiline method calls
Commits on Oct 23, 2019
  1. AO3-5797 Update server names in deploy script for staging (#3663)

    zz9pzza authored and sarken committed Oct 23, 2019
    We're replacing the old staging servers with new VMs running Debian 10.
  2. AO3-5795 Update mysql2 gem for Debian 10 support (#3662)

    zz9pzza authored and sarken committed Oct 23, 2019
Commits on Oct 17, 2019
  1. AO3-4080 Fix CSS regex to support shadow box fully (#3351)

    hatal175 authored and sarken committed Oct 17, 2019
    * AO3-4080 Fix css regex to support shadow box fully
    
    * AO3-4080 Remove todo comment
    
    * AO3-4080 Move test for box shadow
Commits on Oct 14, 2019
  1. AO3-5788 Move Travis to Ubuntu Bionic 18.04 (#3653)

    redsummernight authored and sarken committed Oct 14, 2019
    Bionic is closer to the production environment (Debian 10).
Older
You can’t perform that action at this time.