Skip to content
Permalink
Tag: v0.9.267.6
Commits on Dec 14, 2019
  1. AO3-5818 Update Referrer-Policy for YouTube's embedding restrictions (#…

    redsummernight authored and sarken committed Dec 14, 2019
    …3711)
    
    Use strict-origin-when-cross-origin because:
    
    - YouTube embedding can be blocked based on domains and they can block playback
      if referrer information is missing.
    - We still want to avoid sending too much referrer information to other sites
      (see AO3-5632), so sending just the origin (protocol + domain + port, without
      path or querystring) is a good compromise.
    - Within the site, we do need to send the path and querystring, which we use
      to identify last known visited pages and to calculate hit counts (#2779).
    
    This is also Rails 5.2's default choice for Referrer-Policy. Rails 5.1 leaves it
    unset.
Commits on Dec 13, 2019
  1. AO3-5813 Remove HTML for mailers from locale file (#3709)

    sarken authored and redsummernight committed Dec 13, 2019
    * AO3-5813 Remove html sent_by key from locale file
    
    This key is only used by a mailer that is no longer used. Ergo
    the mailer and its code should go bye-bye too. Admin notification
    feature was removed in AO3-5043.
    
    * AO3-5813 Remove HTML from footer mailer text in locale
    
    * AO3-5813 Don't include italics in kudo mailer
    
    We reuse the italic bold link style a lot for titles in emails.
    Let's make it a helper.
    
    * AO3-5813 Remove HTML for invite_increase_notification from mailer locale
    
    * AO3-5813 Improve handling of different numbers in invite_increase_notification
    
    Also capitalize Archive because it made Priscilla and me twitch
    
    * AO3-5813 Update specs to be consistent with other reworked mailer specs
    
    * AO3-5813 Spacing fixes in spec files
    
    * AO3-5813 Prefer double quotes
    
    * AO3-5813 Update the text we check for in the invite_increase_notification tests
    
    We don't want any false successes, so let's check for 'invitations, which'
    when there is >1 invitation, and 'invitation, which' when there is only 1.
    
    * AO3-5813 Use new_feedback_report_url in text footer too
    
    * AO3-5813 Make translatable app_short_name for signatures
    
    * AO3-5813 Prefer double quotes in invite_request_declined mailer
Commits on Dec 11, 2019
  1. AO3-5839 Add pseud tests (#3139)

    2 people authored and redsummernight committed Dec 11, 2019
    Add automated tests for changing your default pseud, attempting to create
    multiple pseuds with the same name, and trying to delete a pseud that is
    your default or matches your username.
    
    Co-authored-by: sarken <sarken@gmail.com>
  2. AO3-5838 Expand test coverage of bookmarks controller index action (#…

    sarken authored and redsummernight committed Dec 11, 2019
    …3708)
    
    * Let automated tests use experimental caching setting
    
    * Add and test factories for series and external work bookmarks
    
    * Add coverage for bookmark index when use_caching? is true
    
    * Don't mock use_caching? in work index test; use the admin setting instead
    
    * Hit remaining lines in load_bookmarkable and load_owner
    
    * Update description text to reference the method name a bit more obviously
    
    * Remove duplicate test
    
    * Better organization with contexts
    
    * Consistently use double quotes
    
    * Just add bookmark_search metadata to relevant part of bookmark controller test
    
    * Rephrase existing test descriptions to avoid 'should'
    
    * Begone, hash rocket syntax
    
    * AO3-5838 Remove tests that were trying and failing to cover filtered bookmark and work index pages for tags, users, etc
    
    * AO3-5838 Back where you belong, bookmark_search: true
    
    I moved it to test a change. Then I forgot to put it back.
Commits on Dec 10, 2019
  1. AO3-4991 Reorder series page navigation buttons (#3440)

    niconicosette authored and sarken committed Dec 10, 2019
    * AO3-3507 exclude RSS Feed button from filtered results
    
    * AO3-4991 reorder edit series buttons
    
    * AO3-4991 syntax changes
    
    * AO3-4991 undo accidental AO3-3507 commit
    
    * Remove extra space
Commits on Dec 9, 2019
  1. AO3-5806 Reset and reorganize locale files and reconfigure Phrase (#3680

    sarken authored and zz9pzza committed Dec 9, 2019
    )
    
    * Remove all non-English locale files
    
    Translation would like to start afresh
    
    * Add default rails-i18n locale files for 44 requested locales
    
    * Update config to look for locale files in nested folders
    
    lol, imagine if I had committed this when I wrote it
    
    * Move mailer translations into separate file and folder
    
    * Move view translations into separate file and folder
    
    * Use rails-i18n for en defaults
    
    * Remove defaults from locales/en.yml
    ** confirmation message is different, so check affect on AO3-5113
    ** there are also differences in error handling, but not the messages, so watch for bugs
    
    * Move validator translations into separate file and folder
    
    * Move model translations into separate file and folder and remove now-empty locales/en.yml file
    
    * Move Devise translations into separate folder and rename file
    
    * Update tests for password confirmation error
    
    rails-i18n's en.yml uses different text in the confirmation error than we had.
    This is a good thing.
    
    * Update phraseapp.yml config for Phrase
    
    * New project ID
    * New locations for locale files
    
    * Correct typo in phraseapp config
    
    * Update phraseapp config to ensure output respects our lovely file structure
    
    * Update available_locales
    
    * Update alignment of available_locales array and add quotes for symbols with dashes
    
    * Add README for locale directory
  2. AO3-5773 Avoid re-escaping ampersands in titles of external work book…

    TurkeyFried authored and sarken committed Dec 9, 2019
    …marks (#3658)
    
    * AO3-5773: Decode ampersands/accents/etc on the model before savings
    
    * instead of editing the data while saving, just mark the title as safe
    before displaying it
  3. AO3-5738 Update page that appears after account is set up (#3669)

    palindromordnilap authored and sarken committed Dec 9, 2019
    * AO3-5738 Update account creation page
    
    * AO3-5738 Fix a test
    
    * AO3-5738 Fix security warning ignore
    
    * AO3-5738 Fix another test
    
    * AO3-5738 Fix that ignore, but for real this time
    
    * AO3-5738 brakeman -I
    
    * AO3-5738 Fix requested style changes
    
    * AO3-5738 brakeman -I
  4. AO3-5362 Move background logo down and right (#3660)

    gbhsrspm authored and sarken committed Dec 9, 2019
    Issue:
    
    https://otwarchive.atlassian.net/projects/AO3/issues/AO3-5362
    
    Purpose:
    
    This commit moves the background image on the 'login' page down and to the
    right. This stops the image from being overlapped by banners
    (eg: the 'Please log in' banner).
    
    The issue suggests 2em down and 2em right, but with these dimensions,
    the banner still overlapped the logo, and on mobile screens,
    the logo overlapped the login text on the right. 0.5em was as far as it
    could go! 3em seems to be the minimum it should move down.
    
    Testing:
    
    *Without this patch applied, browse to:
    http://127.0.0.1:7000/users/login
    
    *Apply the patch, restart rails, refresh the page in the browser
    
    *Try a few screen sizes in the web console 'responsive design' mode
  5. AO3-4194 Associate fields/labels of request invites form (#3607)

    sarken committed Dec 9, 2019
    * AO3-4194 Associate fields/labels of request invites form
    
    * AO3-4194 Updated tests to navigate via field labels versus IDs
    
    * AO3-4194 Added missing label elements to work/chapter submissio forms
    
    * AO3-4149 Remove unrelated changes
Commits on Dec 8, 2019
  1. AO3-5834 Rename cache expiration config settings (#3707)

    sarken authored and redsummernight committed Dec 8, 2019
    * AO3-5834 Rename cache expiration config settings
    
    Fix the one in the bookmarks controller that didn't match the config file, causing 500 errors.
    
    * Silence index_from_db output in automated tests
  2. AO3-5832 Update comment on status code for Elasticsearch errors (#3706)

    redsummernight authored and sarken committed Dec 8, 2019
    [skip codeship tests]
Commits on Dec 7, 2019
  1. AO3-5832 Change the HTTP code used for Elasticsearch errors (#3705)

    zz9pzza authored and sarken committed Dec 7, 2019
    * change the http code
    
    * Error 445 not 444
Commits on Dec 5, 2019
  1. AO3-5836 Change deployment servers (#3704)

    zz9pzza authored and sarken committed Dec 5, 2019
    * The servers keep changing
    
    * White space and hound
Commits on Dec 4, 2019
  1. AO3-5762 Simplify search setup in feature tests (#3703)

    redsummernight authored and sarken committed Dec 4, 2019
    Use new Indexer methods for setting up search indices.
    
    Search setup for fixtures are now faster:
    
    - Previously: delete/create indices, load fixtures, delete/create indices,
      queue fixtures for indexing.
    - Now: delete/create indices, load fixtures, queue fixtures for indexing.
    
    Remove a TODO in tag_query_wrangling_spec.rb. Tag callbacks are run
    correctly, so we don't need to queue tags for indexing.
Commits on Dec 2, 2019
  1. AO3-5762 Only do search setup in rspec when needed (#3640)

    elzj authored and sarken committed Dec 2, 2019
    * AO3-5762: Begin running indexes only when necessary in specs
    
    * AO3-5762: Fix hook syntax
    
    * AO3-5762: Update spec syntax
    
    * AO3-5762: Restore single-sharding to tests and name argument for clarity
    
    * AO3-5762: Fix ill-advised indentation
    
    * AO3-5762 Fix style
    
    * AO3-5762 Delete indices after each test
    
    Also allow refreshing indices only in tests.
  2. AO3-5832 Return 444 for Elasticsearch errors (#3701)

    zz9pzza authored and redsummernight committed Dec 2, 2019
    * Redirect Elasticsearch::Transport::Transport::Errors::ServiceUnavailable to our custom error
    
    * Follow the hound
    
    * AO3-5832 Add a comment for 444
Commits on Dec 1, 2019
  1. AO3-5834 Allow cache expiration on works and bookmarks to be configur…

    zz9pzza authored and sarken committed Dec 1, 2019
    …able (#3700)
    
    * Make cache on bookmark and work expiry time configuable
    
    * Add comment
    
    * whitespace
    
    * Follow review
    
    * Remove the extra whitespace
  2. AO3-5832 Add Error 444 page for Elasticsearch (#3699)

    sarken authored and redsummernight committed Dec 1, 2019
    * AO3-5832 Add Error 444 page for Elasticsearch
    
    * AO3-5832 Reword to 'traffic'
    
    [skip codeship tests]
  3. AO3-5817 Check contents of decoded emails in specs (#3696)

    sarken authored and redsummernight committed Dec 1, 2019
    * AO3-5817 Use have_body_text to check for non-ASCII characters
    
    * AO3-5817 Add custom matcher for HTML email body
    
    * AO3-5817 Define and use custom matchers for checking email part contents
    
    Also corrects a few instances where we were using have_body_text
    but wanted to check the text content, not just HTML.
    
    * AO3-5817 Check decoded contents in user_mailer_spec shared examples too
    
    * AO3-5817 Make sure the error and the email contents are both included when test fails
    
    * AO3-5817 Make admin_mailer_spec more consistent with user_mailer_spec
    
    Divide by type of email we're testing.
    Don't use have_body_text.
    Test that it's a multipart email.
    
    * AO3-5817 Correct name of method being tested in admin_mailer_spec
    
    * AO3-5817 Update abuse_mailer_spec
    
    Use method name.
    Eliminate redundancy.
    Divide into HTML and text email versions.
    Check multipart email behavior.
    Don't use have_body_text.
    
    * AO3-5817 Update feedback_mailer_spec
    
    Use method name as description.
    Fix indenting and style.
    Rename mail email.
    Test bheaves likes multipart email.
    Check text in HTML and text emails.
    
    * AO3-5817 Don't use have_body_text in shared examples
    
    * AO3-5817 Prefer shared example for testing sender of spam alert and abuse report
    
    * AO3-5817 Test all admin mailer methods in admin_mailer_spec
    
    * AO3-5817 Use have_[whatever]_part_content in checking contents of send_spam_alert
Commits on Nov 28, 2019
  1. AO3-5825 Cache work and bookmark counts on dashboard sidebar (#3695)

    redsummernight authored and sarken committed Nov 28, 2019
    * AO3-5825 Cache work and bookmark counts on dashboard sidebar
    
    This cuts down on the number of Elasticsearch count queries.
    
    Unlike cached search results in WorksController, cached keys
    for the counts are not timestamped and cannot be invalidated by
    e.g. WorksOwner#update_works_index_timestamp. The counts will lag
    behind the actual search results.
    
    * AO3-5825 Remove print_ prefix in related sidebar helpers
    
    * AO3-5825 Add race_condition_ttl
    
    * AO3-5825 Fix style
    
    * AO3-5825 Add comment on alternative cache key implementation
  2. AO3-5826 Update nokogiri to 1.10.5 (#3697)

    sarken authored and redsummernight committed Nov 28, 2019
    * [Security] Bump nokogiri from 1.10.4 to 1.10.5
    
    Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.4 to 1.10.5. **This update includes a security fix.**
    - [Release notes](https://github.com/sparklemotion/nokogiri/releases)
    - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
    - [Commits](sparklemotion/nokogiri@v1.10.4...v1.10.5)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    * Remove code for closing uncode tags that relied on an error message that no longer exists in libxml2
    
    * Test that shows contents of third paragraph are not as expected
    
    * Remove code for closing uncode tags that relied on an error message that no longer exists in libxml2
    
    * ACTUALLY the test that shows the contents of the third paragraph
    
    * Third time is the charm showing the useful test failure
    
    * Write a passing test and add a comment explaining it does not really resemble reality
Commits on Nov 23, 2019
  1. AO3-5749 Fix Elasticsearch 6.8.5 on Codeship (#3694)

    redsummernight authored and elzj committed Nov 23, 2019
    Change --strip-components=1 to --strip-components=2 in tar.
Commits on Nov 22, 2019
  1. AO3-5749 Update Elasticsearch to 6.8.5 and its gem to 6.8.0 (#3617)

    3 people committed Nov 22, 2019
    * Update to last 6.x release
    
    * Update to 6.8.4 in CI
    
    * AO3-5749 Bump to tests to 6.8.5
    
    Co-authored-by: sarken <sarken@gmail.com>
    Co-authored-by: redsummernight <redsummernight@users.noreply.github.com>
Commits on Nov 16, 2019
  1. AO3-4605 Add language field to import work form (#3153)

    3 people committed Nov 16, 2019
    * AO3-4605 Add language field to import from url page
    
    * Use no default in language dropdown
    
    * Validate required language on the import form
    
    * Move the required language select up top
    
    * Keep language selection after errors, update all importing tests
    
    Co-authored-by: sarken <sarken@gmail.com>
    Co-authored-by: redsummernight <redsummernight@users.noreply.github.com>
Commits on Nov 15, 2019
  1. AO3-5814 Allow skipping Codeship tests using commit messages (#3690)

    redsummernight authored and sarken committed Nov 15, 2019
    Update Codeship scripts to skip the setup and test pipelines
    when the commit message contains "skip codeship tests" (with
    square brackets).
    
    Other updates:
    
    - Skip installing Redis 3.2.1, as Codeship's version is now later (4.0.9).
    - Skip installing MySQL 5.7.22, as Codeship's version is now later (5.7.27).
      The default instance uses port 3306.
    - Use Codeship's script for installing and starting Elasticsearch.
    - Remove code for resetting coverage in the retry script, as we
      no longer generate coverage on Codeship.
    - Generate just the test database using rake db:create instead of
      rake db:create:all.
    - Split up test_prepare.sh. This script is run twice (once for specs,
      once for features) but most of it only needs to be run once
      (e.g. installing dependencies).
    - Download wkhtmltopdf into a directory cached between builds.
Commits on Nov 13, 2019
  1. AO3-5102 Don't show when challenge sign-ups were closed; change "auth…

    sarken authored and redsummernight committed Nov 13, 2019
    …ors revealed" to "creators" (#2996)
    
    * AO3-5102 Don't display what date a challenge's sign-ups were closed at, because the date did not reflect reality, just the inputted date
    
    * AO3-5102 Change 'Authors Revealed' to 'Creators Revealed' on collection profile page
    
    * AO3-5102 Change 'Authors revealed' on challenge form to 'Creators revealed'
    
    * AO3-5102 Update the time zone test for gift exchanges to make sure there is still a time zone listed on the challenge profile
    
    * AO3-5102 Fix test I mangled in the merge
    
    * AO3-5102 Fix test steps being in wrong order
  2. AO3-5616 Fix FAQ category display with RTL scripts (#3670)

    palindromordnilap authored and sarken committed Nov 13, 2019
Commits on Nov 12, 2019
  1. AO3-5814 Move CI scripts, remove unused scripts (#3688)

    redsummernight authored and sarken committed Nov 12, 2019
    CI scripts now live in script/codeship and script/travis.
    Get the renames out of the way before modifying the files.
    
    Remove scripts that use absent gems (delayed_job, find), that are
    deprecated (script/process, see https://github.com/rails/irs_process_scripts)
    or redundant (rails, cucumber).
  2. Update README.md (#3689)

    redsummernight authored and sarken committed Nov 12, 2019
    - Rename ACKNOWLEGMENTS.md to ACKNOWLEDGMENTS.md
    - Use https where possible
    - Link coverage badge to the master branch on Codecov
    
    [skip ci]
  3. AO3-5815 Add shared examples for mailer specs (#3687)

    sarken authored and redsummernight committed Nov 12, 2019
    * AO3-5815 Create and use shared example for translated emails
    
    * AO3-5815 Create and use shared example for emails with valid senders
    
    * AO3-5815 Create and use shared example for checking for exposed HTML
    
    * AO3-5815 Use have_subject when checking subject
    
    * AO3-5815 Put shared examples in own file and folder
    
    * AO3-5815 Prefer let to instance variables
    
    * AO3-5815 Use Faker for work titles in user_mailer_spec
    
    The work titles in the test were previously set up in such a way
    that even if the work with the first title wasn't being listed,
    the tests would still pass (because the second title contained
    the full text of the first). Further, the text of the first title
    was also in the email body.
    
    * AO3-5815 Use consistent description when checking email content
    
    * AO3-5815 Prefer email spec helpers when checking email content
    
    * AO3-5815 Arrange by method name
    
    * AO3-5815 Use double quotes in user_mailer_spec
    
    * AO3-5815 Alignment fixes in user_mailer_spec
    
    * AO3-5815 Use map instead of collect in multipart email shared example
    
    * AO3-5815 Combine HTML quality check shared example with multipart email shared example
    
    * AO3-5815 Remove old helper for multipart emails
    
    * AO3-5815 Remove mailer_macros which appears to be unused
Commits on Nov 11, 2019
  1. AO3-5101 Fix saving open challenges with sign-up close date & no sign…

    sarken authored and redsummernight committed Nov 11, 2019
    …-up open date (#2995)
    
    * AO3-5101 Before comparing the close_ and open_date of challenges with open sign-ups, make sure both dates are actually present
    
    * AO3-5101 Extend prompt meme date test to check a case wherein the sign-up close date is set and sign-up open date is left blank
    
    * AO3-5101 The sign-up close date has to be in the future, so create a step setting it to 'tomorrow'
    
    * AO3-5101 Fix a missing do in a step definition, and change 'updated' to 'created' in the feature for challenge dates
    
    * AO3-5101 Was successfully created. WAS. There is a verb in the message.
  2. AO3-4571 Fix challenge assignment equality check. (#3590)

    tickinginstant authored and sarken committed Nov 11, 2019
    * AO3-4571 Remove "include Comparable."
    
    * AO3-4571 Remove unused comparison function.
    
    * AO3-4571 Re-enable pending cucumber test.
  3. AO3-5194 Update schema and structure files (#3677)

    redsummernight authored and sarken committed Nov 11, 2019
    * AO3-5194 Commit raw schema dumps
    
    * AO3-5194 Remove AUTO_INCREMENTs from SQL dump
    
    * AO3-5194 Update version of schema.rb
  4. AO3-5593 Rewrite definition of approved_collections. (#3502)

    tickinginstant authored and sarken committed Nov 11, 2019
    * AO3-5593 Fix approved_collections definition.
    
    * AO3-5593 Make includes() use approved_collections.
    
    * AO3-5593 Fix up two more includes().
Older
You can’t perform that action at this time.