Skip to content
Permalink
Branch: master
Commits on Dec 13, 2019
  1. AO3-5813 Remove HTML for mailers from locale file (#3709)

    sarken authored and redsummernight committed Dec 13, 2019
    * AO3-5813 Remove html sent_by key from locale file
    
    This key is only used by a mailer that is no longer used. Ergo
    the mailer and its code should go bye-bye too. Admin notification
    feature was removed in AO3-5043.
    
    * AO3-5813 Remove HTML from footer mailer text in locale
    
    * AO3-5813 Don't include italics in kudo mailer
    
    We reuse the italic bold link style a lot for titles in emails.
    Let's make it a helper.
    
    * AO3-5813 Remove HTML for invite_increase_notification from mailer locale
    
    * AO3-5813 Improve handling of different numbers in invite_increase_notification
    
    Also capitalize Archive because it made Priscilla and me twitch
    
    * AO3-5813 Update specs to be consistent with other reworked mailer specs
    
    * AO3-5813 Spacing fixes in spec files
    
    * AO3-5813 Prefer double quotes
    
    * AO3-5813 Update the text we check for in the invite_increase_notification tests
    
    We don't want any false successes, so let's check for 'invitations, which'
    when there is >1 invitation, and 'invitation, which' when there is only 1.
    
    * AO3-5813 Use new_feedback_report_url in text footer too
    
    * AO3-5813 Make translatable app_short_name for signatures
    
    * AO3-5813 Prefer double quotes in invite_request_declined mailer
Commits on Dec 11, 2019
  1. AO3-5838 Expand test coverage of bookmarks controller index action (#…

    sarken authored and redsummernight committed Dec 11, 2019
    …3708)
    
    * Let automated tests use experimental caching setting
    
    * Add and test factories for series and external work bookmarks
    
    * Add coverage for bookmark index when use_caching? is true
    
    * Don't mock use_caching? in work index test; use the admin setting instead
    
    * Hit remaining lines in load_bookmarkable and load_owner
    
    * Update description text to reference the method name a bit more obviously
    
    * Remove duplicate test
    
    * Better organization with contexts
    
    * Consistently use double quotes
    
    * Just add bookmark_search metadata to relevant part of bookmark controller test
    
    * Rephrase existing test descriptions to avoid 'should'
    
    * Begone, hash rocket syntax
    
    * AO3-5838 Remove tests that were trying and failing to cover filtered bookmark and work index pages for tags, users, etc
    
    * AO3-5838 Back where you belong, bookmark_search: true
    
    I moved it to test a change. Then I forgot to put it back.
Commits on Dec 9, 2019
  1. AO3-5806 Reset and reorganize locale files and reconfigure Phrase (#3680

    sarken authored and zz9pzza committed Dec 9, 2019
    )
    
    * Remove all non-English locale files
    
    Translation would like to start afresh
    
    * Add default rails-i18n locale files for 44 requested locales
    
    * Update config to look for locale files in nested folders
    
    lol, imagine if I had committed this when I wrote it
    
    * Move mailer translations into separate file and folder
    
    * Move view translations into separate file and folder
    
    * Use rails-i18n for en defaults
    
    * Remove defaults from locales/en.yml
    ** confirmation message is different, so check affect on AO3-5113
    ** there are also differences in error handling, but not the messages, so watch for bugs
    
    * Move validator translations into separate file and folder
    
    * Move model translations into separate file and folder and remove now-empty locales/en.yml file
    
    * Move Devise translations into separate folder and rename file
    
    * Update tests for password confirmation error
    
    rails-i18n's en.yml uses different text in the confirmation error than we had.
    This is a good thing.
    
    * Update phraseapp.yml config for Phrase
    
    * New project ID
    * New locations for locale files
    
    * Correct typo in phraseapp config
    
    * Update phraseapp config to ensure output respects our lovely file structure
    
    * Update available_locales
    
    * Update alignment of available_locales array and add quotes for symbols with dashes
    
    * Add README for locale directory
  2. AO3-4194 Associate fields/labels of request invites form (#3607)

    sarken committed Dec 9, 2019
    * AO3-4194 Associate fields/labels of request invites form
    
    * AO3-4194 Updated tests to navigate via field labels versus IDs
    
    * AO3-4194 Added missing label elements to work/chapter submissio forms
    
    * AO3-4149 Remove unrelated changes
Commits on Dec 8, 2019
  1. AO3-5834 Rename cache expiration config settings (#3707)

    sarken authored and redsummernight committed Dec 8, 2019
    * AO3-5834 Rename cache expiration config settings
    
    Fix the one in the bookmarks controller that didn't match the config file, causing 500 errors.
    
    * Silence index_from_db output in automated tests
Commits on Dec 1, 2019
  1. AO3-5832 Add Error 444 page for Elasticsearch (#3699)

    sarken authored and redsummernight committed Dec 1, 2019
    * AO3-5832 Add Error 444 page for Elasticsearch
    
    * AO3-5832 Reword to 'traffic'
    
    [skip codeship tests]
  2. AO3-5817 Check contents of decoded emails in specs (#3696)

    sarken authored and redsummernight committed Dec 1, 2019
    * AO3-5817 Use have_body_text to check for non-ASCII characters
    
    * AO3-5817 Add custom matcher for HTML email body
    
    * AO3-5817 Define and use custom matchers for checking email part contents
    
    Also corrects a few instances where we were using have_body_text
    but wanted to check the text content, not just HTML.
    
    * AO3-5817 Check decoded contents in user_mailer_spec shared examples too
    
    * AO3-5817 Make sure the error and the email contents are both included when test fails
    
    * AO3-5817 Make admin_mailer_spec more consistent with user_mailer_spec
    
    Divide by type of email we're testing.
    Don't use have_body_text.
    Test that it's a multipart email.
    
    * AO3-5817 Correct name of method being tested in admin_mailer_spec
    
    * AO3-5817 Update abuse_mailer_spec
    
    Use method name.
    Eliminate redundancy.
    Divide into HTML and text email versions.
    Check multipart email behavior.
    Don't use have_body_text.
    
    * AO3-5817 Update feedback_mailer_spec
    
    Use method name as description.
    Fix indenting and style.
    Rename mail email.
    Test bheaves likes multipart email.
    Check text in HTML and text emails.
    
    * AO3-5817 Don't use have_body_text in shared examples
    
    * AO3-5817 Prefer shared example for testing sender of spam alert and abuse report
    
    * AO3-5817 Test all admin mailer methods in admin_mailer_spec
    
    * AO3-5817 Use have_[whatever]_part_content in checking contents of send_spam_alert
Commits on Nov 28, 2019
  1. AO3-5826 Update nokogiri to 1.10.5 (#3697)

    sarken authored and redsummernight committed Nov 28, 2019
    * [Security] Bump nokogiri from 1.10.4 to 1.10.5
    
    Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.4 to 1.10.5. **This update includes a security fix.**
    - [Release notes](https://github.com/sparklemotion/nokogiri/releases)
    - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
    - [Commits](sparklemotion/nokogiri@v1.10.4...v1.10.5)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    * Remove code for closing uncode tags that relied on an error message that no longer exists in libxml2
    
    * Test that shows contents of third paragraph are not as expected
    
    * Remove code for closing uncode tags that relied on an error message that no longer exists in libxml2
    
    * ACTUALLY the test that shows the contents of the third paragraph
    
    * Third time is the charm showing the useful test failure
    
    * Write a passing test and add a comment explaining it does not really resemble reality
Commits on Nov 13, 2019
  1. AO3-5102 Don't show when challenge sign-ups were closed; change "auth…

    sarken authored and redsummernight committed Nov 13, 2019
    …ors revealed" to "creators" (#2996)
    
    * AO3-5102 Don't display what date a challenge's sign-ups were closed at, because the date did not reflect reality, just the inputted date
    
    * AO3-5102 Change 'Authors Revealed' to 'Creators Revealed' on collection profile page
    
    * AO3-5102 Change 'Authors revealed' on challenge form to 'Creators revealed'
    
    * AO3-5102 Update the time zone test for gift exchanges to make sure there is still a time zone listed on the challenge profile
    
    * AO3-5102 Fix test I mangled in the merge
    
    * AO3-5102 Fix test steps being in wrong order
Commits on Nov 12, 2019
  1. AO3-5815 Add shared examples for mailer specs (#3687)

    sarken authored and redsummernight committed Nov 12, 2019
    * AO3-5815 Create and use shared example for translated emails
    
    * AO3-5815 Create and use shared example for emails with valid senders
    
    * AO3-5815 Create and use shared example for checking for exposed HTML
    
    * AO3-5815 Use have_subject when checking subject
    
    * AO3-5815 Put shared examples in own file and folder
    
    * AO3-5815 Prefer let to instance variables
    
    * AO3-5815 Use Faker for work titles in user_mailer_spec
    
    The work titles in the test were previously set up in such a way
    that even if the work with the first title wasn't being listed,
    the tests would still pass (because the second title contained
    the full text of the first). Further, the text of the first title
    was also in the email body.
    
    * AO3-5815 Use consistent description when checking email content
    
    * AO3-5815 Prefer email spec helpers when checking email content
    
    * AO3-5815 Arrange by method name
    
    * AO3-5815 Use double quotes in user_mailer_spec
    
    * AO3-5815 Alignment fixes in user_mailer_spec
    
    * AO3-5815 Use map instead of collect in multipart email shared example
    
    * AO3-5815 Combine HTML quality check shared example with multipart email shared example
    
    * AO3-5815 Remove old helper for multipart emails
    
    * AO3-5815 Remove mailer_macros which appears to be unused
Commits on Nov 11, 2019
  1. AO3-5101 Fix saving open challenges with sign-up close date & no sign…

    sarken authored and redsummernight committed Nov 11, 2019
    …-up open date (#2995)
    
    * AO3-5101 Before comparing the close_ and open_date of challenges with open sign-ups, make sure both dates are actually present
    
    * AO3-5101 Extend prompt meme date test to check a case wherein the sign-up close date is set and sign-up open date is left blank
    
    * AO3-5101 The sign-up close date has to be in the future, so create a step setting it to 'tomorrow'
    
    * AO3-5101 Fix a missing do in a step definition, and change 'updated' to 'created' in the feature for challenge dates
    
    * AO3-5101 Was successfully created. WAS. There is a verb in the message.
Commits on Nov 9, 2019
  1. AO3-5812 Disable mobile RTE (#3684)

    sarken authored and redsummernight committed Nov 9, 2019
Commits on Nov 8, 2019
  1. AO3-5811 Disable TinyMCE's context menu (#3683)

    sarken authored and CristinaRO committed Nov 8, 2019
    This stops overriding the browser context menu and thus allows more
    functionality. The trick: you have to right click on text, not empty
    area.
Commits on Nov 7, 2019
  1. AO3-5809 Add paste to RTE context menu and toolbar, and and hr to the…

    sarken authored and redsummernight committed Nov 7, 2019
    … context menu (#3682)
    
    * AO3-5809 Add paste and hr to RTE context menu
    
    * AO3-5809 Re-add image option to context menu
    
    * AO3-5809 Add paste to the toolbar too
    
    And stop Hound's whining about the quotation marks for context menu
Commits on Nov 6, 2019
  1. AO3-5693 Add comment about media blacklist format (#3681)

    sarken authored and zz9pzza committed Nov 6, 2019
Commits on Nov 3, 2019
  1. AO3-5693 Supply values for whitelisted boolean attributes (#3676)

    sarken authored and redsummernight committed Nov 3, 2019
Commits on Oct 31, 2019
  1. AO3-5693 Restrict width of video elements (#3675)

    sarken authored and redsummernight committed Oct 31, 2019
Commits on Oct 13, 2019
  1. AO3-5787 Add supported public site skins to repository for tracking p…

    sarken authored and redsummernight committed Oct 13, 2019
    …urposes (#3651)
    
    * Update stylesheet README and convert it to markdown format
    
    * AO3-5787 Add Reversi to repository
    
    * AO3-5787 Add Low Vision Default and README to repository
    
    * AO3-5787 Add Snow and README to repository
    
    * AO3-5787 Add Snow Blue and README to repository
    
    * AO3-5787 Fix copy/paste error in Low Vision Default README
    
    * AO3-5787 Add README for Reversi
    
    * AO3-5787 Fix Snow README
    
    [skip ci]
Commits on Oct 12, 2019
  1. AO3-4353 AO3-5786 Cache tag sets with tag types, fix 500 when listing…

    sarken authored and redsummernight committed Oct 12, 2019
    … tags in tag sets (#3625)
    
    * AO3-4353 Add tag type to tag set show options cache key
    
    * AO3-4353 Tidy the view
    
    * AO3-4353 Touch the tag set when the set taggings change
    
    * AO3-4353 Fix translation mangled in merge
    
    * AO3-4353 REALLY fix translation mangled in merge
    
    * AO3-4353 Expire tag set show options cache when tags in the set change
    
    * tags_cache_key should cover any wrangling-related changes
    * newest_updated_at should cover changes made by moderator, thanks to touch
      in add_to_set and remove_from_set methods
    
    * AO3-4353 Add missing heading class to h2
    
    * AO3-4353 Remove touch on association between set_taggings and tag_sets
    
    * AO3-4354 Make sure we're not touching an owned_tag_set that doesn't exist
    
    * AO3-4353 Use @tags.cache_key rather than creating a new method that does essentially the same thing
    
    The difference is @tags uses by_name_without_articles to sort
  2. AO3-5785 Prevent mods from adding others' anonymous works to their co…

    sarken authored and redsummernight committed Oct 12, 2019
    …llections (#3650)
    
    * AO3-5785 Tests for moderator adding anonymous work to their collection
    
    * AO3-5785 Test for work creator adding own anonymous work to a second collection
    
    * AO3-5785 Prevent mod from adding anonymous work to their collection
  3. AO3-5191 Update TinyMCE (#3089)

    sarken authored and redsummernight committed Oct 12, 2019
    * AO3-5191 Update TinyMCE to 4.6.7
    
    * AO3-5191 Don't let TinyMCE add branding
    
    * AO3-5191 Update mode on a file
    
    * AO3-5191 Change file permissions back to 644
    
    * AO3-5191 Update to TinyMCE 5.0.16
    
    * AO3-5191 Include lists plugin for TinyMCE
    
    * AO3-5191 Change file permissions back to 644
Commits on Oct 6, 2019
  1. Merge pull request #3648 from zz9pzza/AO3-5784

    sarken committed Oct 6, 2019
    AO3-5784 Update Ruby to 2.6.5
Commits on Sep 29, 2019
  1. Merge branch 'master' into AO3-5037_ruby_2_4_5_upgrade

    sarken committed Sep 29, 2019
Commits on Sep 27, 2019
  1. AO3-5037 Update Ruby version used by Hound

    sarken committed Sep 27, 2019
Commits on Sep 21, 2019
  1. AO3-5613 Prevent error when challenge assignment email contains warni…

    sarken authored and redsummernight committed Sep 21, 2019
    …ng tags (#3639)
    
    * AO3-5613 Tests for challenge notification emails with warning tags
    
    * AO3-5613 Challenge assignment emails with warning tags should not error
    
    * AO3-5613 Challenge assignment emails with warning tags should display proper label
    
    * AO3-5613 Update warning model in locale file
Commits on Sep 15, 2019
  1. AO3-5391 Remove unused taggable methods (#3290)

    sarken authored and redsummernight committed Sep 15, 2019
    * AO3-5391 Remove unused taggable methods
    
    * AO3-5391 Use new method of determining fandom tags for external works
    
    * AO3-5391 Don't use removed methods for showing series tags
    
    * AO3-5391 Update tests for revealing hidden tags
    
    * AO3-5391 Be more specific about where I should not see the warning
    
    * AO3-5391 Enable JavaScript for the more complex hidden tag scenario
    
    * AO3-5391 Use archive_warnings following Warning class rename
    
    * AO3-5391 Ignore Brakeman warning
  2. AO3-5613 Fix revealing hidden warning tags in work meta (#3636)

    sarken authored and redsummernight committed Sep 15, 2019
    * AO3-5613 Update tests to better cover the hide warnings and freeforms preferences
    
    * AO3-5613 Update JavaScript used for hiding warnings
    
    * AO3-5613 Break down blurb_tag_block helper method so the part for handling hidden tags can be reused in work meta
    
    * AO3-5613 Use new show_hidden_tag_link_list_item method to hide warnings and freeforms in work meta
    
    * AO3-5613 Don't include the warnings or freeforms class on the toggle for showing warning or freeform tags in work meta
    
    This is only to be consistent with current behavior. Nothing breaks if it's there.
    
    * AO3-5613 Clarify code comment on tag_block_class_name
    
    * AO3-5613 Bump cache version on work meta
Commits on Sep 12, 2019
  1. AO3-5688 Use double quotes and translatable text on delete user previ…

    sarken authored and redsummernight committed Sep 12, 2019
    …ew page (#3632)
    
    * AO3-5688 Look for new co-creator terminology when deleting account
    
    * AO3-5688 Change 'co-author' to 'co-creator' on delete preview
    
    * AO3-5688 Fix indenting
    
    * AO3-5688 From => to :
    
    * AO3-5688 Prefer symbols
    
    * AO3-5688 Prefer double quotes
    
    * AO3-5688 Mostly i18n delete preview page
    
    * AO3-5688 Use double quotes in text
    
    * AO3-5688 Change tests to look for double-quoted orphan
    
    * AO3-5688 Update radio selection step definition to work when there are double quotes
    
    * AO3-5688 Remove unused clause in step definition that would no longer work
    
    * AO3-5688 ...remove the last ? from the clause too
    
    * AO3-5688 Finish removing the unused part of the step definition
Commits on Sep 10, 2019
  1. AO3-5688 Change "co-author" to "co-creator" on delete preview page (#…

    sarken authored and CristinaRO committed Sep 10, 2019
    …3630)
    
    * AO3-5688 Look for new co-creator terminology when deleting account
    
    * AO3-5688 Change 'co-author' to 'co-creator' on delete preview
    
    * AO3-5688 Fix indenting
    
    * AO3-5688 From => to :
    
    * AO3-5688 Prefer symbols
    
    * AO3-5688 Prefer double quotes
  2. AO3-5024 Correct error message when entering wrong password for admin (

    sarken authored and CristinaRO committed Sep 10, 2019
    …#3629)
    
    * AO3-5024 Add test to look for correct error message
    
    * AO3-5024 Update error message when entering wrong password for existing admin
    
    * AO3-5024 Tidy authenticate_admins feature tests
    
    * Spacing!
    * Use the user-facing labels!
    * New descriptions of scenarios!
  3. AO3-5179 Delete About Orphaning page and replace links with FAQ (#3083)

    sarken authored and CristinaRO committed Sep 10, 2019
    * AO3-5179 Delete About Orphaning page and replace links with FAQ
    
    * AO3-5179 Remove all trace of the About Orphaning page
  4. AO3-5077 Fix TOS FAQ Anchor Links (#3606)

    sarken authored and CristinaRO committed Sep 10, 2019
Commits on Sep 4, 2019
  1. AO3-5658 Update co-creator notification text (#3623)

    sarken authored and zz9pzza committed Sep 4, 2019
    * AO3-5658 Update co-creator notification text
    
    * AO3-5658 Look for new text in test
    
    * AO3-5658 Don't look for portion of test with apostrophe because test will fail
Commits on Sep 1, 2019
  1. AO3-5334 Update confirmation prompt when removing self from series (#…

    sarken authored and redsummernight committed Sep 1, 2019
Commits on Aug 31, 2019
  1. AO3-5334 Rename "Remove Me As Author" to "Remove Me As Co-Creator" (#…

    sarken authored and redsummernight committed Aug 31, 2019
    …3619)
    
    * AO3-5334 Rename Remove Author to Remove Co-Creator on Edit Work page
    
    * Revert "AO3-5334 Rename Remove Author to Remove Co-Creator on Edit Work page"
    
    This reverts commit 1fe3bb7.
    
    * AO3-5334 Rename 'Remove Author' to 'Remove Co-Creator' on Edit Work page
    
    * AO3-5334 Rename 'Remove Author' to 'Remove Co-Creator' on series navigation
    
    * AO3-5334 Update tests to look for new text
    
    * AO3-5334 Update capitalization on co-creator removal for mass editing
    
    * AO3-5334 Update messages when removing creators from works and series
    
    * AO3-5334 Update text in spec to look for 'creator'
    
    * AO3-5334 Update spacing and quotes on a line I touched
Older
You can’t perform that action at this time.