Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 4242: Another way to remove the warning #2053

Merged
merged 1 commit into from Mar 8, 2015

Conversation

zz9pzza
Copy link
Contributor

@zz9pzza zz9pzza commented Mar 4, 2015

@@ -156,7 +156,7 @@ def create_mobi_html
def render_mobi_html(template, basename)
@mobi = true
html = render_to_string(:template => "downloads/#{template}.html", :layout => 'barebones.html')
html = ::Iconv.conv("ASCII//TRANSLIT//IGNORE", "UTF8", html)
html = html.encode('ascii', :undef => :replace, :replace => '')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.

@sarken sarken added Priority: High Priority: High - Broken on Test Merge immediately after approval and removed Priority: High labels Mar 7, 2015
CristinaRO added a commit that referenced this pull request Mar 8, 2015
issue 4242: Another way to remove the warning
@CristinaRO CristinaRO merged commit a73bce3 into otwcode:master Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High - Broken on Test Merge immediately after approval
Projects
None yet
4 participants