Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3060 Don't error when given https URLs for parent & external works #2108

Merged
merged 5 commits into from May 30, 2015

Conversation

sarken
Copy link
Member

@sarken sarken commented May 12, 2015

https://code.google.com/p/otwarchive/issues/detail?id=3060

For internal works, we just want to see if it's a work on the archiveofourown.org domain (APP_HOST) rather than checking if it's on http://archiveofourown.org (APP_URL).

For external works, we want to turn the https:// into http:// automatically

url
end

url

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.67%) to 73.18% when pulling a4518be on sarken:issue_3060 into 4bb9f9a on otwcode:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.67%) to 73.18% when pulling a4518be on sarken:issue_3060 into 4bb9f9a on otwcode:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.15%) to 73.71% when pulling a4518be on sarken:issue_3060 into 4bb9f9a on otwcode:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 73.86% when pulling 118698c on sarken:issue_3060 into 4bb9f9a on otwcode:master.

@zz9pzza
Copy link
Contributor

zz9pzza commented May 14, 2015

In a more perfect world we would have a list of url's that we can be reached at. Or we would fetch the url and see if it redirected to APP_HOST

@sarken sarken modified the milestone: 0.9.63: Grab bag May 17, 2015
ariana-paris added a commit that referenced this pull request May 30, 2015
3060 Don't error when given https URLs for parent & external works
@ariana-paris ariana-paris merged commit c20087c into otwcode:master May 30, 2015
@sarken sarken deleted the issue_3060 branch August 4, 2015 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants