AO3-5225 Fix include_private? when pseud_ids are specified. #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarken
added
Awaiting Review
Priority: High - Broken on Test
sarken
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-5225
Purpose
The bookmark count in the sidebar of pseud pages is broken, because the
BookmarkQuery.user_idsfunction checks for the existence ofoptions[:pseud_ids], then usesoptions[:pseud_id]instead. This pull request fixes the typo (and fixes another issue that I noticed, where an admin could potentially be mistaken for the user with the same ID).Testing
Log in as someone with multiple pseuds and at least one private bookmark, and check whether the private bookmark is included in the sidebar count for the pseud with the bookmark.