Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-4560 Rename work posting buttons #3441

Merged
merged 19 commits into from Oct 10, 2019

Conversation

@niconicosette
Copy link
Contributor

niconicosette commented Oct 15, 2018

Issue

https://otwarchive.atlassian.net/browse/AO3-4560

Purpose

rename work posting buttons to be less confusing

Preview | Post Without Preview | Cancel
becomes Preview | Post | Cancel

Save Without Posting | Preview | Post Without Preview | Cancel
becomes Save As Draft | Preview | Post | Cancel

Testing

  1. create an all new work
  2. confirm that the changes detailed above are reflected in the work posting options
Copy link
Member

redsummernight left a comment

We have a number of tests that find these buttons by the label, they all need to be updated.

…ve Without Posting in tests and forms
@@ -70,7 +70,7 @@
else
# Note: this will match the above regexp and work just fine even if all the options are blank!
step %{I set up the draft "#{title}" with fandom "#{fandom}" with character "#{character}" with second character "#{character2}" with freeform "#{freeform}" with second freeform "#{freeform2}" with category "#{category}" in collection "#{collection}" as a gift to "#{recipient}" as part of a series "#{series}" with relationship "#{relationship}" using the pseud "#{pseud}"}
click_button("Post Without Preview")
click_button("Post")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Oct 15, 2018

Style/IdenticalConditionalBranches: Move click_button("Post") out of the conditional.

@niconicosette

This comment has been minimized.

Copy link
Contributor Author

niconicosette commented Oct 15, 2018

all instances i could find of the old button names in tests and pages have been updated and conflicts have been resolved

@redsummernight redsummernight changed the title AO3-4560 rename work posting buttons (to be less confusing) AO3-4560 Rename work posting buttons Oct 15, 2018
Copy link
Member

redsummernight left a comment

Looks good!

@redsummernight

This comment has been minimized.

Copy link
Member

redsummernight commented Feb 10, 2019

Switching over to Needs Coder Action due to merge conflicts.

@niconicosette

This comment has been minimized.

Copy link
Contributor Author

niconicosette commented Feb 10, 2019

all good? 👍

…parser.feature
…rk_download.feature
@niconicosette

This comment has been minimized.

Copy link
Contributor Author

niconicosette commented Jul 21, 2019

travis is still failing but... it doesn't look like it's related to the work posting buttons? (edit) okay one of them might be...

@redsummernight

This comment has been minimized.

Copy link
Member

redsummernight commented Jul 22, 2019

One of the test failures is related, this notice needs to be updated to match the test:

flash[:notice] = ts("Your changes have not been saved. Please post your work or save without posting if you want to keep them.")

Also this comment should be updated:

else # Post Without Preview

@niconicosette

This comment has been minimized.

Copy link
Contributor Author

niconicosette commented Jul 24, 2019

👍 ?

@redsummernight

This comment has been minimized.

Copy link
Member

redsummernight commented Jul 25, 2019

👍 !

@sarken

This comment has been minimized.

Copy link
Member

sarken commented Oct 6, 2019

This has merge conflicts again, but no rush to update it!

@niconicosette

This comment has been minimized.

Copy link
Contributor Author

niconicosette commented Oct 6, 2019

all good?

…, and chapters_controller_spec.rb
features/works/work_edit.feature Outdated Show resolved Hide resolved
@sarken
sarken approved these changes Oct 9, 2019
@sarken sarken merged commit a4f6c0b into otwcode:master Oct 10, 2019
5 checks passed
5 checks passed
Hakiri No security warnings were found.
Details
Hound 1 violation found.
Scrutinizer Analysis: No new issues – Tests: passed
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.