AO3-5649 Sort authors_to_sort_on to match byline

[redsummernight]

Issue

https://otwarchive.atlassian.net/browse/AO3-5649

Purpose

When a work has multiple co-creators, authors_to_sort_on should sort them similar to how the byline does it:

otwarchive/app/helpers/application_helper.rb

Lines 117 to 124 in d7c8504

	def byline_text(creation, only_path, text_only = false)
	if creation.respond_to?(:author)
	creation.author
	else
	pseuds = []
	pseuds << creation.authors if creation.authors
	pseuds << creation.pseuds if creation.pseuds && (!@preview_mode || creation.authors.blank?)
	pseuds = pseuds.flatten.uniq.sort

Testing Instructions

How can the Archive's QA team verify that this is working as you intended? (If you have access, please copy this into the JIRA ticket for them!)

References

See issue. Works need to be reindexed.

[tickinginstant]

Capitalization interacts with this in interesting ways. Pseuds have a custom comparison function that downcases:

otwarchive/app/models/pseud.rb

Lines 133 to 135 in d7c8504

	def <=>(other)
	(self.name.downcase <=> other.name.downcase) == 0 ? (self.user_name.downcase <=> other.user_name.downcase) : (self.name.downcase <=> other.name.downcase)
	end

So the byline helper, which sorts the pseuds before retrieving each pseud's byline (and therefore uses this comparison function), should place "alice" before "Zeke," because when they're downcased, "alice" < "zeke". But this PR sorts after retrieving the names but before downcasing, and "alice" > "Zeke", so I believe this would sort a work co-created by "alice" and "Zeke" among the creators starting with Z.

I tried to run a test to verify, and I think this would be the order for these ten bylines:

1. by alice
2. by alice, zach
3. by Anna
4. by alice, Anna
5. by Anna, zach
6. by Anna, Zeke
7. by zach
8. by Zeke
9. by alice, Zeke
10. by zach, Zeke

[redsummernight]

Thanks! I moved the sort ahead of getting the names.

[tickinginstant]

Looks good! I redid the 10 bylines test with the new code, and it looks nicely ordered.

[sarken]

Marked deferred because this is going in with the Warning class rename because they both need reindexing.