AO3-5697 Add unique index to meta_taggings table. #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For pt-online-schema-change, the argument to --alter corresponding to
this migration is:
ADD UNIQUE INDEX
index_meta_taggings_on_meta_tag_id_and_sub_tag_id
(meta_tag_id, sub_tag_id),
DROP INDEX
index_meta_taggings_on_meta_tag_id
The argument --nocheck-unique-key-change may also be necessary, since
pt-online-schema-change tries to ensure that data will not be lost when
adding a new unique index.
redsummernight
added
the
Has Migrations
sarken
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-5697
Purpose
This PR replaces the index on
meta_tag_idfor themeta_taggingstable with a unique index on(meta_tag_id, sub_tag_id).For
pt-online-schema-change, I believe the argument to--altercorresponding to this migration is:The argument
--nocheck-unique-key-changemay also be necessary, sincept-online-schema-changetries to ensure that data will not be lost when adding a new unique index.