New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-4539 Remove spam verification for logged-in users on the Support, Abuse forms #3674
Conversation
…ed in with the same email as the submitted one.
my comments were too redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, thank you for this! It will make a lot of people quite happy. However, right now, it appears there's a test failure related to these changes. It's in the specs: spec/models/abuse_report_spec.rb:258
Thanks for the heads up! I'll get that sorted out as soon as possible. |
The issue has been solved. I haven't written tests for the new behavior yet, but will try to get that done soon. |
The changes look good! I won't switch the label to "Reviewed: Ready To Merge" yet because you mentioned you were working on some tests. |
Make feedback test spec for same behavior
Pushed the new tests. Will check the Hound violations soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixed conflicts with #3758 which was recently merged. |
Issue
https://otwarchive.atlassian.net/browse/AO3-4539
Purpose
Before running spam verification, checks if the user is logged in, and the email they submit matches the one on their account.
Testing Instructions
Create User with any information and submit both types of forms with generic data without editing the pre-filled fields. Both forms should submit successfully.
With the same user, attempt to submit the same forms, but this time using the email address "akismet-guaranteed-spam@example.com". This should trigger a spam warning on submission.
Repeat last 2 steps without logging in. Fill in the empty fields with standard, valid-looking data. Both steps should yield the same results as a logged in user.
Create another User, with "akismet-guaranteed-spam@example.com" as its email address. Repeat the first step, but this time the forms should accept the "spam" email address.
Credit
What name do you want us to use to credit your work in the Archive of Our Own's Release Notes?
bird
What pronouns do you prefer (she/her, he/him, zie/hir etc)?
they